Killing buffers with mouse

Killing buffers with mouse

[Angelo Graziosi]

I would ask if this behaviour I observed using Emacs-cvs is correct:

When the mouse pointer (an arrow) is on the 'X' icon (Discard current
buffer) of the toolbar, moving the wheel of the mouse, without clicking,
causes the killing of the buffer.

In this manner moving unintentionally the wheel can cause the killing of
many buffers.


Thanks,

   Angelo.

Re: Killing buffers with mouse

[Chong Yidong]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

> I would ask if this behaviour I observed using Emacs-cvs is correct:
>
> When the mouse pointer (an arrow) is on the 'X' icon (Discard current
> buffer) of the toolbar, moving the wheel of the mouse, without clicking,
> causes the killing of the buffer.
>
> In this manner moving unintentionally the wheel can cause the killing of
> many buffers.

Works fine for me with a GTK build.  Maybe this is a limitation of
certain toolkits.

Re: Killing buffers with mouse

[Jan Djärv]

Chong Yidong skrev:
> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> 
>> I would ask if this behaviour I observed using Emacs-cvs is correct:
>>
>> When the mouse pointer (an arrow) is on the 'X' icon (Discard current
>> buffer) of the toolbar, moving the wheel of the mouse, without clicking,
>> causes the killing of the buffer.
>>
>> In this manner moving unintentionally the wheel can cause the killing of
>> many buffers.
> 
> Works fine for me with a GTK build.  Maybe this is a limitation of
> certain toolkits.

It does so with the native tool bar.  It is because any mouse down is used as 
mouse down, not only mouse down with button 1.  It is there in 21.4 as well. 
It is easily fixed, but is it a real bug?

	Jan D.

Re: Killing buffers with mouse

[Eli Zaretskii]

> Date: Fri, 9 Mar 2007 02:06:14 +0100 (MET)
> From: Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
> cc: emacs-devel@gnu.org
> 
> When the mouse pointer (an arrow) is on the 'X' icon (Discard current
> buffer) of the toolbar, moving the wheel of the mouse, without clicking,
> causes the killing of the buffer.

I don't see this in the native Windows version.  Could people please
try this on Unix?

Angelo, please tell what do you see in the buffer displayed by "C-h l"
after you move the wheel over that toolbar icon.  (That's a letter
ell, not the digit one in "C-h l".)

Re: Killing buffers with mouse

[Stefan Monnier]

> It does so with the native tool bar.  It is because any mouse down is used
> as mouse down, not only mouse down with button 1.  It is there in 21.4 as
> well. It is easily fixed, but is it a real bug?

I'd say that it is.  It's OK to accept buttons 1,2,3, but there's no benefit
in accepting buttons 4,5,6,7,8.... whereas there is a significant drawback
since those buttons are typically used for scrolling with touchpads
or wheels and thus aren't "clicks".


        Stefan


PS: I really hope that in post-22 we can refine the toolbar so that we can
put different bindings for different buttons and also different bindings for
the "down" and the "up" events.

Re: Killing buffers with mouse

[Angelo Graziosi]

On Fri, 9 Mar 2007, Eli Zaretskii wrote:

> > Date: Fri, 9 Mar 2007 02:06:14 +0100 (MET)
> > From: Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
> > cc: emacs-devel@gnu.org
> > 
> > When the mouse pointer (an arrow) is on the 'X' icon (Discard current
> > buffer) of the toolbar, moving the wheel of the mouse, without clicking,
> > causes the killing of the buffer.
> 
> I don't see this in the native Windows version.  Could people please
> try this on Unix?

I have seen the same thing on Linux-kubuntu (32 bit) and on Scientific
Linux (64 bit) (and on Cygwin 32 bit).

After moving the wheel (when the pointer is on the 'X' icon of the
toolbar) and the buffer is killed, I observe in the minibuffer:

   tool-bar kill-buffer

i.e. the same thing that happens when I kill the buffer clicking with
MOUSE-1 on that icon.

In other words, it seems that moving the wheel on that icon has the same
result of clicking with MOUSE-1 on it.

> 
> Angelo, please tell what do you see in the buffer displayed by "C-h l"
> after you move the wheel over that toolbar icon.  (That's a letter
> ell, not the digit one in "C-h l".)
> 

Regarding this point, after moving the wheel, C-h l (the lowercase of L),
I have an help buffer:

---------------------------------------------
<help-echo> <help-echo> <down-mouse-1> <mouse-1> <help-echo>
<down-mouse-3> <mouse-3> <double-down-mouse-3> <double-mouse-3>
<help-echo> <help-echo> <tool-bar> <kill-buffer> <help-echo>
<help-echo> <down-mouse-1> <drag-mouse-1> <help-echo>
<help-echo> <down-mouse-2> <mouse-2> <down-mouse-5>
<mouse-5> <help-echo> <help-echo> <help-echo> <tool-bar>
<kill-buffer> <help-echo> <help-echo> C-h l <help-echo>
<help-echo> <down-mouse-1> <mouse-1> <down-mouse-1>
<mouse-movement> <mouse-movement> <help-echo> <mouse-movement>
<mouse-movement> <mouse-movement> <mouse-movement>
<mouse-movement> <help-echo> <mouse-movement> <mouse-movement>
<drag-mouse-1> <help-echo> <help-echo> <help-echo>
<down-mouse-1> <mouse-1> <help-echo> <down-mouse-2>
<mouse-2> <help-echo> <down-mouse-1> <mouse-1> <help-echo>
<down> <return> <return> C-y <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <tool-bar>
<save-buffer> <help-echo> <help-echo> <down-mouse-3>
<mouse-3> <help-echo> <help-echo> <tool-bar> <open-file>
<help-echo> <up> <up> <up> <return> <help-echo> <tool-bar>
<open-file> <up> <up> <up> <return> <help-echo> <help-echo>
<help-echo> <tool-bar> <kill-buffer> C-h l
---------------------------------------------

but I am not sure that what you mean is what I have understood.


Cheers,

   Angelo.

Re: Killing buffers with mouse

[Angelo Graziosi]

It seems that also the other icons on the toolbar are affected by the
wheel of the mouse, i.e. moving the wheel on the icons is equivalent to
click with MOUSE-1 on the same icon.

For example moving the wheel on the icon called 'Read a directory, to
operate on its file' causes in the minibuf.:

   Dired (directory): /tmp/


and similar behaviour for the other icons.


   Angelo.

Re: Killing buffers with mouse

[Jan Djärv]

Stefan Monnier skrev:
>> It does so with the native tool bar.  It is because any mouse down is used
>> as mouse down, not only mouse down with button 1.  It is there in 21.4 as
>> well. It is easily fixed, but is it a real bug?
> 
> I'd say that it is.  It's OK to accept buttons 1,2,3, but there's no benefit
> in accepting buttons 4,5,6,7,8.... whereas there is a significant drawback
> since those buttons are typically used for scrolling with touchpads
> or wheels and thus aren't "clicks".
> 
> 

Ok, I've checked in a fix so we ignore buttons > 3 in the tool bar.

	Jan D.

Re: Killing buffers with mouse

[Eli Zaretskii]

> Date: Fri, 9 Mar 2007 17:46:51 +0100 (MET)
> From: Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
> cc: Chong Yidong <cyd@stupidchicken.com>,
>         =?ISO-8859-1?Q?Jan_Dj=E4rv?= <jan.h.d@swipnet.se>,
>         Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> 
> > 
> > Angelo, please tell what do you see in the buffer displayed by "C-h l"
> > after you move the wheel over that toolbar icon.  (That's a letter
> > ell, not the digit one in "C-h l".)
> > 
> 
> Regarding this point, after moving the wheel, C-h l (the lowercase of L),
> I have an help buffer:
> 
> ---------------------------------------------
> <help-echo> <help-echo> <down-mouse-1> <mouse-1> <help-echo>
> <down-mouse-3> <mouse-3> <double-down-mouse-3> <double-mouse-3>
> <help-echo> <help-echo> <tool-bar> <kill-buffer> <help-echo>
> <help-echo> <down-mouse-1> <drag-mouse-1> <help-echo>
> <help-echo> <down-mouse-2> <mouse-2> <down-mouse-5>
> <mouse-5> <help-echo> <help-echo> <help-echo> <tool-bar>
> <kill-buffer> <help-echo> <help-echo> C-h l <help-echo>
> <help-echo> <down-mouse-1> <mouse-1> <down-mouse-1>
> <mouse-movement> <mouse-movement> <help-echo> <mouse-movement>
> <mouse-movement> <mouse-movement> <mouse-movement>
> <mouse-movement> <help-echo> <mouse-movement> <mouse-movement>
> <drag-mouse-1> <help-echo> <help-echo> <help-echo>
> <down-mouse-1> <mouse-1> <help-echo> <down-mouse-2>
> <mouse-2> <help-echo> <down-mouse-1> <mouse-1> <help-echo>
> <down> <return> <return> C-y <help-echo> <help-echo>
> <help-echo> <help-echo> <help-echo> <help-echo> <tool-bar>
> <save-buffer> <help-echo> <help-echo> <down-mouse-3>
> <mouse-3> <help-echo> <help-echo> <tool-bar> <open-file>
> <help-echo> <up> <up> <up> <return> <help-echo> <tool-bar>
> <open-file> <up> <up> <up> <return> <help-echo> <help-echo>
> <help-echo> <tool-bar> <kill-buffer> C-h l
> ---------------------------------------------
> 
> but I am not sure that what you mean is what I have understood.

That's exactly what I meant, thank you.

As seen from the rest of this thread, the problem has been identified
already, and it is not specific to Cygwin.

Re: Killing buffers with mouse

[Kim F. Storm]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> PS: I really hope that in post-22 we can refine the toolbar so that we can
> put different bindings for different buttons and also different bindings for
> the "down" and the "up" events.

Is that possible with e.g. GTK toolbar or W32 toolbar?

If not, it doesn't make much sense to do it just for the native toolbar.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Killing buffers with mouse

[Jan Djärv]

Kim F. Storm skrev:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
>> PS: I really hope that in post-22 we can refine the toolbar so that we can
>> put different bindings for different buttons and also different bindings for
>> the "down" and the "up" events.
> 
> Is that possible with e.g. GTK toolbar or W32 toolbar?
> 
> If not, it doesn't make much sense to do it just for the native toolbar.
> 

It is possible for GTK, I can't speek for W32.

	Jan D.

Re: Killing buffers with mouse

[Richard Stallman]

    I have seen the same thing on Linux-kubuntu (32 bit) and on Scientific
    Linux (64 bit) (and on Cygwin 32 bit).

You're talking about versions of the GNU operating system.
Please do not call them "Linux" -- that's unfair to us.
Please call them GNU/Linux.  We are the system's principal
developers, so we deserve equal mention.

See http://www.gnu.org/gnu/gnu-linux-faq.html for more
explanation.

Re: Killing buffers with mouse

[Stefan Monnier]

>> PS: I really hope that in post-22 we can refine the toolbar so that we can
>> put different bindings for different buttons and also different bindings for
>> the "down" and the "up" events.
> Is that possible with e.g. GTK toolbar or W32 toolbar?

I don't know.

> If not, it doesn't make much sense to do it just for the native toolbar.

It might be a reason for someone not to spend time on it, but if someone
else decides it's important enough and comes up with a patch, I don't think
it should be grounds to reject the patch.


        Stefan

Re: Killing buffers with mouse

[Kim F. Storm]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> It might be a reason for someone not to spend time on it, but if someone
> else decides it's important enough and comes up with a patch, I don't think
> it should be grounds to reject the patch.

If we are moving towards GTK as default in 23.x, then it better work
with GTK (Jan says it can).  So whoever submits such a patch should
at least make it work with GTK too.

But if it doesn't work on some of the other platforms the use of such
extra features may be limited, as programmers might be reluctant to use
them.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Killing buffers with mouse

[Stefan Monnier]

> But if it doesn't work on some of the other platforms the use of such
> extra features may be limited, as programmers might be reluctant to
> use them.

Right.  But we're talking about the toolbar: just because there was no
toolbar under w32 until Emacs-22 didn't prevent its use.  All it provides is
other ways to do things, so if it's not available, it just means people have
to use menus or key-bindings.  No big problem.


        Stefan