From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chip Coldwell Newsgroups: gmane.emacs.devel Subject: Re: upstream glibc is making trouble again Date: Thu, 9 Aug 2007 15:58:31 -0400 (EDT) Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1186689531 15155 80.91.229.12 (9 Aug 2007 19:58:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2007 19:58:51 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 21:58:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IJE9h-0002B9-8U for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2007 21:58:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJE9g-00005w-Qr for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2007 15:58:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IJE9V-0008T6-Ls for emacs-devel@gnu.org; Thu, 09 Aug 2007 15:58:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IJE9V-0008Sl-A0 for emacs-devel@gnu.org; Thu, 09 Aug 2007 15:58:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJE9U-0008Sf-Vz for emacs-devel@gnu.org; Thu, 09 Aug 2007 15:58:37 -0400 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IJE9U-0006Lx-JU for emacs-devel@gnu.org; Thu, 09 Aug 2007 15:58:36 -0400 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l79JwWr5026538 for ; Thu, 9 Aug 2007 15:58:32 -0400 Original-Received: from mail.boston.redhat.com (mail.boston.redhat.com [172.16.76.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l79JwWSQ029128 for ; Thu, 9 Aug 2007 15:58:32 -0400 Original-Received: from bogart.boston.redhat.com (bogart.boston.redhat.com [172.16.80.240]) by mail.boston.redhat.com (8.13.1/8.13.1) with ESMTP id l79JwVBJ019337 for ; Thu, 9 Aug 2007 15:58:31 -0400 In-Reply-To: X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76270 Archived-At: On Thu, 9 Aug 2007, Chip Coldwell wrote: > I'm having problems building emacs against glibc-2.6.90-4 (Fedora > 8/rawhide GNU/Linux distribution). Here's the relevant section of the > build log: > > gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_GTK -I. -I/builddir/build/BUILD/emacs-22.1/src -D_BSD_SOURCE -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -DMAIL_USE_LOCKF -DSYSTEM_PURESIZE_EXTRA=16777216 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic sound.c > sound.c: In function 'wav_play': > sound.c:618: warning: pointer targets in passing argument 2 of 'sd->write' differ in signedness > sound.c: In function 'au_play': > sound.c:712: warning: pointer targets in passing argument 2 of 'sd->write' differ in signedness > sound.c: In function 'Fplay_sound_internal': > sound.c:1453: warning: pointer targets in passing argument 2 of '__builtin___strcpy_chk' differ in signedness > sound.c:1453: warning: pointer targets in passing argument 2 of '__strcpy_ichk' differ in signedness > sound.c:1472:51: error: macro "open" requires 3 arguments, but only 1 given > sound.c:1472: warning: statement with no effect > make[2]: *** [sound.o] Error 1 > make[2]: Leaving directory `/builddir/build/BUILD/emacs-22.1/src' > make[1]: *** [bootstrap-build] Error 2 > make[1]: Leaving directory `/builddir/build/BUILD/emacs-22.1' > make: *** [bootstrap] Error 2 > > and a link to a discussion that seems relevant also: > > https://www.redhat.com/archives/fedora-maintainers/2007-August/msg00013.html > > Quoting: > > It includes , which provides open, and POSIX allows functions > to be defined as function-like macros. Until recently glibc didn't > define open as a function like macro, but in glibc 2.6.90 and later it > does when -D_FORTIFY_SOURCE=2, to enforce correct use of > open/open64/openat/openat64. > > Any suggestions for a fix? This seems to work --- emacs-22.1/src/sound.c~ 2007-03-06 07:14:14.000000000 -0500 +++ emacs-22.1/src/sound.c 2007-08-09 15:54:52.117018000 -0400 @@ -1469,7 +1469,7 @@ Internal use only, use `play-sound' inst error ("No usable sound device driver found"); /* Open the device. */ - current_sound_device->open (current_sound_device); + (current_sound_device->open) (current_sound_device); /* Play the sound. */ current_sound->play (current_sound, current_sound_device); Chip -- Charles M. "Chip" Coldwell Senior Software Engineer Red Hat, Inc 978-392-2426