unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Davis Herring <herring@lanl.gov>
Cc: emacs-devel@gnu.org
Subject: Re: The `risky-local-variable' blacklist
Date: Tue, 31 Aug 2004 17:18:16 -0600 (MDT)	[thread overview]
Message-ID: <Pine.LNX.4.44.0408311712180.31548-100000@x-mail.lanl.gov> (raw)
In-Reply-To: <m1sma3ndd0.fsf-monnier+emacs@gnu.org>

> You do not understand.  I was speaking very specifically about the
> timeclock-mode-string.  My comments only apply to variables used as
> mode-line-string.

Ah -- the actual mode-line, not the "line in a file that sets the mode".  
Oops.

> I don't think you understand the reason why timeclock-mode-string was not
> dangerous before: timeclock-mode-string can have a value of the form
> (:eval <foo>) which means "evaluate <foo> to get the string to display".
> So there's clearly something dangerous here.  Such evalution-in-mode-string
> is new in Emacs-21, so most foo-mode-line-string variable have suddenly been
> made dangerous.  Instead of going through all those vars and marking them
> risky, Emacs-21 decided that "if the var is not marked `risky', then ignore
> any of those new :eval special forms".  I.e. it's safe either way. but in
> order to be able to use the new feature, you need to mark the var as
> "risky".

The documentation I have for `mode-line-format' has a slight bug, then. It
says that "For a symbol, its value is used (but it is ignored if t or
nil).";  it does not say that the symbol's value is processed recursively
(as it does for the other things that are re-interpreted).  The Elisp 
manual does describe the double-evaluation; should the docstring be 
changed?

> I didn't discuss your general point about risky variables (because I mostly
> agree with it).

Well, I'm glad something I said made sense.  Sorry that the rest was 
noise.

Davis Herring

-- 
This product is sold by volume, not by mass.  If it seems too dense or too 
sparse, it means mass-energy conversion has occurred during shipping.

  reply	other threads:[~2004-08-31 23:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31  2:13 The `risky-local-variable' blacklist Davis Herring
2004-08-31 14:01 ` Stefan
2004-08-31 21:42   ` Davis Herring
2004-08-31 22:43     ` Stefan
2004-08-31 23:18       ` Davis Herring [this message]
2004-08-31 22:07 ` Richard Stallman
2004-08-31 23:07   ` Davis Herring
2004-09-01 19:24     ` Richard Stallman
2004-09-01  7:11   ` Kim F. Storm
2004-09-01 14:36     ` Stefan Monnier
2004-09-02  4:53     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0408311712180.31548-100000@x-mail.lanl.gov \
    --to=herring@lanl.gov \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).