From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: BUG + FIX. Spurious "might not be defined at runtime" from byte-compile-file Date: Tue, 23 May 2006 10:15:06 +0000 (GMT) Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1148379003 25233 80.91.229.2 (23 May 2006 10:10:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 May 2006 10:10:03 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 23 12:10:01 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FiTpw-0002Re-9W for ged-emacs-devel@m.gmane.org; Tue, 23 May 2006 12:10:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FiTpv-0001DW-Py for ged-emacs-devel@m.gmane.org; Tue, 23 May 2006 06:09:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FiTpk-0001Aq-1h for emacs-devel@gnu.org; Tue, 23 May 2006 06:09:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FiTpi-0001Ae-JA for emacs-devel@gnu.org; Tue, 23 May 2006 06:09:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FiTpi-0001Ab-Ga for emacs-devel@gnu.org; Tue, 23 May 2006 06:09:46 -0400 Original-Received: from [193.149.49.134] (helo=acm.acm) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FiTtt-0005g1-8y for emacs-devel@gnu.org; Tue, 23 May 2006 06:14:06 -0400 Original-Received: from localhost (root@localhost) by acm.acm (8.8.8/8.8.8) with SMTP id KAA00955 for ; Tue, 23 May 2006 10:15:07 GMT X-Sender: root@acm.acm Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55117 Archived-At: Hi, Emacs! Evaluate the following: (defun foo () (bar)) (byte-compile 'foo) (defun bar ()) (byte-compile 'bar) Get a cup of coffee, go for a twenty mile run, come back and do some furious hacking. Then do M-x byte-compile-file jrandom.el. You get the spurious warning: ** The function `bar' might not be defined at runtime. This happens because the (byte-compile 'foo) form (correctly) flags 'bar as an unknown function, recording it in byte-compile-unresolved-functions. The subsequent byte-compile-file initialises this variable AFTER doing the compilation rather than before - hence the silly warning. It seems to me this state of affairs was probably caused by the sloppy doc-string for the variable - it doesn't give any context for when its contents are gathered and used, hence hackers were (subconsciously) scared to initialise it properly, fearing they might discard important info. So I've amended the doc-string too. Should I commit this fix? 2006-05-23 Alan Mackenzie * emacs-lisp/bytecomp.el (byte-compile-from-buffer): initialize byte-compile-unresolved-functions before doing a compilation rather than afterwards. Amend the variable's doc-string. Index: bytecomp.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/bytecomp.el,v retrieving revision 2.183 diff -c -r2.183 bytecomp.el *** bytecomp.el 11 Apr 2006 17:58:49 -0000 2.183 --- bytecomp.el 23 May 2006 09:56:18 -0000 *************** *** 453,459 **** (defvar byte-compile-unresolved-functions nil "Alist of undefined functions to which calls have been compiled. ! Used for warnings when the function is not known to be defined or is later defined with incorrect args.") (defvar byte-compile-noruntime-functions nil --- 453,460 ---- (defvar byte-compile-unresolved-functions nil "Alist of undefined functions to which calls have been compiled. ! This variable is only significant whilst compiling an entire buffer. ! Used for warnings when a function is not known to be defined or is later defined with incorrect args.") (defvar byte-compile-noruntime-functions nil *************** *** 1821,1826 **** --- 1822,1832 ---- (save-excursion (set-buffer inbuffer) (goto-char 1) + ;; Should we always do this? When calling multiple files, it + ;; would be useful to delay this warning until all have been + ;; compiled. A: Yes! b-c-u-f might contain dross from a + ;; previous byte-compile. + (setq byte-compile-unresolved-functions nil) ;; Compile the forms from the input buffer. (while (progn *************** *** 1837,1847 **** ;; Make warnings about unresolved functions ;; give the end of the file as their position. (setq byte-compile-last-position (point-max)) ! (byte-compile-warn-about-unresolved-functions) ! ;; Should we always do this? When calling multiple files, it ! ;; would be useful to delay this warning until all have ! ;; been compiled. ! (setq byte-compile-unresolved-functions nil)) ;; Fix up the header at the front of the output ;; if the buffer contains multibyte characters. (and filename (byte-compile-fix-header filename inbuffer outbuffer)))) --- 1843,1849 ---- ;; Make warnings about unresolved functions ;; give the end of the file as their position. (setq byte-compile-last-position (point-max)) ! (byte-compile-warn-about-unresolved-functions)) ;; Fix up the header at the front of the output ;; if the buffer contains multibyte characters. (and filename (byte-compile-fix-header filename inbuffer outbuffer)))) -- Alan.