Re: make bootstrap: need moral support. :-(

[Alan Mackenzie <acm@muc.de>]

Hi, Eli!

On Mon, 20 Feb 2006, Eli Zaretskii wrote:

>> Date: Mon, 20 Feb 2006 04:03:39 +0000 (GMT)
>> From: Alan Mackenzie <acm@muc.de>
>> cc: emacs-devel@gnu.org

>> process.c: In function `conv_sockaddr_to_lisp':
>> process.c:2245: dereferencing pointer to incomplete type
>> process.c:2246: dereferencing pointer to incomplete type
>> process.c:2249: dereferencing pointer to incomplete type
>> process.c:2249: dereferencing pointer to incomplete type
>> process.c:2249: dereferencing pointer to incomplete type
>> <etc>

>> The source code in process.c looks like this:
>> #ifdef AF_INET6
>>     case AF_INET6:
>>       {
>>         struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *) sa;
>>         uint16_t *ip6 = (uint16_t *)&sin6->sin6_addr;      <======= L2245

>This means that the IPv6 configury test is misbehaving.  Please look
>into your headers and try to find out why the configure-time test
>decides that your system supports IPv6, but `struct sockaddr_in6' is
>not defined by your system headers.

In Linux 2.4.17, that struct is defined in the file
linux-2.4.17/include/linux/in6.h/.  Emacs files.c don't #include this
file at all.  I'll have a look at ./configure, sometime.

[ .... ]

>> I worked around this problem by putting #undef AF_INET6 near the top
>> of the file.

>> Emacs then built immediately!

>Well, that's good for you, but what about all the other users who will
>have the same problem?  I'd suggest not to sweep the problem under the
>carpet, but rather try to find out what is wrong with the
>configure-time test, so that it could be fixed for others as well.

OK.  It's just that I didn't have enough confidence in my ability to
build Emacs to assume that this problem was a bug (as contrasted to me
not giving some parameter to ./configure, or something).

>> However, when I started it up, it complained about this form in my
>> site-start.el:

>>     (define-key help-mode-map "\M-n" 'clone-buffer)

>> I had to wrap this form in an (eval-after-load "help-mode" ....).  Is
>> this failure to load help-mode at start-up deliberate, or is it a bug?

>I think it's deliberate: why should we load help-mode before Help
>commands are used?

:-)  It has historically always been so loaded.  Who gets through an
Emacs session without C-h?  But then, loading it early is not that
important.

>Btw, your workaround is not the best way to solve this, I think: each
>mode has a mode hook, precisely for these situations.  Just define a
>function that binds that key and add that function to help-mode-hook.

The key sequence needs binding only once.  Won't help-mode-hook be called
every time a help command is invoked?

-- 
Alan.