From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.cc-mode.general,gmane.emacs.devel Subject: Re: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows] Date: Wed, 15 Feb 2006 19:07:31 +0000 (GMT) Message-ID: References: <87fymod0dt.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1140037104 10727 80.91.229.2 (15 Feb 2006 20:58:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2006 20:58:24 +0000 (UTC) Cc: Ralf Angeli , bug-cc-mode@gnu.org, rms@gnu.org, emacs-devel@gnu.org Original-X-From: cc-mode-help-admin@lists.sourceforge.net Wed Feb 15 21:58:16 2006 Return-path: Envelope-to: sf-cc-mode-help@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F9Tiv-0004I3-5P for sf-cc-mode-help@m.gmane.org; Wed, 15 Feb 2006 21:58:05 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam2.sourceforge.net (Postfix) with ESMTP id 51D1513B3D; Wed, 15 Feb 2006 12:58:04 -0800 (PST) Original-Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1F9TiN-0007OF-3b for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 12:57:31 -0800 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by mail.sourceforge.net with esmtps (TLSv1:RC4-SHA:128) (Exim 4.44) id 1F9TiM-0004Kj-Sn for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 12:57:31 -0800 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.34) id 1F9Ti5-00078D-NU for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 15:57:25 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.52) id 1F9Tn1-0005WM-BF for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 16:02:22 -0500 Original-Received: from [193.149.49.134] (helo=acm.acm) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F9Tms-0005VT-H3; Wed, 15 Feb 2006 16:02:11 -0500 Original-Received: from localhost (root@localhost) by acm.acm (8.8.8/8.8.8) with SMTP id TAA00944; Wed, 15 Feb 2006 19:07:32 GMT X-Sender: root@acm.acm Original-To: Stefan Monnier In-Reply-To: <87fymod0dt.fsf-monnier+emacs@gnu.org> X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 1.0 FORGED_RCVD_HELO Received: contains a forged HELO Original-Sender: cc-mode-help-admin@lists.sourceforge.net Errors-To: cc-mode-help-admin@lists.sourceforge.net X-BeenThere: cc-mode-help@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Bug reports, feature requests, and general talk about CC Mode. List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Wed, 15 Feb 2006 19:07:31 +0000 (GMT) Xref: news.gmane.org gmane.emacs.cc-mode.general:3009 gmane.emacs.devel:50580 Archived-At: On Sun, 12 Feb 2006, Stefan Monnier wrote: >>> This patch to font-lock is exactly the sort of change I was thinking of. >>> Could someone please install it, then rename >>> before-font-lock-after-change-function to >>> font-lock-extend-region-function, and rename >>> font-lock-run-before-after-change-hook to font-lock-extend-region? >.... Based on the name, I suppose it's some kind of hook in >font-lock-after-change-function, in which case I'd be tempted to suggest >to move it to font-lock-fontify-region instead, to reduce the >performance impact and make it easier to deal with lazy-lock&jit-lock >since these tend to use their own after-change-function. I strongly oppose such a change. With that change: (i) font-lock-fontify-region would no longer be fontifying the region specified by its paramters, but a different (possibly larger) one. (ii) the hook function (which recalculates BEG and END) might well refer to variables set by a before-change-functions hook. (This is done in AWK mode, for example). f-l-f-region is regularly called when there is no buffer change in progress. Both of these things would make debugging a hook function much more difficult than it already is. Determining the region to fontify and actually fontifying it are two logically distinct operations. They shouldn't be intermingled with eachother. [ .... ] > Stefan -- Alan Mackenzie (Munich, Germany) ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642