Re: [Emacs-commit] emacs/src window.c

Re: [Emacs-commit] emacs/src window.c

[Angelo Graziosi]

Could this


Romain Francoise wrote:

> Eli Zaretskii <address@hidden> writes:
>
>> Modified files:
>>       src            : window.c
>
>> Log message:
>>       (prefer_window_split_horizontally): New variable.
>>       (display_buffer): Consider splitting window horizontally
>>       depending on
>>       prefer_window_split_horizontally.
>
> Unless I'm mistaken there was no need to install this, Stefan already
> implemented this feature via `split-window-preferred-function'.


be the cause of the problem I dercribed here

http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg00756.html ?



   Angelo.

Re: [Emacs-commit] emacs/src window.c

[Romain Francoise]

Eli Zaretskii <eliz@gnu.org> writes:

> Modified files:
> 	src            : window.c

> Log message:
> 	(prefer_window_split_horizontally): New variable.
> 	(display_buffer): Consider splitting window horizontally depending on
> 	prefer_window_split_horizontally.

Unless I'm mistaken there was no need to install this, Stefan already
implemented this feature via `split-window-preferred-function'.

Re: [Emacs-commit] emacs/src window.c

[Juri Linkov]

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Modified files:
>> 	src            : window.c
>
>> Log message:
>> 	(prefer_window_split_horizontally): New variable.
>> 	(display_buffer): Consider splitting window horizontally depending on
>> 	prefer_window_split_horizontally.
>
> Unless I'm mistaken there was no need to install this, Stefan already
> implemented this feature via `split-window-preferred-function'.

Yes, and Stefan's implementation is superior.

It allows specifying such a preference as splitting windows horizontally
when there are enough horizontal space for two side-by-side windows
(I think this should be added as a new choice to the new variable):

(setq split-window-preferred-function
      (lambda (window)
        (split-window window nil (if (> (frame-width) 160) 'horiz))))

It even allows implementing functionality I missed in Emacs for a long time!
After setting it to the following value:

(setq split-window-preferred-function
      (lambda (window)
        (if (member (buffer-name (window-buffer window))
                    '("*Help*"))
            (selected-window)
          (split-window window nil 'horiz))))

it visits source files from the *Help* buffer in the same window.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: [Emacs-commit] emacs/src window.c

[Richard Stallman]

    > Yes, and Stefan's implementation is superior.

    I installed that change because Richard asked for that.

My message requesting installation of this patch
crossed in the mail with Stefan's message that he had
installed a similar feature.

Since Stefan's is more general, the thing to do is revert the other.

Re: [Emacs-commit] emacs/src window.c

[Romain Francoise]

Richard Stallman <rms@gnu.org> writes:

> My message requesting installation of this patch crossed in the
> mail with Stefan's message that he had installed a similar
> feature.

> Since Stefan's is more general, the thing to do is revert the
> other.

Done.