Failure in building Emacs 23.0.50 on Cygwin (fwd)

Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

Searching Cygwin lists archives, I have found this 'laconic' suggestion,

   http://sourceware.org/ml/cygwin/2001-08/msg00753.html


Could it help in solving our problem?


Cheers,

   Angelo.


---------- Forwarded message ----------
Date: Thu, 30 Aug 2007 01:51:16 +0200
From: Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
To: emacs-devel@gnu.org
Cc: cygwin@cygwin.com
Subject: Failure in building Emacs 23.0.50 on Cygwin


I have tried to bootstrap the last Emacs-23.0.50 CVS (checked out about an
hour ago) on Cygwin, but it fails:

---------------------------------------------------------------
Configuring...
checking build system type... i686-pc-cygwin
checking host system type... i686-pc-cygwin
checking for gcc... gcc
checking for C compiler default output file name... a.exe
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... .exe
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for AIX... no
checking whether gcc understands -Wno-pointer-sign... yes
checking whether ln -s works... yes
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible install... /usr/bin/install -c
checking for ranlib... ranlib
checking for install-info... /usr/bin/install-info
checking for install-info... (cached) /usr/bin/install-info
checking for install-info... (cached) /usr/bin/install-info
checking for gzip... /usr/bin/gzip
checking for makeinfo... /usr/bin/makeinfo
checking for -znocombreloc... no
configure: checking the machine- and system-dependent files to find out
 - which libraries the lib-src programs will want, and
 - whether the GNU malloc routines are usable...
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking machine/soundcard.h usability... no
checking machine/soundcard.h presence... no
checking for machine/soundcard.h... no
checking sys/soundcard.h usability... yes
checking sys/soundcard.h presence... yes
checking for sys/soundcard.h... yes
checking soundcard.h usability... no
checking soundcard.h presence... no
checking for soundcard.h... no
checking for _oss_ioctl in -lossaudio... no
checking for pkg-config... /usr/bin/pkg-config
checking for alsa >= 1.0.0... no
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking sys/timeb.h usability... yes
checking sys/timeb.h presence... yes
checking for sys/timeb.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking utime.h usability... yes
checking utime.h presence... yes
checking for utime.h... yes
checking linux/version.h usability... no
checking linux/version.h presence... no
checking for linux/version.h... no
checking sys/systeminfo.h usability... no
checking sys/systeminfo.h presence... no
checking for sys/systeminfo.h... no
checking termios.h usability... yes
checking termios.h presence... yes
checking for termios.h... yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking for string.h... (cached) yes
checking for stdlib.h... (cached) yes
checking termcap.h usability... yes
checking termcap.h presence... yes
checking for termcap.h... yes
checking stdio_ext.h usability... no
checking stdio_ext.h presence... no
checking for stdio_ext.h... no
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for strings.h... (cached) yes
checking coff.h usability... no
checking coff.h presence... no
checking for coff.h... no
checking pty.h usability... yes
checking pty.h presence... yes
checking for pty.h... yes
checking sys/mman.h usability... yes
checking sys/mman.h presence... yes
checking for sys/mman.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking sys/vlimit.h usability... no
checking sys/vlimit.h presence... no
checking for sys/vlimit.h... no
checking sys/resource.h usability... yes
checking sys/resource.h presence... yes
checking for sys/resource.h... yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking sys/_mbstate_t.h usability... no
checking sys/_mbstate_t.h presence... no
checking for sys/_mbstate_t.h... no
checking sys/utsname.h usability... yes
checking sys/utsname.h presence... yes
checking for sys/utsname.h... yes
checking pwd.h usability... yes
checking pwd.h presence... yes
checking for pwd.h... yes
checking if personality LINUX32 can be set... no
checking for term.h... no
checking for ANSI C header files... (cached) yes
checking whether time.h and sys/time.h may both be included... yes
checking whether sys_siglist is declared... no
checking whether __sys_siglist is declared... no
checking for sys/wait.h that is POSIX.1 compatible... yes
checking for struct utimbuf... yes
checking return type of signal handlers... void
checking for speed_t... yes
checking for struct timeval... yes
checking for struct exception... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking for net/if.h... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking for struct tm.tm_zone... no
checking whether tzname is declared... yes
checking for tzname... yes
checking for struct tm.tm_gmtoff... no
checking for struct ifreq.ifr_flags... yes
checking for struct ifreq.ifr_hwaddr... yes
checking for struct ifreq.ifr_netmask... yes
checking for struct ifreq.ifr_broadaddr... yes
checking for struct ifreq.ifr_addr... yes
checking for function prototypes... yes
checking for working volatile... yes
checking for an ANSI C-conforming const... yes
checking for void * support... yes
checking whether make sets $(MAKE)... yes
checking for long file names... yes
checking for X... libraries /usr/X11R6/lib, headers /usr/X11R6/include
checking Carbon/Carbon.h usability... no
checking Carbon/Carbon.h presence... no
checking for Carbon/Carbon.h... no
checking for malloc_get_state... no
checking for malloc_set_state... no
checking whether __after_morecore_hook exists... no
checking for stdlib.h... (cached) yes
checking for unistd.h... (cached) yes
checking for getpagesize... yes
checking for working mmap... no
checking for dnet_ntoa in -ldnet... no
checking for main in -lXbsd... no
checking for cma_open in -lpthreads... no
checking for XFree86 in /usr/X386... no
checking for Xkb... yes
checking for XrmSetDatabase... yes
checking for XScreenResourceString... yes
checking for XScreenNumberOfScreen... yes
checking for XSetWMProtocols... yes
checking X11 version 6... 6 or newer
checking X11 version 5... 5 or newer
checking for librsvg-2.0 >= 2.0.0... no
checking for xaw3d... yes; using Lucid toolkit
checking X11 toolkit version... 6 or newer
checking for XmuConvertStandardSelection in -lXmu... yes
checking for XShapeQueryExtension in -lXext... yes
checking X11/xpm.h usability... yes
checking X11/xpm.h presence... yes
checking for X11/xpm.h... yes
checking for XpmReadFileToPixmap in -lXpm... yes
checking for XpmReturnAllocPixels preprocessor define... yes
checking jerror.h usability... yes
checking jerror.h presence... yes
checking for jerror.h... yes
checking for jpeg_destroy_compress in -ljpeg... yes
checking png.h usability... yes
checking png.h presence... yes
checking for png.h... yes
checking libpng/png.h usability... yes
checking libpng/png.h presence... yes
checking for libpng/png.h... yes
checking for png_get_channels in -lpng... yes
checking tiffio.h usability... yes
checking tiffio.h presence... yes
checking for tiffio.h... yes
checking for TIFFGetVersion in -ltiff... yes
checking gif_lib.h usability... yes
checking gif_lib.h presence... yes
checking for gif_lib.h... yes
checking for EGifPutExtensionLast in -lgif... no
checking for EGifPutExtensionLast in -lungif... yes
checking gpm.h usability... no
checking gpm.h presence... no
checking for gpm.h... no
checking malloc/malloc.h usability... no
checking malloc/malloc.h presence... no
checking for malloc/malloc.h... no
checking X11/SM/SMlib.h usability... yes
checking X11/SM/SMlib.h presence... yes
checking for X11/SM/SMlib.h... yes
checking for SmcOpenConnection in -lSM... yes
checking whether netdb declares h_errno... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for sqrt in -lm... yes
checking for maillock in -lmail... no
checking for maillock in -llockfile... no
checking for liblockfile.so... no
checking for touchlock... no
checking maillock.h usability... no
checking maillock.h presence... no
checking for maillock.h... no
checking for gethostname... yes
checking for getdomainname... yes
checking for dup2... yes
checking for rename... yes
checking for closedir... yes
checking for mkdir... yes
checking for rmdir... yes
checking for sysinfo... no
checking for getrusage... yes
checking for get_current_dir_name... no
checking for random... yes
checking for lrand48... yes
checking for bcopy... yes
checking for bcmp... yes
checking for logb... yes
checking for frexp... yes
checking for fmod... yes
checking for rint... yes
checking for cbrt... yes
checking for ftime... yes
checking for res_init... no
checking for setsid... yes
checking for strerror... yes
checking for fpathconf... yes
checking for select... yes
checking for mktime... yes
checking for euidaccess... no
checking for getpagesize... (cached) yes
checking for tzset... yes
checking for setlocale... yes
checking for utimes... yes
checking for setrlimit... yes
checking for setpgid... yes
checking for getcwd... yes
checking for getwd... yes
checking for shutdown... yes
checking for getaddrinfo... no
checking for __fpending... no
checking for mblen... yes
checking for mbrlen... yes
checking for mbsinit... yes
checking for strsignal... yes
checking for setitimer... yes
checking for ualarm... yes
checking for index... yes
checking for rindex... yes
checking for sendto... yes
checking for recvfrom... yes
checking for getsockopt... yes
checking for setsockopt... yes
checking for getsockname... yes
checking for getpeername... yes
checking for gai_strerror... no
checking for mkstemp... yes
checking for getline... yes
checking for getdelim... yes
checking for mremap... no
checking for memmove... yes
checking for fsync... yes
checking for sync... yes
checking for bzero... yes
checking for memset... yes
checking for memcmp... yes
checking for difftime... yes
checking for memcpy... yes
checking for mempcpy... yes
checking for mblen... (cached) yes
checking for mbrlen... (cached) yes
checking for posix_memalign... no
checking sys/un.h usability... yes
checking sys/un.h presence... yes
checking for sys/un.h... yes
checking for sys/time.h... (cached) yes
checking for unistd.h... (cached) yes
checking for alarm... yes
checking for working mktime... no
checking for getloadavg... no
checking for pstat_getdynamic... no
checking for kstat_open in -lkstat... no
checking for elf_begin in -lelf... no
checking for kvm_open in -lkvm... no
checking for getloadavg in -lutil... no
checking for getloadavg in -lgetloadavg... no
checking for getloadavg... no
checking sys/dg_sys_info.h usability... no
checking sys/dg_sys_info.h presence... no
checking for sys/dg_sys_info.h... no
checking for locale.h... (cached) yes
checking for setlocale... (cached) yes
checking inq_stats/cpustats.h usability... no
checking inq_stats/cpustats.h presence... no
checking for inq_stats/cpustats.h... no
checking sys/cpustats.h usability... no
checking sys/cpustats.h presence... no
checking for sys/cpustats.h... no
checking mach/mach.h usability... no
checking mach/mach.h presence... no
checking for mach/mach.h... no
checking nlist.h usability... no
checking nlist.h presence... no
checking for nlist.h... no
checking whether getloadavg requires setgid... no
checking for _LARGEFILE_SOURCE value needed for large files... no
checking getopt.h usability... yes
checking getopt.h presence... yes
checking for getopt.h... yes
checking for getopt_long_only... yes
checking whether optreset is declared... yes
checking whether getpgrp requires zero arguments... yes
checking for strftime... yes
checking for grantpt... yes
checking for getpt... no
checking for tparm in -lncurses... yes
checking for dgettext in -lintl... yes
checking whether localtime caches TZ... no
checking for gettimeofday... yes
checking whether gettimeofday can accept two arguments... yes
checking for socket... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking sys/ioctl.h usability... yes
checking sys/ioctl.h presence... yes
checking for sys/ioctl.h... yes
checking whether system supports dynamic ptys... no
checking for pid_t... yes
checking vfork.h usability... no
checking vfork.h presence... no
checking for vfork.h... no
checking for fork... yes
checking for vfork... yes
checking for working fork... yes
checking for working vfork... (cached) yes
checking for nl_langinfo and CODESET... yes
checking for size_t... yes
checking for mbstate_t... yes
checking for C restrict keyword... __restrict
checking for C restricted array declarations... yes

Configured for `i686-pc-cygwin'.

  Where should the build process find the source code?
/tmp/emacs-23.0.50
  What operating system and machine description files should Emacs use?
        `s/cygwin.h' and `m/intel386.h'
  What compiler should emacs be built with?               gcc -g -O2
-Wno-pointer-sign
  Should Emacs use the GNU version of malloc?             yes
  Should Emacs use a relocating allocator for buffers?    yes
  Should Emacs use mmap(2) for buffer allocation?         no
  What window system should Emacs use?                    x11
  What toolkit should Emacs use?                          LUCID
  Where do we find X Windows header files?
/usr/X11R6/include
  Where do we find X Windows libraries?                   /usr/X11R6/lib
  Does Emacs use -lXaw3d?                                 yes
  Does Emacs use -lXpm?                                   yes
  Does Emacs use -ljpeg?                                  yes
  Does Emacs use -ltiff?                                  yes
  Does Emacs use a gif library?                           yes -lungif
  Does Emacs use -lpng?                                   yes
  Does Emacs use -lrsvg-2?                                no
  Does Emacs use -lgpm?                                   no
  Does Emacs use X toolkit scroll bars?                   yes

configure: creating ./config.status
config.status: creating Makefile
config.status: creating lib-src/Makefile.c
config.status: creating oldXMenu/Makefile
config.status: creating man/Makefile
config.status: creating lwlib/Makefile
config.status: creating src/Makefile.c
config.status: creating lisp/Makefile
config.status: creating lispref/Makefile
config.status: creating lispintro/Makefile
config.status: creating leim/Makefile
config.status: creating src/config.h
config.status: executing default commands
creating src/epaths.h
creating lib-src/Makefile
creating src/Makefile
creating src/.gdbinit

cd lib-src; make all  \
	  CC='gcc' CFLAGS='-g -O2 -Wno-pointer-sign ' CPPFLAGS='' \
	  LDFLAGS='-Wl,--enable-auto-import -Wl,--enable-auto-image-base
-L/usr/X11R6/lib' MAKE='make'
make[1]: Entering directory `/tmp/emacs-23.0.50/build/lib-src'
gcc -DHAVE_CONFIG_H -I. -I../src -I/tmp/emacs-23.0.50/lib-src
-I/tmp/emacs-23.0.50/lib-src/../src -Wl,--enable-auto-import
-Wl,--enable-auto-image-base -L/usr/X11R6/lib  -g -O2 -Wno-pointer-sign
-o test-distrib /tmp/emacs-23.0.50/lib-src/test-distrib.c

 ...

gcc -c -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/widget.c
gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/mktime.c
gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign
/tmp/emacs/src/getloadavg.c
gcc -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  -Wl,--enable-auto-import
-Wl,--enable-auto-image-base -L/usr/X11R6/lib /tmp/emacs/src/prefix-args.c
-o prefix-args
echo "dispnew.o frame.o scroll.o xdisp.o xmenu.o window.o charset.o
coding.o category.o ccl.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o
xselect.o xrdb.o fontset.o xsmfns.o fringe.o image.o  emacs.o keyboard.o
macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o
fileio.o dired.o filemode.o cmds.o casetab.o casefiddle.o indent.o
search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o
floatfns.o fns.o print.o lread.o abbrev.o syntax.o unexcw.o bytecode.o
process.o callproc.o region-cache.o sound.o atimer.o doprnt.o strftime.o
intervals.o textprop.o composite.o md5.o   sheap.o terminfo.o gmalloc.o
ralloc.o lastfile.o vm-limit.o  widget.o mktime.o getloadavg.o " >
buildobj.lst
gcc   -Wl,--enable-auto-import -Wl,--enable-auto-image-base
-L/usr/X11R6/lib -o temacs ecrt0.o dispnew.o frame.o scroll.o xdisp.o
xmenu.o window.o charset.o coding.o category.o ccl.o cm.o term.o
terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o
fringe.o image.o  emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o
filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o
casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o
doc.o editfns.o callint.o eval.o floatfns.o fns.o print.o lread.o abbrev.o
syntax.o unexcw.o bytecode.o process.o callproc.o region-cache.o sound.o
atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o
sheap.o terminfo.o gmalloc.o ralloc.o lastfile.o vm-limit.o  widget.o
mktime.o getloadavg.o   ../lwlib/liblw.a -L/usr/X11R6/lib -lXaw3d -lXmu
-lXt -lSM -lICE -lXext -ltiff -ljpeg -lpng -lz -lm -lungif -lXpm -lX11
-lcurses -lg  `gcc -print-libgcc-file-name` -lm -lc `gcc
-print-libgcc-file-name`
term.o: In function `dissociate_if_controlling_tty':
/tmp/emacs/src/term.c:3146: undefined reference to `_croak'
collect2: ld returned 1 exit status
make[2]: *** [temacs.exe] Error 1
make[2]: Leaving directory `/tmp/emacs/build/src'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/tmp/emacs/build'
make: *** [bootstrap] Error 2
---------------------------------------------------------------

(Note that term.c was one of the last update files before I checked out
CVS)


The same CVS bootstraps fine on GNU/Linux SLC4.


The CVS of 20070819 builds fine on both systems (linux and cygwin)



Cheers,

   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

Looks like a good find Angelo.  
I have just sent mail to the cygwin developers list to confirm, if this is
still the preferred method of if anything newer exists.

Regards,
  Darel Henman

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:
> 
> Searching Cygwin lists archives, I have found this 'laconic' suggestion,
> 
>    http://sourceware.org/ml/cygwin/2001-08/msg00753.html
> 
> 
> Could it help in solving our problem?
> 
> 
> Cheers,
> 
>    Angelo.
> 

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

What do you think about this patch ?

------------------------------------------------------------------------
--- term.c.orig	2007-08-29 23:46:50.000000000 +0200
+++ term.c	2007-09-03 00:38:43.538785600 +0200
@@ -3127,8 +3127,12 @@
   EMACS_GET_TTY_PGRP (fd, &pgid); /* If tcgetpgrp succeeds, fd is the
ctty. */
   if (pgid != -1)
     {
-#if defined (USG) && !defined (BSD_PGRPS)
+#if (defined (USG) && !defined (BSD_PGRPS)) || (defined (CYGWIN))
+#ifdef CYGWIN
+      setsid ();
+#else
       setpgrp ();
+#endif  /* ! CYGWIN */
       no_controlling_tty = 1;
 #else
 #ifdef TIOCNOTTY                /* Try BSD ioctls. */
------------------------------------------------------------------------

With it I have build Emacs and it seems to work (usually I use it from X
shell). But, perhaps, you can suggest some more specific test.


Cheers,

  Angelo.


On Mon, 3 Sep 2007, d.henman wrote:

>
> Looks like a good find Angelo.
> I have just sent mail to the cygwin developers list to confirm, if this is
> still the preferred method of if anything newer exists.
>
> Regards,
>   Darel Henman
>
> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:
> >
> > Searching Cygwin lists archives, I have found this 'laconic' suggestion,
> >
> >    http://sourceware.org/ml/cygwin/2001-08/msg00753.html
> >
> >
> > Could it help in solving our problem?
> >
> >
> > Cheers,
> >
> >    Angelo.
> >
>
>

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

Angelo,

content wise it looks good to me, but I think that changing it to the following 
format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.

Also I would like to wait and get a response from the cygwin developers, before any commit is made.

Regards,
  Darel Henman

----------------------------------------------------------------
--- term.c	2007-08-30 06:46:50.000000000 +0900
+++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
@@ -3131,6 +3131,10 @@
       setpgrp ();
       no_controlling_tty = 1;
 #else
+#ifdef CYGWIN
+      setsid ();
+      no_controlling_tty = 1;
+#else
 #ifdef TIOCNOTTY                /* Try BSD ioctls. */
       sigblock (sigmask (SIGTTOU));
       fd = emacs_open ("/dev/tty", O_RDWR, 0);
@@ -3145,6 +3149,7 @@
       /* Unknown system. */
       croak ();
 #endif  /* ! TIOCNOTTY */
+#endif  /* ! CYGWIN */
 #endif  /* ! USG */
     }
 #endif
----------------------------------------------------------------

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

"d.henman" <dhenman@gmail.com> writes:

  > Angelo,
  > 
  > content wise it looks good to me, but I think that changing it to the following 
  > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.
  > 
  > Also I would like to wait and get a response from the cygwin developers, before any commit is made.
  > 
  > Regards,
  >   Darel Henman
  > 
  > ----------------------------------------------------------------
  > --- term.c	2007-08-30 06:46:50.000000000 +0900
  > +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
  > @@ -3131,6 +3131,10 @@
  >        setpgrp ();
  >        no_controlling_tty = 1;
  >  #else
  > +#ifdef CYGWIN
  > +      setsid ();
  > +      no_controlling_tty = 1;
  > +#else
  >  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
  >        sigblock (sigmask (SIGTTOU));
  >        fd = emacs_open ("/dev/tty", O_RDWR, 0);
  > @@ -3145,6 +3149,7 @@
  >        /* Unknown system. */
  >        croak ();
  >  #endif  /* ! TIOCNOTTY */
  > +#endif  /* ! CYGWIN */
  >  #endif  /* ! USG */
  >      }
  >  #endif


Just my curiosity, does this patch make emacs work on cygwin?
If it doesn't, is this function called before things go bad?

If you configure with X11 support, does the X11 version work?
Theoretically it should work by default, but if it does not, fixing it
might help find things that would help the -nw case...

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

I have build emacs-cvs with my patch and with the nicer Darel's patch and
both builds work fine. Note that I use Emacs only under X11...


Cheers,

   Angelo.



On Tue, 4 Sep 2007, Dan Nicolaescu wrote:

> "d.henman" <dhenman@gmail.com> writes:
>
>   > Angelo,
>   >
>   > content wise it looks good to me, but I think that changing it to the following
>   > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.
>   >
>   > Also I would like to wait and get a response from the cygwin developers, before any commit is made.
>   >
>   > Regards,
>   >   Darel Henman
>   >
>   > ----------------------------------------------------------------
>   > --- term.c	2007-08-30 06:46:50.000000000 +0900
>   > +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
>   > @@ -3131,6 +3131,10 @@
>   >        setpgrp ();
>   >        no_controlling_tty = 1;
>   >  #else
>   > +#ifdef CYGWIN
>   > +      setsid ();
>   > +      no_controlling_tty = 1;
>   > +#else
>   >  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
>   >        sigblock (sigmask (SIGTTOU));
>   >        fd = emacs_open ("/dev/tty", O_RDWR, 0);
>   > @@ -3145,6 +3149,7 @@
>   >        /* Unknown system. */
>   >        croak ();
>   >  #endif  /* ! TIOCNOTTY */
>   > +#endif  /* ! CYGWIN */
>   >  #endif  /* ! USG */
>   >      }
>   >  #endif
>
>
> Just my curiosity, does this patch make emacs work on cygwin?
> If it doesn't, is this function called before things go bad?
>
> If you configure with X11 support, does the X11 version work?
> Theoretically it should work by default, but if it does not, fixing it
> might help find things that would help the -nw case...
>
>

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

On Tue, 4 Sep 2007, Dan Nicolaescu wrote:

> "d.henman" <dhenman@gmail.com> writes:
>
>   > Angelo,
>   >
>   > content wise it looks good to me, but I think that changing it to the following
>   > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.
>   >
>   > Also I would like to wait and get a response from the cygwin developers, before any commit is made.
>   >
>   > Regards,
>   >   Darel Henman
>   >
>   > ----------------------------------------------------------------
>   > --- term.c	2007-08-30 06:46:50.000000000 +0900
>   > +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
>   > @@ -3131,6 +3131,10 @@
>   >        setpgrp ();
>   >        no_controlling_tty = 1;
>   >  #else
>   > +#ifdef CYGWIN
>   > +      setsid ();
>   > +      no_controlling_tty = 1;
>   > +#else
>   >  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
>   >        sigblock (sigmask (SIGTTOU));
>   >        fd = emacs_open ("/dev/tty", O_RDWR, 0);
>   > @@ -3145,6 +3149,7 @@
>   >        /* Unknown system. */
>   >        croak ();
>   >  #endif  /* ! TIOCNOTTY */
>   > +#endif  /* ! CYGWIN */
>   >  #endif  /* ! USG */
>   >      }
>   >  #endif
>
>
> Just my curiosity, does this patch make emacs work on cygwin?
> If it doesn't, is this function called before things go bad?


IF 'setpgrp' is similar to 'setsid'
(http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND
IF Cygwin list suggests to use 'setsid' to dissociate TTY
(http://cygwin.com/ml/cygwin/2007-09/msg00026.html) THEN

the above patch is quite natural... OR NOT?


   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > On Tue, 4 Sep 2007, Dan Nicolaescu wrote:
  > 
  > > "d.henman" <dhenman@gmail.com> writes:
  > >
  > >   > Angelo,
  > >   >
  > >   > content wise it looks good to me, but I think that changing it to the following
  > >   > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.
  > >   >
  > >   > Also I would like to wait and get a response from the cygwin developers, before any commit is made.
  > >   >
  > >   > Regards,
  > >   >   Darel Henman
  > >   >
  > >   > ----------------------------------------------------------------
  > >   > --- term.c	2007-08-30 06:46:50.000000000 +0900
  > >   > +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
  > >   > @@ -3131,6 +3131,10 @@
  > >   >        setpgrp ();
  > >   >        no_controlling_tty = 1;
  > >   >  #else
  > >   > +#ifdef CYGWIN
  > >   > +      setsid ();
  > >   > +      no_controlling_tty = 1;
  > >   > +#else
  > >   >  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
  > >   >        sigblock (sigmask (SIGTTOU));
  > >   >        fd = emacs_open ("/dev/tty", O_RDWR, 0);
  > >   > @@ -3145,6 +3149,7 @@
  > >   >        /* Unknown system. */
  > >   >        croak ();
  > >   >  #endif  /* ! TIOCNOTTY */
  > >   > +#endif  /* ! CYGWIN */
  > >   >  #endif  /* ! USG */
  > >   >      }
  > >   >  #endif
  > >
  > >
  > > Just my curiosity, does this patch make emacs work on cygwin?
  > > If it doesn't, is this function called before things go bad?
  > 
  > 
  > IF 'setpgrp' is similar to 'setsid'
  > (http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND
  > IF Cygwin list suggests to use 'setsid' to dissociate TTY
  > (http://cygwin.com/ml/cygwin/2007-09/msg00026.html) THEN
  > 
  > the above patch is quite natural... OR NOT?

You have not answered the fundamental question: does the patch work? 
I don't think this code path is exercised if you run in a window
system, it will probably only be used if you use "emacsclient -t" or
"emacs -nw".

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

On Tue, 4 Sep 2007, Dan Nicolaescu wrote:

>
> You have not answered the fundamental question: does the patch work?
> I don't think this code path is exercised if you run in a window
> system, it will probably only be used if you use "emacsclient -t" or
> "emacs -nw".

Running 'emacs -nw' from an X-shell (rxvt-unicode, xterm), seems to work :
it does not have a graphical interface (which I preferer because it is
simpler for me to use), in any case, I can visit a file, compile it with
M-x compile... etc.


Cheers,

   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > On Tue, 4 Sep 2007, Dan Nicolaescu wrote:
  > 
  > >
  > > You have not answered the fundamental question: does the patch work?
  > > I don't think this code path is exercised if you run in a window
  > > system, it will probably only be used if you use "emacsclient -t" or
  > > "emacs -nw".
  > 
  > Running 'emacs -nw' from an X-shell (rxvt-unicode, xterm), seems to work :
  > it does not have a graphical interface (which I preferer because it is
  > simpler for me to use), in any case, I can visit a file, compile it with
  > M-x compile... etc.

Can you suspend/resume emacs when using emacs -nw? 
Can you use emacsclient -t? Can you suspend/resume an "emacsclient -t" frame?

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

On Wed, 5 Sep 2007, Dan Nicolaescu wrote:

>
> Can you suspend/resume emacs when using emacs -nw?
> Can you use emacsclient -t? Can you suspend/resume an "emacsclient -t" frame?

Sorry for my ignorance, but I have not understood!

How 'suspend/resume' ?

May you describe the steps ?



   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
  > 
  > >
  > > Can you suspend/resume emacs when using emacs -nw?
  > > Can you use emacsclient -t? Can you suspend/resume an "emacsclient -t" frame?
  > 
  > Sorry for my ignorance, but I have not understood!
  > 
  > How 'suspend/resume' ?
  > 
  > May you describe the steps ?

Sure. Run in a terminal: 
emacs -nw 
Press C-z, this should bring back the shell prompt. Type:
fg
This should display emacs again in the terminal. Make sure that you
can still type in it.

Another test, run:
emacs
M-x server-start RET

the go to a terminal window and run
emacsclient -t
This should display an emacs frame in that terminal. 
Press C-z, this should bring back the shell prompt. Type:
fg
This should display the emacs frame again in the terminal. Make sure
that you can still type in it.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

As I said in the last replay, I can suspend/resume both (emacs,
emacsclient).

After resume, I can continue to edit files typing in the terminal.

All these things with a build of Emacs checked out about 12 hours ago,
having applied the 'famous' patch...


   Angelo.



On Wed, 5 Sep 2007, Dan Nicolaescu wrote:

> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
>
>   > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
>   >
>   > >
>   > > Can you suspend/resume emacs when using emacs -nw?
>   > > Can you use emacsclient -t? Can you suspend/resume an "emacsclient -t" frame?
>   >
>   > Sorry for my ignorance, but I have not understood!
>   >
>   > How 'suspend/resume' ?
>   >
>   > May you describe the steps ?
>
> Sure. Run in a terminal:
> emacs -nw
> Press C-z, this should bring back the shell prompt. Type:
> fg
> This should display emacs again in the terminal. Make sure that you
> can still type in it.
>
> Another test, run:
> emacs
> M-x server-start RET
>
> the go to a terminal window and run
> emacsclient -t
> This should display an emacs frame in that terminal.
> Press C-z, this should bring back the shell prompt. Type:
> fg
> This should display the emacs frame again in the terminal. Make sure
> that you can still type in it.
>
>


---
Angelo Graziosi: http://www.webalice.it/angelo.graziosi


"...d'orgoglio spezzato inseguendo il desiderio del cuore"

                        Egdar Lee MASTERS, "Antologia di Spoon River"

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > As I said in the last replay, I can suspend/resume both (emacs,
  > emacsclient).
  > 
  > After resume, I can continue to edit files typing in the terminal.
  > 
  > All these things with a build of Emacs checked out about 12 hours ago,
  > having applied the 'famous' patch...

Thanks! Then, IMO, the patch should go in.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

On Wed, 5 Sep 2007, Dan Nicolaescu wrote:

> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
>
>   > As I said in the last replay, I can suspend/resume both (emacs,
>   > emacsclient).
>   >
>   > After resume, I can continue to edit files typing in the terminal.
>   >
>   > All these things with a build of Emacs checked out about 12 hours ago,
>   > having applied the 'famous' patch...
>
> Thanks! Then, IMO, the patch should go in.
>
>

Who should submit it ? If you can and if the patch is valid, may you ?



Thanks,

   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
  > 
  > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
  > >
  > >   > As I said in the last replay, I can suspend/resume both (emacs,
  > >   > emacsclient).
  > >   >
  > >   > After resume, I can continue to edit files typing in the terminal.
  > >   >
  > >   > All these things with a build of Emacs checked out about 12 hours ago,
  > >   > having applied the 'famous' patch...
  > >
  > > Thanks! Then, IMO, the patch should go in.
  > >
  > >
  > 
  > Who should submit it ? If you can and if the patch is valid, may you ?

I will do it later today in case nobody beat me to it.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]


Thanks from all of us unfortunate ones who have to use cygwin.

In case you can't find the patch I will inline it below.  My papers are in, so there is no legal problem.

Regards,
   Darel Henman

Dan Nicolaescu <dann@ics.uci.edu> wrote:

> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> 
>   > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
>   > 
>   > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
>   > >
>   > >   > As I said in the last replay, I can suspend/resume both (emacs,
>   > >   > emacsclient).
>   > >   >
>   > >   > After resume, I can continue to edit files typing in the terminal.
>   > >   >
>   > >   > All these things with a build of Emacs checked out about 12 hours ago,
>   > >   > having applied the 'famous' patch...
>   > >
>   > > Thanks! Then, IMO, the patch should go in.
>   > >
>   > >
>   > 
>   > Who should submit it ? If you can and if the patch is valid, may you ?
> 
> I will do it later today in case nobody beat me to it.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: term.c patch for CYGWIN --]
[-- Type: text/x-c, Size: 551 bytes --]

--- term.c	2007-08-30 06:46:50.000000000 +0900
+++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
@@ -3131,6 +3131,10 @@
       setpgrp ();
       no_controlling_tty = 1;
 #else
+#ifdef CYGWIN
+      setsid ();
+      no_controlling_tty = 1;
+#else
 #ifdef TIOCNOTTY                /* Try BSD ioctls. */
       sigblock (sigmask (SIGTTOU));
       fd = emacs_open ("/dev/tty", O_RDWR, 0);
@@ -3145,6 +3149,7 @@
       /* Unknown system. */
       croak ();
 #endif  /* ! TIOCNOTTY */
+#endif  /* ! CYGWIN */
 #endif  /* ! USG */
     }
 #endif

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Jashy]

I tried this patch plus workaround from
http://www.cygwin.com/ml/cygwin/2005-12/msg00036.html and It works.


d.henman wrote:
> 
> 
> Thanks from all of us unfortunate ones who have to use cygwin.
> 
> In case you can't find the patch I will inline it below.  My papers are
> in, so there is no legal problem.
> 
> 

-- 
View this message in context: http://www.nabble.com/Failure-in-building-Emacs-23.0.50-on-Cygwin-%28fwd%29-tf4369457.html#a12535614
Sent from the Emacs - Dev mailing list archive at Nabble.com.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

d.henman <dhenman@gmail.com> wrote:
> 
> Thanks from all of us unfortunate ones who have to use cygwin.
> 
> In case you can't find the patch I will inline it below.  My papers are in, so there is no legal problem.
> 
> Regards,
>    Darel Henman
> 
> Dan Nicolaescu <dann@ics.uci.edu> wrote:
> 
> > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> > 
> >   > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
> >   > 
> >   > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> >   > >
> >   > >   > As I said in the last replay, I can suspend/resume both (emacs,
> >   > >   > emacsclient).
> >   > >   >
> >   > >   > After resume, I can continue to edit files typing in the terminal.
> >   > >   >
> >   > >   > All these things with a build of Emacs checked out about 12 hours ago,
> >   > >   > having applied the 'famous' patch...
> >   > >
> >   > > Thanks! Then, IMO, the patch should go in.
> >   > >
> >   > >
> >   > 
> >   > Who should submit it ? If you can and if the patch is valid, may you ?
> > 
> > I will do it later today in case nobody beat me to it.
> --- term.c	2007-08-30 06:46:50.000000000 +0900
> +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
> @@ -3131,6 +3131,10 @@
>        setpgrp ();
>        no_controlling_tty = 1;
>  #else
> +#ifdef CYGWIN
> +      setsid ();
> +      no_controlling_tty = 1;
> +#else
>  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
>        sigblock (sigmask (SIGTTOU));
>        fd = emacs_open ("/dev/tty", O_RDWR, 0);
> @@ -3145,6 +3149,7 @@
>        /* Unknown system. */
>        croak ();
>  #endif  /* ! TIOCNOTTY */
> +#endif  /* ! CYGWIN */
>  #endif  /* ! USG */
>      }
>  #endif

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[David Kastrup]

Richard Stallman <rms@gnu.org> writes:

>     Thanks from all of us unfortunate ones who have to use cygwin.
>
> You don't have to use Cygwin; you can replace Losedows with GNU/Linux
> or BSD.  Defenestrate your computer!

I object against defenestration of my computer: I find windows very
handy as long as they are not capitalized.

Anyway, from what one hears, Cygwin is a great missionary for free
operating systems: it gets people hooked on free software running at a
quarter of the speed (when we are talking about heavily I/O bound
applications like version control systems).  And it teaches people to
hate CRLF line endings, too.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Richard Stallman]

    > You don't have to use Cygwin; you can replace Losedows with GNU/Linux
    > or BSD.  Defenestrate your computer!

    I object against defenestration of my computer: I find windows very
    handy as long as they are not capitalized.

There are two ways to defenestrate your computer:
throw it out the window, or throw windows out of the computer.

    Anyway, from what one hears, Cygwin is a great missionary for free
    operating systems: it gets people hooked on free software running at a
    quarter of the speed 

I believe you, but the point is, he doesn't have to _keep_ using
Cygwin.  He can move to GNU/Linux.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Angelo Graziosi]

On Sun, 9 Sep 2007, Richard Stallman wrote:

>
> I believe you, but the point is, he doesn't have to _keep_ using
> Cygwin.  He can move to GNU/Linux.
>
>

I use also GNU/Linux (Kubuntu Dapper 6.06 on which I build Emacs-CVS
too!).

If I use Cygwin is because I think interesting to port linux software
to Windows world and Cygwin is one way.


Cheers,

   Angelo.



---
Angelo Graziosi: http://www.webalice.it/angelo.graziosi

"...d'orgoglio spezzato inseguendo il desiderio del cuore"

                        Egdar Lee MASTERS, "Antologia di Spoon River"

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Richard Stallman]

    If I use Cygwin is because I think interesting to port linux software
    to Windows world and Cygwin is one way.

That's a useful thing (though I would rather erase Windows if it were
me).  But GNU Emacs is not Linux software.  It is not part of Linux, I
did not write it for Linux.  It has nothing particularly to do with
Linux.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

That's an option for personally owned computers, but, I don't have that option with customer's or employers' computers.  I can and do suggest they change systems, but I can't make them do it. 

And its good to have emacs, other applications, and  *nix tools, than not on these systems.  Cygwin also helps those learn about what's going on before taking to them what seems a big step to os changing.

Richard Stallman <rms@gnu.org> wrote:
>     Thanks from all of us unfortunate ones who have to use cygwin.
> 
> You don't have to use Cygwin; you can replace Losedows with GNU/Linux
> or BSD.  Defenestrate your computer!
> 

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Richard Stallman]

    That's an option for personally owned computers, but, I don't have
    that option with customer's or employers' computers.  I can and do
    suggest they change systems, but I can't make them do it.

You have the option of not working for them.  Out of conscience,
you should refuse those jobs.

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

Having said that, the original supplied patch was more symmetrical, in the context it was given and easier to maintain and provided for a closure reference. 

So now we have #elif mixed with #else #ifdefs with #endif for the legacy items....

You might has well have made the whole code segment modern using #elifs...

Are there any conventions regarding this?

Regards,
  darel henman

d.henman <dhenman@gmail.com> wrote:

> 
> Thanks from all of us unfortunate ones who have to use cygwin.
> 
> In case you can't find the patch I will inline it below.  My papers are in, so there is no legal problem.
> 
> Regards,
>    Darel Henman
> 
> Dan Nicolaescu <dann@ics.uci.edu> wrote:
> 
> > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> > 
> >   > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
> >   > 
> >   > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> >   > >
> >   > >   > As I said in the last replay, I can suspend/resume both (emacs,
> >   > >   > emacsclient).
> >   > >   >
> >   > >   > After resume, I can continue to edit files typing in the terminal.
> >   > >   >
> >   > >   > All these things with a build of Emacs checked out about 12 hours ago,
> >   > >   > having applied the 'famous' patch...
> >   > >
> >   > > Thanks! Then, IMO, the patch should go in.
> >   > >
> >   > >
> >   > 
> >   > Who should submit it ? If you can and if the patch is valid, may you ?
> > 
> > I will do it later today in case nobody beat me to it.
> --- term.c	2007-08-30 06:46:50.000000000 +0900
> +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
> @@ -3131,6 +3131,10 @@
>        setpgrp ();
>        no_controlling_tty = 1;
>  #else
> +#ifdef CYGWIN
> +      setsid ();
> +      no_controlling_tty = 1;
> +#else
>  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
>        sigblock (sigmask (SIGTTOU));
>        fd = emacs_open ("/dev/tty", O_RDWR, 0);
> @@ -3145,6 +3149,7 @@
>        /* Unknown system. */
>        croak ();
>  #endif  /* ! TIOCNOTTY */
> +#endif  /* ! CYGWIN */
>  #endif  /* ! USG */
>      }
>  #endif

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
  > 
  > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
  > >
  > >   > As I said in the last replay, I can suspend/resume both (emacs,
  > >   > emacsclient).
  > >   >
  > >   > After resume, I can continue to edit files typing in the terminal.
  > >   >
  > >   > All these things with a build of Emacs checked out about 12 hours ago,
  > >   > having applied the 'famous' patch...
  > >
  > > Thanks! Then, IMO, the patch should go in.
  > >
  > >
  > 
  > Who should submit it ? If you can and if the patch is valid, may you ?

I committed a slightly tweaked version of your patch.

NEW failure in building Emacs 23.0.50 on Cygwin

[Angelo Graziosi]

It looks that this change:

------------------------------------------------------------------
2007-09-07  Stefan Monnier  <monnier@iro.umontreal.ca>

	* window.c (Vsplit_window_preferred_function): New var.
	(Fdisplay_buffer): Use it.
	(syms_of_window): Export, and initialize it.

------------------------------------------------------------------


breaks the bootstrap of Emacs-CVS on Cygwin (at least):
------------------------------------------------------------------
...
gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/window.c
/tmp/emacs/src/window.c: In function 'Fdisplay_buffer':
/tmp/emacs/src/window.c:3731: error: address of register variable 'buffer'
requested
make[2]: *** [window.o] Error 1
make[2]: Leaving directory `/tmp/emacs/build/src'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/tmp/emacs/build'
make: *** [bootstrap] Error 2
------------------------------------------------------------------


The last check-out I did less than 24 hours ago (with the 'famous' patch
applied to term.c) build fine.



Cheers,

   Angelo.

Re: NEW failure in building Emacs 23.0.50 on Cygwin

[Stefan Monnier]

> It looks that this change:

> ------------------------------------------------------------------
> 2007-09-07  Stefan Monnier  <monnier@iro.umontreal.ca>

> 	* window.c (Vsplit_window_preferred_function): New var.
> 	(Fdisplay_buffer): Use it.
> 	(syms_of_window): Export, and initialize it.

> ------------------------------------------------------------------


> breaks the bootstrap of Emacs-CVS on Cygwin (at least):
> ------------------------------------------------------------------
> ...
> gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
> -I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/window.c
> /tmp/emacs/src/window.c: In function 'Fdisplay_buffer':
> /tmp/emacs/src/window.c:3731: error: address of register variable 'buffer'
> requested
> make[2]: *** [window.o] Error 1
> make[2]: Leaving directory `/tmp/emacs/build/src'
> make[1]: *** [bootstrap-build] Error 2
> make[1]: Leaving directory `/tmp/emacs/build'
> make: *** [bootstrap] Error 2
> ------------------------------------------------------------------

I've just installed a (presumed) fix for it.

BTW, following the above bugreport, I've enabled conservative stack marking
in s/cygwin.h.


        Stefan

Re: NEW failure in building Emacs 23.0.50 on Cygwin

[Angelo Graziosi]

On Fri, 7 Sep 2007, Stefan Monnier wrote:

>
> I've just installed a (presumed) fix for it.


Now Emacs-CVS builds and works fine!


Many thanks,

  Angelo.


>
> BTW, following the above bugreport, I've enabled conservative stack marking
> in s/cygwin.h.
>
>
>         Stefan
>
>

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[Andreas Schwab]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

> IF 'setpgrp' is similar to 'setsid'
> (http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND

There are two flavors of setpgrp.  The BSD flavor is now known as
setpgid in POSIX.  The SYSV flavor is identical to setsid.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

[d.henman]

I appreciate Andreaa, explanation about the distinctions between the systems and calls.

Since, cygwin is POSIX complaint (or aims for it) then setsid should be 
good enough for dissociating a tty as Angelo mentioned.

I still can't get past my net/tramp build problem yet, to confirm operation 
in my cygwin environment, but am working on it.

Regards,
  darel henman

----

Andreas Schwab <schwab@suse.de> wrote:

> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> > IF 'setpgrp' is similar to 'setsid'
> > (http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND
> 
> There are two flavors of setpgrp.  The BSD flavor is now known as
> setpgid in POSIX.  The SYSV flavor is identical to setsid.
> 
> Andreas.
> 
> -- 
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."