From: "Håkon Flatval" <hkon20@hotmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: Sv: Sv: Sv: Support for background transparency
Date: Sun, 23 Jan 2022 14:48:57 +0100 [thread overview]
Message-ID: <PRAP251MB0688CFF613D54BFF376436DCCF5D9@PRAP251MB0688.EURP251.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <874k5x29be.fsf@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
> This coding style is not what we use in Emacs.
Seems like I was in a bit of a rush with the formatting. It should be
in order now.
> You could just check dpyinfo->n_planes,
I was not aware of that one - simplifies things a bit. I have removed my
custom depth querying function and opted for that one instead.
> Which preprocessor statements are you referring to?
Sorry for not being specific - I was talking about the section with
>> #if defined (USE_GTK) && defined (USE_CAIRO)
that you mentioned in your previous mail. Its purpose is just to avoid
using 32-bit visuals in build configurations I have not considered, as I
know that at least some of those configurations display artifacts when
they are run with 32-bit visuals.
> Would you mind if I implemented that support instead?
I would be grateful if you would do that, as I doubt I will be able to
work on this consistently going forward.
Again, thanks for the feedback.
- Håkon
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gdk-cairo-background-transparency-006.patch --]
[-- Type: text/x-patch, Size: 10694 bytes --]
diff --git a/src/frame.c b/src/frame.c
index 8aaff949ba..c331cff32b 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -3907,6 +3907,7 @@ DEFUN ("frame-scale-factor", Fframe_scale_factor, Sframe_scale_factor,
{"z-group", SYMBOL_INDEX (Qz_group)},
{"override-redirect", SYMBOL_INDEX (Qoverride_redirect)},
{"no-special-glyphs", SYMBOL_INDEX (Qno_special_glyphs)},
+ {"alpha-background", SYMBOL_INDEX (Qalpha_background)},
#ifdef NS_IMPL_COCOA
{"ns-appearance", SYMBOL_INDEX (Qns_appearance)},
{"ns-transparent-titlebar", SYMBOL_INDEX (Qns_transparent_titlebar)},
@@ -5024,6 +5025,33 @@ gui_set_alpha (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
}
}
+void
+gui_set_alpha_background (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
+{
+ double alpha = 1.0;
+
+ if (NILP (arg))
+ alpha = 1.0;
+ else if (FLOATP (arg))
+ {
+ alpha = XFLOAT_DATA (arg);
+ if (! (0 <= alpha && alpha <= 1.0))
+ args_out_of_range (make_float (0.0), make_float (1.0));
+ }
+ else if (FIXNUMP (arg))
+ {
+ EMACS_INT ialpha = XFIXNUM (arg);
+ if (! (0 <= ialpha && ialpha <= 100))
+ args_out_of_range (make_fixnum (0), make_fixnum (100));
+ alpha = ialpha / 100.0;
+ }
+ else
+ wrong_type_argument (Qnumberp, arg);
+
+ f->alpha_background = alpha;
+
+ SET_FRAME_GARBAGED (f);
+}
/**
* gui_set_no_special_glyphs:
@@ -6100,6 +6128,7 @@ syms_of_frame (void)
#endif
DEFSYM (Qalpha, "alpha");
+ DEFSYM (Qalpha_background, "alpha-background");
DEFSYM (Qauto_lower, "auto-lower");
DEFSYM (Qauto_raise, "auto-raise");
DEFSYM (Qborder_color, "border-color");
diff --git a/src/frame.h b/src/frame.h
index cb2f58e261..5d5f2122fb 100644
--- a/src/frame.h
+++ b/src/frame.h
@@ -637,6 +637,9 @@ #define EMACS_FRAME_H
Negative values mean not to change alpha. */
double alpha[2];
+ /* Background opacity */
+ double alpha_background;
+
/* Exponent for gamma correction of colors. 1/(VIEWING_GAMMA *
SCREEN_GAMMA) where viewing_gamma is 0.4545 and SCREEN_GAMMA is a
frame parameter. 0 means don't do gamma correction. */
@@ -1669,6 +1672,7 @@ #define EMACS_CLASS "Emacs"
extern long gui_figure_window_size (struct frame *, Lisp_Object, bool, bool);
extern void gui_set_alpha (struct frame *, Lisp_Object, Lisp_Object);
+extern void gui_set_alpha_background (struct frame *, Lisp_Object, Lisp_Object);
extern void gui_set_no_special_glyphs (struct frame *, Lisp_Object, Lisp_Object);
extern void validate_x_resource_name (void);
diff --git a/src/gtkutil.c b/src/gtkutil.c
index eb14856062..19dd04523e 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -1467,6 +1467,10 @@ xg_create_frame_widgets (struct frame *f)
}
wtop = gtk_window_new (type);
gtk_widget_add_events (wtop, GDK_ALL_EVENTS_MASK);
+
+ /* This prevents GTK from painting the window's background, which
+ would interfere with transparent background in some environments */
+ gtk_widget_set_app_paintable (wtop, TRUE);
#endif
/* gtk_window_set_has_resize_grip is a Gtk+ 3.0 function but Ubuntu
@@ -1587,6 +1591,15 @@ xg_create_frame_widgets (struct frame *f)
#endif
| GDK_VISIBILITY_NOTIFY_MASK);
+ GdkScreen *screen = gtk_widget_get_screen (wtop);
+
+ if (FRAME_DISPLAY_INFO (f)->n_planes == 32)
+ {
+ GdkVisual *visual = gdk_screen_get_rgba_visual (screen);
+ gtk_widget_set_visual (wtop, visual);
+ gtk_widget_set_visual (wfixed, visual);
+ }
+
#ifndef HAVE_PGTK
/* Must realize the windows so the X window gets created. It is used
by callers of this function. */
@@ -1651,7 +1664,6 @@ xg_create_frame_widgets (struct frame *f)
#endif
{
- GdkScreen *screen = gtk_widget_get_screen (wtop);
GtkSettings *gs = gtk_settings_get_for_screen (screen);
/* Only connect this signal once per screen. */
if (! g_signal_handler_find (G_OBJECT (gs),
diff --git a/src/haikufns.c b/src/haikufns.c
index 58a2e1d464..7117296a73 100644
--- a/src/haikufns.c
+++ b/src/haikufns.c
@@ -2609,7 +2609,8 @@ DEFUN ("haiku-frame-restack", Fhaiku_frame_restack, Shaiku_frame_restack, 2, 3,
haiku_set_no_accept_focus,
NULL, /* set z group */
haiku_set_override_redirect,
- gui_set_no_special_glyphs
+ gui_set_no_special_glyphs,
+ gui_set_alpha_background,
};
void
diff --git a/src/nsfns.m b/src/nsfns.m
index 11132a294a..a4f3f091fc 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -1004,6 +1004,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
ns_set_z_group,
0, /* x_set_override_redirect */
gui_set_no_special_glyphs,
+ gui_set_alpha_background,
#ifdef NS_IMPL_COCOA
ns_set_appearance,
ns_set_transparent_titlebar,
diff --git a/src/pgtkfns.c b/src/pgtkfns.c
index 9c37c04810..b46429379e 100644
--- a/src/pgtkfns.c
+++ b/src/pgtkfns.c
@@ -1043,6 +1043,7 @@ frames (each of which corresponds to one page). Each frame should be
x_set_z_group,
x_set_override_redirect,
gui_set_no_special_glyphs,
+ gui_set_alpha_background,
};
diff --git a/src/w32fns.c b/src/w32fns.c
index 37f9b813c6..a360faefa8 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10436,6 +10436,7 @@ w32_get_resource (const char *key, const char *name, LPDWORD lpdwtype)
w32_set_z_group,
0, /* x_set_override_redirect */
gui_set_no_special_glyphs,
+ gui_set_alpha_background,
};
void
diff --git a/src/xfns.c b/src/xfns.c
index 7123198724..a79462b125 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -4569,6 +4569,8 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_create_frame,
RES_TYPE_NUMBER);
gui_default_parameter (f, parms, Qalpha, Qnil,
"alpha", "Alpha", RES_TYPE_NUMBER);
+ gui_default_parameter (f, parms, Qalpha_background, Qnil,
+ "alpha_background", "AlphaBackground", RES_TYPE_NUMBER);
if (!NILP (parent_frame))
{
@@ -6342,10 +6344,29 @@ select_visual (struct x_display_info *dpyinfo)
int n_visuals;
XVisualInfo *vinfo, vinfo_template;
- dpyinfo->visual = DefaultVisualOfScreen (screen);
+ vinfo_template.screen = XScreenNumberOfScreen (screen);
+
+#if defined (USE_GTK) && defined (USE_CAIRO)
+ /* First attempt to use 32-bit visual if available */
+
+ vinfo_template.depth = 32;
+
+ vinfo = XGetVisualInfo (dpy, VisualScreenMask | VisualDepthMask,
+ &vinfo_template, &n_visuals);
+ if (n_visuals > 0)
+ {
+ dpyinfo->n_planes = vinfo->depth;
+ dpyinfo->visual = vinfo->visual;
+ XFree (vinfo);
+ return;
+ }
+
+#endif // defined (USE_GTK) && defined (USE_CAIRO)
+
+ /* 32-bit visual not available, fallback to default visual */
+ dpyinfo->visual = DefaultVisualOfScreen (screen);
vinfo_template.visualid = XVisualIDFromVisual (dpyinfo->visual);
- vinfo_template.screen = XScreenNumberOfScreen (screen);
vinfo = XGetVisualInfo (dpy, VisualIDMask | VisualScreenMask,
&vinfo_template, &n_visuals);
if (n_visuals <= 0)
@@ -7203,6 +7224,8 @@ x_create_tip_frame (struct x_display_info *dpyinfo, Lisp_Object parms)
"cursorType", "CursorType", RES_TYPE_SYMBOL);
gui_default_parameter (f, parms, Qalpha, Qnil,
"alpha", "Alpha", RES_TYPE_NUMBER);
+ gui_default_parameter (f, parms, Qalpha_background, Qnil,
+ "alpha_background", "AlphaBackground", RES_TYPE_NUMBER);
/* Add `tooltip' frame parameter's default value. */
if (NILP (Fframe_parameter (frame, Qtooltip)))
@@ -8531,6 +8554,7 @@ DEFUN ("x-gtk-debug", Fx_gtk_debug, Sx_gtk_debug, 1, 1, 0,
x_set_z_group,
x_set_override_redirect,
gui_set_no_special_glyphs,
+ gui_set_alpha_background,
};
void
diff --git a/src/xterm.c b/src/xterm.c
index 2a4ea883bc..08f6369ca7 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -840,12 +840,26 @@ x_set_cr_source_with_gc_background (struct frame *f, GC gc)
{
XGCValues xgcv;
XColor color;
+ unsigned int depth;
XGetGCValues (FRAME_X_DISPLAY (f), gc, GCBackground, &xgcv);
color.pixel = xgcv.background;
+
x_query_colors (f, &color, 1);
- cairo_set_source_rgb (FRAME_CR_CONTEXT (f), color.red / 65535.0,
- color.green / 65535.0, color.blue / 65535.0);
+
+ depth = FRAME_DISPLAY_INFO (f)->n_planes;
+
+ if (f->alpha_background < 1.0 && depth == 32)
+ {
+ cairo_set_source_rgba (FRAME_CR_CONTEXT (f), color.red / 65535.0,
+ color.green / 65535.0, color.blue / 65535.0, f->alpha_background);
+
+ cairo_set_operator (FRAME_CR_CONTEXT (f), CAIRO_OPERATOR_SOURCE);
+ }
+ else
+ cairo_set_source_rgb (FRAME_CR_CONTEXT (f), color.red / 65535.0,
+ color.green / 65535.0, color.blue / 65535.0);
+
}
static const cairo_user_data_key_t xlib_surface_key, saved_drawable_key;
@@ -1258,6 +1272,29 @@ x_fill_rectangle (struct frame *f, GC gc, int x, int y, int width, int height)
#endif
}
+
+static void
+x_clear_rectangle (struct frame *f, GC gc, int x, int y, int width, int height)
+{
+#ifdef USE_CAIRO
+ cairo_t *cr;
+
+ cr = x_begin_cr_clip (f, gc);
+ x_set_cr_source_with_gc_background (f, gc);
+ cairo_rectangle (cr, x, y, width, height);
+ cairo_fill (cr);
+ x_end_cr_clip (f);
+#else
+ XGCValues xgcv;
+ Display *dpy = FRAME_X_DISPLAY (f);
+ XGetGCValues (dpy, gc, GCBackground | GCForeground, &xgcv);
+ XSetForeground (dpy, gc, xgcv.background);
+ XFillRectangle (dpy, FRAME_X_DRAWABLE (f),
+ gc, x, y, width, height);
+ XSetForeground (dpy, gc, xgcv.foreground);
+#endif
+}
+
static void
x_draw_rectangle (struct frame *f, GC gc, int x, int y, int width, int height)
{
@@ -1838,9 +1875,9 @@ x_draw_fringe_bitmap (struct window *w, struct glyph_row *row, struct draw_fring
if (face->stipple)
XSetFillStyle (display, face->gc, FillOpaqueStippled);
else
- XSetForeground (display, face->gc, face->background);
+ XSetBackground (display, face->gc, face->background);
- x_fill_rectangle (f, face->gc, p->bx, p->by, p->nx, p->ny);
+ x_clear_rectangle (f, face->gc, p->bx, p->by, p->nx, p->ny);
if (!face->stipple)
XSetForeground (display, face->gc, face->foreground);
@@ -2141,12 +2178,7 @@ x_compute_glyph_string_overhangs (struct glyph_string *s)
static void
x_clear_glyph_string_rect (struct glyph_string *s, int x, int y, int w, int h)
{
- Display *display = FRAME_X_DISPLAY (s->f);
- XGCValues xgcv;
- XGetGCValues (display, s->gc, GCForeground | GCBackground, &xgcv);
- XSetForeground (display, s->gc, xgcv.background);
- x_fill_rectangle (s->f, s->gc, x, y, w, h);
- XSetForeground (display, s->gc, xgcv.foreground);
+ x_clear_rectangle (s->f, s->gc, x, y, w, h);
}
next prev parent reply other threads:[~2022-01-23 13:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 19:45 Support for background transparency Håkon Flatval
2021-11-04 20:06 ` Eli Zaretskii
2021-11-04 20:17 ` Lars Ingebrigtsen
2021-11-27 23:01 ` Håkon Flatval
2021-11-28 0:35 ` Sv: " arthur miller
2021-11-28 13:32 ` Lars Ingebrigtsen
2021-11-28 16:04 ` Arthur Miller
2021-11-28 20:33 ` Håkon Flatval
2021-11-29 2:56 ` Arthur Miller
2021-11-28 7:41 ` Eli Zaretskii
2021-11-28 7:47 ` Po Lu
2021-11-28 8:27 ` Eli Zaretskii
2021-12-01 18:54 ` Sv: " Håkon Flatval
2021-12-09 17:13 ` Håkon Flatval
2021-12-10 0:40 ` Lars Ingebrigtsen
2022-01-19 17:26 ` Sv: " Håkon Flatval
2022-01-20 0:52 ` Po Lu
2022-01-20 19:52 ` Sv: " Håkon Flatval
2022-01-21 0:59 ` Po Lu
2022-01-23 13:48 ` Håkon Flatval [this message]
2022-01-24 0:11 ` Po Lu
2022-01-25 17:53 ` Håkon Flatval
2022-01-26 1:00 ` Po Lu
2022-01-24 10:22 ` Po Lu
2022-01-25 19:47 ` Håkon Flatval
2022-01-25 19:37 ` Robert Pluim
2022-01-26 18:16 ` Håkon Flatval
2022-01-26 1:05 ` Po Lu
2022-01-26 11:11 ` Robert Pluim
2022-01-26 18:34 ` Håkon Flatval
2022-01-27 1:00 ` Po Lu
2022-01-29 0:01 ` Håkon Flatval
2022-01-29 1:08 ` Po Lu
2022-01-20 9:12 ` Robert Pluim
2022-01-23 21:43 ` Håkon Flatval
2022-01-24 9:14 ` Robert Pluim
2022-01-25 20:00 ` Håkon Flatval
2022-01-25 19:31 ` Robert Pluim
2022-01-29 10:26 ` Po Lu
2022-01-29 15:17 ` Håkon Flatval
2022-01-30 0:53 ` Po Lu
2021-11-28 13:41 ` Lars Ingebrigtsen
2021-11-28 15:05 ` Sv: " Håkon Flatval
2021-11-28 16:07 ` Gregor Zattler
2021-11-28 16:32 ` Lars Ingebrigtsen
2021-11-28 18:10 ` Jean Louis
2021-11-28 18:44 ` Sv: " Håkon Flatval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PRAP251MB0688CFF613D54BFF376436DCCF5D9@PRAP251MB0688.EURP251.PROD.OUTLOOK.COM \
--to=hkon20@hotmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).