> That's really cool. It seems to work fine here (Debian/bookworm), but > with these compilation warnings. Ah, I forgot about those - I'll take care of them. I haven't heard about the FSF Copyright Assignment Process before. I found some information about it online, but don't understand what purpose it serves in this context. Do I need to follow through with it to proceed with this contribution to Emacs? Best, Håkon ________________________________ Fra: Lars Ingebrigtsen Sendt: søndag 28. november 2021 14:41 Til: Håkon Flatval Kopi: emacs-devel@gnu.org Emne: Re: Support for background transparency Håkon Flatval writes: > I've attached a patch that implements basic support for background > transparency. I have only considered GDK+Cairo build configurations here, as a > start. That's really cool. It seems to work fine here (Debian/bookworm), but with these compilation warnings. xterm.c: In function 'x_clear_rectangle': xterm.c:1107:12: warning: unused variable 'dpy' [-Wunused-variable] 1107 | Display *dpy = FRAME_X_DISPLAY (f); | ^~~ xterm.c:1106:13: warning: unused variable 'xgcv' [-Wunused-variable] 1106 | XGCValues xgcv; | ^~~~ > Newbie question: I can't guarantee that this patch works perfectly > with all build variations using GDK+Cairo, nor in all (desktop) > environments where Emacs might be used. How, in general, is Emacs > tested before release to ensure (most) such edge cases are caught? We put the code into the development tree and wait for people to report problems. 😀 > I'm currently working on implementing this feature for other XLib-based build > configurations too, offline, planning to submit another patch for those in the > not-so-distant future. Great! Have you started the FSF copyright assignment process? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no