From: Kelly Dean <kelly@prtime.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bruce.connor.am@gmail.com, emacs-devel@gnu.org
Subject: Re: Short patch for review
Date: Thu, 19 Feb 2015 10:30:36 +0000 [thread overview]
Message-ID: <HZ1gPSC3JjNQSK1WHVd91j9Q2BpIZRHxTqwbqqGo8wA@local> (raw)
In-Reply-To: <83r3tm4fia.fsf@gnu.org>
Eli Zaretskii wrote:
> Do we have guidelines for which errors should be 'user-error'?
If the program is at fault, use error. If the user is at fault, use user-error.
If debug-on-error is t, and the program is at fault, then pop up the debugger in order to help find the problem in the program. If the user is at fault, then don't pop up the debugger, even if debug-on-error is t, because there's no problem in the program.
And those guidelines match, because Emacs pops up the debugger if debug-on-error is t and an error is signaled, but not if user-error is signaled.
In the case of this patch, the errors are clearly user errors, not program errors.
next prev parent reply other threads:[~2015-02-19 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 21:17 Short patch for review Artur Malabarba
2015-02-18 22:51 ` Stefan Monnier
2015-02-19 5:49 ` Eli Zaretskii
2015-02-19 10:30 ` Kelly Dean [this message]
2015-02-19 11:07 ` Artur Malabarba
2015-02-19 11:18 ` Eli Zaretskii
2015-02-19 13:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HZ1gPSC3JjNQSK1WHVd91j9Q2BpIZRHxTqwbqqGo8wA@local \
--to=kelly@prtime.org \
--cc=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).