unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kjartan Oli Agustsson <kjartanoli@outlook.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Daniel Nicolai <dalanicolai@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support
Date: Tue, 08 Mar 2022 23:06:12 +0000	[thread overview]
Message-ID: <GV1P193MB23102C8917795A95E5769CFBDF099@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87zgm1912e.fsf@gnus.org>


Lars Ingebrigtsen <larsi@gnus.org> writes:

> Kjartan Oli Agustsson <kjartanoli@outlook.com> writes:
>
>> This should take care of that.
>
> Thanks; applied to Emacs 29.
>
> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?

I have already started the process.  I'm just waiting for a response
from assign@gnu.org.

>> But now there's something else I'm wondering about.  If I'm
>> understanding `doc-view-custom-set-epub-font-size' correctly, it is
>> used as the setter for `doc-view-epub-font-size' to regenerate epub
>> documents when it is changed.  Am I understanding this correctly, and
>> if so would it make sense to do the same for the user stylesheet?
>
> When the contents of the user stylesheet changes?  I guess that would
> make sense, and you could use `file-has-changed-p' to implement that.

That would make sense to.  I was also thinking if the value of the
variable is changed to point to a different file.

-- 
Kjartan Óli Ágústsson




  reply	other threads:[~2022-03-08 23:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06 17:12 [PATCH] Add user stylesheet support for doc-view EPUB support Kjartan Oli Agustsson
2022-03-06 22:07 ` Lars Ingebrigtsen
2022-03-07  0:17   ` Kjartan Oli Agustsson
2022-03-07  0:50     ` Kjartan Oli Agustsson
2022-03-07 16:31       ` Lars Ingebrigtsen
2022-03-08 23:06         ` Kjartan Oli Agustsson [this message]
2022-03-09 13:59           ` Lars Ingebrigtsen
2022-03-09 22:34             ` Kjartan Oli Agustsson
2022-03-12 16:40               ` Lars Ingebrigtsen
2022-03-14 10:25                 ` Kjartan Oli Agustsson
2022-03-14 10:32                   ` Lars Ingebrigtsen
2022-03-14 11:17                     ` Kjartan Oli Agustsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P193MB23102C8917795A95E5769CFBDF099@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM \
    --to=kjartanoli@outlook.com \
    --cc=dalanicolai@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).