From: Eli Zaretskii <eliz@gnu.org>
To: "Paul W. Rankin" <pwr@bydasein.com>,
"Paul W. Rankin via Emacs development discussions."
<emacs-devel@gnu.org>, Karl Fogel <kfogel@red-bean.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Tue, 18 May 2021 11:45:10 +0300 [thread overview]
Message-ID: <FF6FA93E-A0F9-452C-A1EE-6CD67530A686@gnu.org> (raw)
In-Reply-To: <b99fbe4fdc81b72a6eb4176ecd310a5f@purelymail.com>
On May 18, 2021 11:17:04 AM GMT+03:00, "Paul W. Rankin via Emacs development discussions." <emacs-devel@gnu.org> wrote:
> On 2021-05-18 16:58, Karl Fogel wrote:
> > On 18 May 2021, Paul W. Rankin" via "Emacs development discussions.
> > wrote:
> >> Ugh. Not sure how this slipped into master but it is not a
> >> good/considerate idea to set default value of bookmark-fontify to
> t.
> >>
> >> If there are no reasonable objections I'll push this later today.
> >
> > I don't have a strong opinion either way, but if you're curious as
> to
> > where this came from, it was here:
> >
> > The discussion in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179
> > is quite long, so it might be worth reading before reverting.
>
> Hi Karl,
>
> The discussion there only seems to account for compatibility with
> package bm.el, not the more general "avoid pushing your idea onto
> everyone" idea. And given the overlay is temporary, it's quite opaque
> for the average person to inspect it to see what's actually happening.
>
> It's so ugly my first thought was that something had broken rather
> than
> this was actually an intentional feature.
>
> I'm going to commit this without further discussion -- which hopefully
>
> should remind others to take the more considerate route when
> introducing
> new features!
Please don't make this change until you hear from Lars, who examined the original patch and decided to install it. It doesn't get more "considerate" than that.
next prev parent reply other threads:[~2021-05-18 8:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18 6:58 ` Karl Fogel
2021-05-18 8:17 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 8:45 ` Eli Zaretskii [this message]
2021-05-18 10:06 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09 ` Eli Zaretskii
2021-05-18 12:04 ` Eli Zaretskii
2021-05-18 14:28 ` Lars Ingebrigtsen
2021-05-18 14:38 ` Eli Zaretskii
2021-05-18 14:40 ` Lars Ingebrigtsen
2021-05-19 11:59 ` Bastien
2021-05-19 13:55 ` Eli Zaretskii
2021-05-24 22:32 ` Lars Ingebrigtsen
2021-05-24 22:51 ` [External] : " Drew Adams
2021-05-18 14:43 ` Drew Adams
2021-05-18 15:07 ` Eli Zaretskii
2021-09-13 9:46 ` Stefan Kangas
2021-09-13 9:58 ` Manuel Uberti
2021-09-13 10:17 ` Stefan Kangas
2021-09-13 10:12 ` Colin Baxter
2021-09-13 15:29 ` [External] : " Drew Adams
2021-09-13 10:43 ` Adam Porter
2021-09-13 11:36 ` Lars Ingebrigtsen
2021-09-13 19:36 ` Matthias Meulien
2021-09-14 5:40 ` Colin Baxter
2021-09-14 11:15 ` Lars Ingebrigtsen
2021-09-14 11:46 ` Eli Zaretskii
2021-09-14 11:54 ` Lars Ingebrigtsen
2021-09-14 11:52 ` miha
2021-09-14 11:56 ` Lars Ingebrigtsen
2021-09-14 14:44 ` miha
2021-09-15 7:59 ` Lars Ingebrigtsen
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-18 11:08 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00 ` Bastien
2021-05-19 12:58 ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF6FA93E-A0F9-452C-A1EE-6CD67530A686@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=pwr@bydasein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).