From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Wed, 3 May 2017 07:35:18 +0900 Message-ID: References: <95dd877e-8c5d-533a-7680-8782dcdad88a@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1493764591 13275 195.159.176.226 (2 May 2017 22:36:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 May 2017 22:36:31 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 00:36:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5gPD-0003Np-NI for ged-emacs-devel@m.gmane.org; Wed, 03 May 2017 00:36:27 +0200 Original-Received: from localhost ([::1]:33962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5gPJ-0004iW-DS for ged-emacs-devel@m.gmane.org; Tue, 02 May 2017 18:36:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5gOE-0004hI-N8 for emacs-devel@gnu.org; Tue, 02 May 2017 18:35:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5gOB-0003kh-KR for emacs-devel@gnu.org; Tue, 02 May 2017 18:35:26 -0400 Original-Received: from mail-pg0-x229.google.com ([2607:f8b0:400e:c05::229]:33788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5gOB-0003kX-EM for emacs-devel@gnu.org; Tue, 02 May 2017 18:35:23 -0400 Original-Received: by mail-pg0-x229.google.com with SMTP id y4so62946467pge.0 for ; Tue, 02 May 2017 15:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=r+Xaz8Tzurlrpvmg3D5gU+jZ0wh+1WExU/S+n7C/ga8=; b=aa+EPNLWlMrJJApaBg+I+WIptz8Qb8f3LxWZIHg5DAU3IUkfTyrN7ARip9EVXcxvlJ Qog0O2gyj8RAoMai1JE5EDy9rxDLflMTelQbuzxGh7zTckBw4n/HDeiXd4ciJFqG5SO7 ujZN2U0Ehnt+hq1ABMwulOihBNawlI/V+WEJDl/usjCNs2kGDcg33rL81Aqi6iEUJNZE 5QGCu8E9fTVMXV8q7vo/2t5e4oAX/4RpR3cLT6EknKu3meXp6tx5J0i8/aOXH/Be27Ym wipMvGzgPk2YuJzbkS/6knhJH+5+mnUSVC9Nnv+ln9WhCRlK3BW91WFrxKz6ywqbXM5o sqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=r+Xaz8Tzurlrpvmg3D5gU+jZ0wh+1WExU/S+n7C/ga8=; b=lSAy/lsQwQR/fdRNDuOeGvd8CoAgyT4R57L7w+qBhMxRf3lKisF7qq0SciLY3UWa4A qw3oqeCjoMZb87n8bEqq7AWMsU1s3AIg/nj9IL82KWF99VX+kgRszTYPyWNkWbH+UNpI sOusEfo3c1G+i9MLccS4cp6ngx8DO+BEi/UQIX+XZgI7b/dM0IrircRFBUdQxHaZ+c4R HF+gAW+BmfC/Wzr/vr1woU8ubukYDRI3/F1YVKdruKLg9tAo3zTmhgBvb7txKuGcS/Ym yvDpGlCl/aFCxywZplbFhOQqaSz/KnLtNsSRTIzvWxT2H7sIGX8ccP75Y3OOaGdPl9LR siPA== X-Gm-Message-State: AN3rC/7GV2uiNfYO8ogvDOHpicjYdqcvqhlf+aa4E2NWETGH0WWzbD7I 1sXG0hKBTKmUOpQcz8Y= X-Received: by 10.99.104.9 with SMTP id d9mr35974472pgc.27.1493764522389; Tue, 02 May 2017 15:35:22 -0700 (PDT) Original-Received: from [192.168.24.54] (pl25298.ag0304.nttpc.ne.jp. [133.232.153.210]) by smtp.gmail.com with ESMTPSA id i63sm2064719pgc.26.2017.05.02.15.35.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 15:35:21 -0700 (PDT) In-Reply-To: <95dd877e-8c5d-533a-7680-8782dcdad88a@gmail.com> X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214531 Archived-At: > On May 3, 2017, at 0:41, Cl=C3=A9ment Pit-Claudel = wrote: >=20 > Looks good. The stirng could be called string-trim-regexp (no need = for default), though, I think. I copied the name pattern from subr.el (split-string). I have no strong = opinion about names but I thought it was good to keep some consistency = between similar functions (although I understand that not all default = values are named "default"...) Jean-Christophe >=20 > On 2017-05-02 05:34, Jean-Christophe Helary wrote: >> Following the discussion about how trimming in subr-x.el did not = allow for non-default regex, I have this small modification to the 3 = trimming functions found therein. >>=20 >> Basically: >> 1) I extracted the default regex and assigned it to = string-trim-default-regex