From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Fri, 11 Nov 2022 06:48:07 +0100 Message-ID: References: <87tu36em9t.fsf@thornhill.no> <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36158"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 11 06:50:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otMvf-0009DH-6m for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Nov 2022 06:50:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otMv0-0008NB-03; Fri, 11 Nov 2022 00:49:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otMuu-0008Mx-Kh for emacs-devel@gnu.org; Fri, 11 Nov 2022 00:49:28 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otMus-0007Qn-7F for emacs-devel@gnu.org; Fri, 11 Nov 2022 00:49:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668145735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HIWkT6l3iJzhfsq+hc0+/RoK9365Y2ColM5H+rsgI9c=; b=ymwACJef3QiANZGgQ3+suKTNtFj2a0Wm+uD3dKsUxjPILe1soM/Cr8v2L33VGDbrWeaqJ5 EVgdArLDQ5qgnmUgz/qFAu5VkbxTzX+rPLEKF7S+HWfS2Du2YCg9Ak59gqejWy1kMupvAZ m4IOLZ6QHvVBHt97PnKe0RTilb7HP8SIor2Z0rDH2w6rl8yjpbdmE9pfSbGDleTHNSTKg/ R194LS82+DDq0YaRwCQz17uMEfQqEgHHj9ayXUHeMuE4Sef/ZiOkXii4KbEXGkOM/K+iPV PAe4RF9BlOcD8tEwHfiIO6GZD+UCBOG2kYv9Y4/+5HOhSIiac27t/rO2BrSjyg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299542 Archived-At: On 10 November 2022 23:58:12 CET, Yuan Fu wrote: > > >> On Nov 10, 2022, at 9:45 AM, Theodor Thornhill wr= ote: >>=20 >>=20 >>=20 >> Hi all, >>=20 >> See the attached patch for support for several C-like languages=2E >>=20 >> They all support: >> - Font locking >> - Indentation (with styles for c/c++) >> - Movement >> - Imenu >> - Which-func >>=20 >> These modes are meant as a supplement to tree-sitter=2E >>=20 >> I'm hopeful for some constructive criticism, and some testing=2E This >> patch needs to be applied to the feature/tree-sitter branch, and should >> hopefully be applied there before we merge the branch to master, well >> before Emacs 29 is cut=2E >>=20 >> I hope you like it, >>=20 >> Theo > >This is fantastic! I=E2=80=99m trying them out right now :-) > >Some things I noticed: > >The indentation for the closing bracket of a struct is off: > >struct regexp_cache >{ > struct regexp_cache *next; > }; > >Imenu has some duplicate entries, the patch below should fix that=2E > >I also added the new contextual thingy to font-lock settings=2E > >Yuan > Yeah, I had a regression=2E Sent a fixed patch=2E Sorry for that=2E=2E=2E