From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] [NS] Fix compilation with clang on OSX Date: Thu, 4 Nov 2010 13:52:00 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288893066 14642 80.91.229.12 (4 Nov 2010 17:51:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 4 Nov 2010 17:51:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?=C4=B0smail_D=C3=B6nmez?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 04 18:51:02 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PE3xl-0000rf-Ps for ged-emacs-devel@m.gmane.org; Thu, 04 Nov 2010 18:51:01 +0100 Original-Received: from localhost ([127.0.0.1]:45655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PE3xl-0005zT-D0 for ged-emacs-devel@m.gmane.org; Thu, 04 Nov 2010 13:51:01 -0400 Original-Received: from [140.186.70.92] (port=47904 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PE3xg-0005zB-4D for emacs-devel@gnu.org; Thu, 04 Nov 2010 13:50:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PE3xf-0001Cv-4u for emacs-devel@gnu.org; Thu, 04 Nov 2010 13:50:56 -0400 Original-Received: from mail-px0-f169.google.com ([209.85.212.169]:52564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PE3xf-0001Cq-0I for emacs-devel@gnu.org; Thu, 04 Nov 2010 13:50:55 -0400 Original-Received: by pxi12 with SMTP id 12so385039pxi.0 for ; Thu, 04 Nov 2010 10:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=X5Mt0z4wL4EBxEfe+fgRgVd6pIuAXfcOmjUVWNk71W8=; b=N4Lznu6mnuO1b3gddmr9lktUeP0/wxgRc2NGnpTVT9dnqrgAIfjb9ZSPcOp8LLQAVT 45G1Eodr4L024koaCQNMJRpy8xPMPJCsQQ7scOkHxD+T2pVnA7q+nlARIAIrnlhcIjlZ vlnrO2vE0+5Q5Juu2wKAbIglSUekdliQ6sIEY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=Hc1wlsjtnfwzhi7couV1teb5XzJ+GJ6Ke+cNUdtg8/SdIITTq9ov9+j/tTyHNTe0J+ 63LSKSjErVKLbcxXWNt62z95TzqBKUxvDekn/X0HvD+e5+gqWEKh7A0jsuZawpbGr0AM b+aIXw9hEpg2mh+nhAkLeNhAg58Xtjtd9IJZs= Original-Received: by 10.142.166.7 with SMTP id o7mr650085wfe.428.1288893053611; Thu, 04 Nov 2010 10:50:53 -0700 (PDT) Original-Received: from elin.psy.cmu.edu (ELIN.PSY.CMU.EDU [128.2.248.190]) by mx.google.com with ESMTPS id w8sm90719vcr.0.2010.11.04.10.50.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Nov 2010 10:50:51 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.1081) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132365 Archived-At: On Nov 4, 2010, at 12:15 PM, =C4=B0smail D=C3=B6nmez wrote: > Attached is a patch fixing emacs compilation with clang on OSX. Just = some minor problems. These are good, even for the non-clang compilation case. In nsfont_draw(), don't you want to return (to-from) rather than 0? Have you obtained significant performance benefits from compiling with = clang?