From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Marshall, Simon" Newsgroups: gmane.emacs.devel Subject: Re: Old redisplay bug in xdisp.c, question about change Date: Tue, 25 Mar 2003 14:44:54 -0000 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" X-Trace: main.gmane.org 1048603716 21025 80.91.224.249 (25 Mar 2003 14:48:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 25 Mar 2003 14:48:36 +0000 (UTC) Cc: "'emacs-devel@gnu.org'" Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 25 15:48:32 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18xpj6-0005Sm-00 for ; Tue, 25 Mar 2003 15:48:32 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18xpk3-0005qc-00 for ; Tue, 25 Mar 2003 15:49:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18xph7-0003sz-0B for emacs-devel@quimby.gnus.org; Tue, 25 Mar 2003 09:46:29 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18xpgR-0002WZ-00 for emacs-devel@gnu.org; Tue, 25 Mar 2003 09:45:47 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18xpgA-00025Y-00 for emacs-devel@gnu.org; Tue, 25 Mar 2003 09:45:33 -0500 Original-Received: from mail17.messagelabs.com ([62.231.131.67]) by monty-python.gnu.org with smtp (Exim 4.10.13) id 18xpfx-00013o-00 for emacs-devel@gnu.org; Tue, 25 Mar 2003 09:45:17 -0500 X-VirusChecked: Checked X-Env-Sender: simon.marshall@misys.com X-Msg-Ref: server-27.tower-17.messagelabs.com!1048603500!8210 Original-Received: (qmail 11261 invoked from network); 25 Mar 2003 14:45:01 -0000 Original-Received: from unknown (HELO pigeon.misys.com) (217.196.235.2) by server-27.tower-17.messagelabs.com with SMTP; 25 Mar 2003 14:45:00 -0000 Original-Received: FROM gull.misys.com BY pigeon.misys.com ; Tue Mar 25 14:45:00 2003 0000 Original-Received: by GULL with Internet Mail Service (5.5.2653.19) id ; Tue, 25 Mar 2003 14:45:01 -0000 Original-To: "'rms@gnu.org'" X-Mailer: Internet Mail Service (5.5.2653.19) Original-cc: "Marshall, Simon" X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12603 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12603 The comments indicate that the menu does not need to be updated, but apparently the tool bar is not updated either, because w->update_mode_line is not set to Qt. There seems to be no ill effects from reverting this change, but since I don't know why it was made in the first place, I can not be sure. Does anybody remember the reason for this change? I think I made this change just as an optimization. So it could be reverted safely. Another alternative is to execute, in that case, just the parts of the if-statement that are really needed in that case. This particular change was part of a group of changes made to prevent or reduce multiple unnecessary runs of menu-bar-update-hook on things like scrolls, tooltips, mouse-1 with mouse-sel-mode, C-s, C-x 2 or menu-bar clicks. (The performance impact is so bad that I use 21.1.90 + these changes for all my editing, rather than 21.2 or 21.3 which do not have them.) The second part of this particular change made the code match the comment; at the time Gerd said this code dated from at least 1994. It would be a shame if this change was simply reverted as the particular problem (multiple unnecessary runs of menu-bar-update-hook on scroll) will presumably resurface. Does the fact that you don't always see a redisplay problem suggest that the bug lies elsewhere? Richard, at the time you suggested a good general fix was to split the functionality of windows_or_buffers_changed into different flags for updating the mode line and updating menus, though I don't think anyone volunteered to implement it. Perhaps a flag for updating the tool bar would also be useful. Simon.