From: "Wedler, Christoph" <christoph.wedler@sap.com>
To: Dmitry Gutov <dgutov@yandex.ru>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Fabián E.Gallina" <fabian@anue.biz>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: antlr-mode.el - need some support by python.el
Date: Mon, 8 Jun 2015 09:12:35 +0000 [thread overview]
Message-ID: <F9C2521BBF380A4A97379009991555E685B8160A@DEWDFEMB17C.global.corp.sap> (raw)
In-Reply-To: <5571E070.9050905@yandex.ru>
>> Many modes use more than the current line / code chunk in their
>> indentation calculations. For example, in `c-guess-basic-syntax', the
>> outer language constructs are also considered. If the indentation
>> engine of the inner mode just see the code chunks, there is a potential
>> problem...
> I think the string value is not ideal, because then the inner mode can't
> cache syntactic information, and reuse it between chunks. This is
> something we probably want to facilitate.
Originally, I had some inner mode dependent value here. Stefan had
objections, because mode-specific stuff in a generic value is not that
nice (agreed) and the outer mode would need to know inner mode internals.
For caching, I can imagine the following:
- the inner mode does at least cache the syntactic info for the last
string (for the grammar case, you would almost ever have a cache hit)
- the inner mode is encouraged to change PREVIOUS-CHUNKS inside
`prog-indentation-context' to the inner mode specific value. The
outer mode can retrieve the value after the call and use it for
further calls.
> Adapting the current major mode indentation code to work with either
> kind of PREVIOUS-CHUNKS value, looks non-trivial as well.
For the string value (for grammars = the case I am interested in):
looks manageable
- I could later add a corresponding patch to cc-mode, see below
- in general, the inner mode could insert the string at START inside a
`call-with-transparent-undo' (XEmacs, whatever the Emacs equivalent
is)
The get-previous-chunk function case (for literate programming = the
case Stefan and you, Dmitry, were interested in): I agree, this is
non-trivial (see my remarks back in Feb/Mar).
> I don't currently have a better suggestion, though. But this proposal
> could use a corresponding patch to cc-mode.
Well, I really like to see something included in Emacs before I spend
more time on this.
My suggestion:
1. Stefan tells me what he had against the "should" in the docstring
of `prog-widen' (and/or sends me a corrected docstring).
I reduce the patch to NOT include PREVIOUS-CHUNKS (and use the
widen-feature of narrow-to-region ;-))
2. If that is included, I reintroduce PREVIOUS-CHUNKS and include a
corresponding patch to cc-mode - but only for the "string/grammar
case"
-- Christoph
next prev parent reply other threads:[~2015-06-08 9:12 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 19:50 antlr-mode.el - need some support by python.el Wedler, Christoph
2015-01-16 23:37 ` Stefan Monnier
2015-02-05 11:39 ` Wedler, Christoph
2015-02-05 14:27 ` Stefan Monnier
2015-02-06 15:14 ` Wedler, Christoph
2015-02-06 17:47 ` Stefan Monnier
2015-02-13 10:56 ` Wedler, Christoph
2015-02-13 19:40 ` Stefan Monnier
2015-02-16 14:38 ` Wedler, Christoph
2015-02-16 19:23 ` Stefan Monnier
2015-02-17 10:55 ` Wedler, Christoph
2015-02-18 0:00 ` Stefan Monnier
2015-02-18 14:27 ` Wedler, Christoph
2015-02-18 3:39 ` Dmitry Gutov
2015-02-18 5:48 ` Stefan Monnier
2015-02-18 14:13 ` Wedler, Christoph
2015-02-18 15:13 ` Dmitry Gutov
2015-02-18 15:41 ` Wedler, Christoph
2015-02-18 17:56 ` Stefan Monnier
2015-02-19 2:43 ` Dmitry Gutov
2015-02-19 3:20 ` Stefan Monnier
2015-02-19 3:30 ` Dmitry Gutov
2015-02-19 13:18 ` Stefan Monnier
2015-02-21 22:14 ` Dmitry Gutov
2015-02-25 11:05 ` Wedler, Christoph
2015-03-01 17:04 ` Stefan Monnier
2015-03-01 22:16 ` Dmitry Gutov
2015-03-02 5:23 ` Stefan Monnier
2015-03-02 15:08 ` Dmitry Gutov
2015-03-02 16:48 ` Stefan Monnier
2015-03-02 18:04 ` Dmitry Gutov
2015-03-02 18:51 ` Stefan Monnier
2015-03-02 19:31 ` Dmitry Gutov
2015-03-03 16:32 ` Stefan Monnier
2015-03-04 16:53 ` Wedler, Christoph
2015-03-04 17:20 ` Dmitry Gutov
2015-03-05 9:46 ` Wedler, Christoph
2015-03-05 12:29 ` Dmitry Gutov
2015-03-05 12:43 ` Dmitry Gutov
2015-04-02 14:10 ` Wedler, Christoph
2015-04-07 17:49 ` Stefan Monnier
2015-04-09 14:07 ` Wedler, Christoph
2015-04-09 18:13 ` Stefan Monnier
2015-06-03 14:14 ` Wedler, Christoph
2015-06-03 15:31 ` Stefan Monnier
2015-06-05 14:17 ` Wedler, Christoph
2015-06-05 17:46 ` Dmitry Gutov
2015-06-08 9:12 ` Wedler, Christoph [this message]
2015-06-08 13:26 ` Stefan Monnier
2015-06-08 16:02 ` Dmitry Gutov
2015-06-08 20:50 ` Stefan Monnier
2015-06-08 21:33 ` Dmitry Gutov
2015-06-09 9:07 ` Wedler, Christoph
2015-06-09 15:58 ` Stefan Monnier
2015-06-09 19:05 ` Wedler, Christoph
2015-06-15 11:02 ` Dmitry Gutov
2015-06-08 13:18 ` Stefan Monnier
2015-03-04 17:37 ` Dmitry Gutov
2015-03-04 22:26 ` Stefan Monnier
2015-03-04 22:59 ` Dmitry Gutov
2015-03-10 1:16 ` Stefan Monnier
2015-03-21 15:30 ` Dmitry Gutov
2015-03-21 17:08 ` Stefan Monnier
2015-03-21 23:41 ` Dmitry Gutov
2015-03-22 13:54 ` Stefan Monnier
2015-03-22 19:31 ` Dmitry Gutov
2015-03-22 21:59 ` Stefan Monnier
2015-03-23 14:03 ` Dmitry Gutov
2015-03-23 19:25 ` Stefan Monnier
2015-03-04 16:29 ` Wedler, Christoph
2015-03-04 17:16 ` Dmitry Gutov
2015-03-01 22:25 ` Dmitry Gutov
2015-02-18 12:22 ` Wedler, Christoph
2015-02-18 15:29 ` Dmitry Gutov
2015-02-18 16:10 ` Wedler, Christoph
2015-02-18 22:55 ` Dmitry Gutov
2015-02-25 11:16 ` Wedler, Christoph
2015-02-18 3:15 ` Dmitry Gutov
2015-02-22 7:52 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9C2521BBF380A4A97379009991555E685B8160A@DEWDFEMB17C.global.corp.sap \
--to=christoph.wedler@sap.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=fabian@anue.biz \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).