From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Sat, 11 Mar 2023 00:45:03 +0100 Message-ID: References: <1587ddb6-f631-0890-965a-c7acb5729fa6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26993"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?ISO-8859-1?Q?Jo=E3o_T=E1vora?= , Helmut Eller To: Dmitry Gutov , emacs-devel@gnu.org, John Yates Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 11 00:46:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pamR3-0006nD-Js for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Mar 2023 00:46:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pamQN-0006ZC-ME; Fri, 10 Mar 2023 18:45:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pamQL-0006Yw-5E for emacs-devel@gnu.org; Fri, 10 Mar 2023 18:45:21 -0500 Original-Received: from sonic302-3.consmr.mail.bf2.yahoo.com ([74.6.135.42]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pamQI-0006al-JU for emacs-devel@gnu.org; Fri, 10 Mar 2023 18:45:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1678491914; bh=2OPGFONEtKRx9VRTXKK/5VoLdRj5K8mGXM5NfcPjPls=; h=Date:From:To:CC:Subject:In-Reply-To:References:From:Subject:Reply-To; b=BjjZvChdGSCmEnuM6aq6lO4k4YW7KVRccMdQdu9MX/40fozlNGpTL/U/8nqBM0WGTdX/aSm0+Owh1LQpjv/5R/9Y3/eJ7JNKAjhel0TPhwLxogGZCh/czV1rQPQjV2j2e52KEN5hXasEHmBgu3zezMPaOl5k4B3GAt2bO9nRQqaN0mWL9lOkzzBu4mTKjZmIF9OCKm0aurkvTZrqdXdkY6kjFp6+WzJVATwU4xAb3x+aSQDO3gpSyVW5BVyo3BQH4Ul4i4ol0XTtLOt7HFaH59gWvoKD0/XZ98XrEbQqHsMKtixEm74JFOOMFeGCKYahH9b3T6sZMecF5PNAm9E4rQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678491914; bh=+2xxRmYyAZbN/KOnJRM4ejlD6/KcvWAxhzQ733XbdQN=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=MEecqYC/8ZvWYvSgiZeSFXWDha7t4avYDFL0FOqkFUY4pIkpDbV7l7cZmkM3DGyvTbHu73j1UwQ+5fpk/p8ZbMTVoQ2aKGB+pXIoGlll3C/HH7yiIEAYmXKRBnWiKouNWNL2oASNMuCekV+f/0ninpJpo6jVt1of6adXRkMDiSzdkIt/8Xk3AmhGDGdix/6NH5jNKQD0ou0kVyp1nKDiG3U3XBeby9XXckZvixJO8dLPpkR1jsRtOVsEC6llgofqGWSRChVlhxO13lXHJK/k1Y9wwH5cMPZOxmvQmGLDE3egwK0Rs40ustP2CJku1mnhcH4fYqLwMhfwALIN7SFfSg== X-YMail-OSG: 7yafTysVM1n0xGvATfMpJY3BVM.xh3c0XzA1XK.4MBQu5zOSJV2HFKERQ3h08E1 Odhq0phHGUW88Cmd3bABBSbXp15yCllUIE19xGoDz73yjvsExOoeAmWYBYOQEEaA8qdoBLCF1OA8 ZJzcu3JmCnlg3flNgq4QPiWc_nkj8wR6Afgmn9Qp.4KOGt2MZXUTUdPnCGP8GseB2akjbhSkcfNS fveJ05R.VsdCWSbu476Tf8cIl4cLZ3kFOpSg6mF6gnNXrRo_eO7I1wVU7jFrpZr9m9Hg3ssRc1gM n9CcgbJtuGUzT1O1z0SBkj8rnZPUDM.VRBjpFgNGXH1JG1SqJS8JJO4VnaZDo90oYWsgJU5Zrpj8 4L74To0LT2YHTbV3_r1hBjyFIf1x6T69pjSQXEHtWkW5tKJJrfRRlG6wiqdn9a6VElSTIgJguVN7 4ODBaZBl8X4ZP23V1fpr6l3bIzosXKcOdzFUmrD7lJtwC6jMR2eQRMBiTpUJi9l.2ilFslTW2Zm3 LNVuNmgq1Y_ScBu5nOFUlQ4SS5rB1K47NkQvMV_Bsrigj6oWJ9uapl6qrqPGimWgCCsbVuuumK8T lKhpPdxraLLuoNHXD29Ycnl4joW30cFuwqtRWa8TKMjuuAn4DvZJE9ZElo8QQuueH2hgnMS6Tffa DbzKxGRL1_pqCxy88Fj40IJxYAg5Xr22Jip1tUQPfAPQPy61kWFGUEyDPKWEGLqr111vZFIEcf8d rJcN5NMOPxIIrl3NIUyCJpct1IsKzXhCLhPWuGZcUTZptdU7uGHgxoTUjj5SToBa_VYsMeNh2GIk oq7Cr8knJWE6ixI_.S.qPrrc6u1JF7GqdiJj9BMO6A X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.bf2.yahoo.com with HTTP; Fri, 10 Mar 2023 23:45:14 +0000 Original-Received: by hermes--production-ir2-5b7d458747-5x8b8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4341c61bc5d8cf08144fc2354663423c; Fri, 10 Mar 2023 23:45:10 +0000 (UTC) In-Reply-To: X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.135.42; envelope-from=spacibba@aol.com; helo=sonic302-3.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304264 Archived-At: On March 10, 2023 10:55:24 PM GMT+01:00, Dmitry Gutov = wrote: >On 10/03/2023 02:57, Ergus wrote: >> Ho Dmitry and Joao >>=20 >> On March 6, 2023 3:09:40 PM GMT+01:00, Dmitry Gutov wrote: >>> On 06/03/2023 01:40, John Yates wrote: >>>> For languages that do not distinguish declaration from definition, >>>> another alternative is to have both key bindings reference the same >>>> find-definition functionality=2E >>=20 >> Yes please, just fall back to find-definition (or find-references) + a = warning when find-declaration or the the others are not supported? It is si= mpler and practical=2E > >Could you explain this usage scenario? Why not just report "unsupported" = and let the user try again with the simpler key binding (M-=2E)? > >It's not like people will prefer to reach for C-M-?, or will hit it by ac= cident=2E > It is mostly conceptual=2E In the languages without declarations generally= the declaration IS the definition itself=2E >> Alternatively there could be a default fallback command similar to find= -references but reordering to list definitions first (just an example) > >That sounds harder because at the moment our "reference" items don't have= indication of which type they are=2E So if we wanted this to work well, we= 'd have to mandate that additional information, and we don't have any good = implementation options for either etags or elisp backend that would do that= =2E I understand=2E=2E=2E I was thinking in a dumb check of coincidences betwe= en references and definitions list=2E Implying to call both and a side to s= ide comparison =2E=2E=2E But it doesn't worth it probably=2E=2E=2E=2E > >>> I think I would generally prefer for the "find declarations" binding t= o end with an error when unsupported rather than repeat an existing command= which is already accessible through an easier key binding=2E >>>=20 >>> Otherwise some users might waste time wondering over the difference, t= esting, and comparing -- I myself would, probably=2E >>>=20 >>=20 >> Before binding to a key maybe let's start again with the simpler: to a= dd them in the right click context menu=2E=2E=2E And we can find a binding = later=2E > >We can do both=2E I am very excited to see this feature working=2E=2E=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E