From: Qiantan Hong <qhong@mit.edu>
To: "cpitclaudel@gmail.com" <cpitclaudel@gmail.com>,
Eli Zaretskii <eliz@gnu.org>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Question: add-face-text-property for 'font-lock-face?
Date: Sun, 29 Aug 2021 21:13:11 +0000 [thread overview]
Message-ID: <F69A75FB-FCEF-407A-A4B7-1F488A09A5B8@mit.edu> (raw)
In-Reply-To: <5cf80cca-828a-614c-9cb4-d478a04c05f5@gmail.com>
> You want font-lock-append-text-property, I think:
>
> (font-lock-append-text-property START END PROP VALUE &optional OBJECT)
I think rather than hardcode a C function for another property, we could just
expose the general function the C implementation now is internally using
(add-text-property-1 START END PROP OBJECT MODE DESTRUCTIVE)
However, sorry for my own confusion, I found out this actually doesn’t solve my problem.
Recall the problem:
> Users of crdt.el report that crdt-visualize-author-mode (which use font-lock-face to color code author of texts)
> conflict with faces from other modes. Apparently there are more than 1 mode which sets this text property.
In fact in most cases those other mode doesn’t set the ‘font-lock-face property,
the problem is ‘font-lock-face property (aka recalculated fontification) I set overrides other font lock mechanism.
Is there a right way to add attributes while preserving font lock faces from other mode?
I now see that Yuan’s suggestion of overlay will do this, but there’s performance concern.
next prev parent reply other threads:[~2021-08-29 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 4:13 Question: add-face-text-property for 'font-lock-face? Qiantan Hong
2021-08-29 4:24 ` Yuan Fu
[not found] ` <B73E855F-7E55-4217-BD43-E1272939E491@mit.edu>
2021-08-29 4:36 ` Qiantan Hong
2021-08-30 8:22 ` Ihor Radchenko
[not found] ` <945E4D23-3D8C-45AB-9C10-992638A30607@gmail.com>
2021-08-29 4:47 ` Qiantan Hong
2021-08-29 23:50 ` Stefan Monnier
2021-08-29 7:05 ` Eli Zaretskii
2021-08-29 7:19 ` Qiantan Hong
2021-08-29 7:49 ` Eli Zaretskii
2021-08-29 16:15 ` Clément Pit-Claudel
2021-08-29 21:13 ` Qiantan Hong [this message]
2021-08-29 23:47 ` Stefan Monnier
2021-08-30 0:41 ` Qiantan Hong
2021-08-30 8:18 ` Ihor Radchenko
2021-08-29 16:13 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F69A75FB-FCEF-407A-A4B7-1F488A09A5B8@mit.edu \
--to=qhong@mit.edu \
--cc=cpitclaudel@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).