* Re: emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines'
[not found] ` <20230219090532.BB896C1391D@vcs2.savannah.gnu.org>
@ 2023-02-20 21:19 ` Daniel Martín
2023-02-20 22:08 ` Theodor Thornhill
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Martín @ 2023-02-20 21:19 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
Eli Zaretskii <eliz@gnu.org> writes:
> branch: emacs-29
> commit cd05fca5f78048cb867be2d5f0857f6997f12ccc
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> ; Improve documentation of 'native-comp-enable-subr-trampolines'
>
> * doc/lispref/compile.texi (Native-Compilation Variables):
> Document the interpretation of non-absolute directory names that
> are the value of 'native-comp-enable-subr-trampolines'.
[...]
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index b71b5b486d5..297812f23f7 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -1204,6 +1204,11 @@ See `treesit-simple-indent-presets'.")
> (cons 'grand-parent
> (lambda (_n parent &rest _)
> (treesit-node-start (treesit-node-parent parent))))
> + (cons 'great-grand-parent
> + (lambda (_n parent &rest _)
> + (treesit-node-start
> + (treesit-node-parent
> + (treesit-node-parent parent)))))
> (cons 'parent-bol (lambda (_n parent &rest _)
> (save-excursion
> (goto-char (treesit-node-start parent))
This commit contains some Tree-sitter changes that seem unrelated. Are
they intended?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines'
2023-02-20 21:19 ` emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines' Daniel Martín
@ 2023-02-20 22:08 ` Theodor Thornhill
2023-02-21 3:29 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Theodor Thornhill @ 2023-02-20 22:08 UTC (permalink / raw)
To: emacs-devel, Daniel Martín; +Cc: Eli Zaretskii
On 20 February 2023 22:19:31 CET, "Daniel Martín" <mardani29@yahoo.es> wrote:
>Eli Zaretskii <eliz@gnu.org> writes:
>
>> branch: emacs-29
>> commit cd05fca5f78048cb867be2d5f0857f6997f12ccc
>> Author: Eli Zaretskii <eliz@gnu.org>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>> ; Improve documentation of 'native-comp-enable-subr-trampolines'
>>
>> * doc/lispref/compile.texi (Native-Compilation Variables):
>> Document the interpretation of non-absolute directory names that
>> are the value of 'native-comp-enable-subr-trampolines'.
>
>[...]
>
>> diff --git a/lisp/treesit.el b/lisp/treesit.el
>> index b71b5b486d5..297812f23f7 100644
>> --- a/lisp/treesit.el
>> +++ b/lisp/treesit.el
>> @@ -1204,6 +1204,11 @@ See `treesit-simple-indent-presets'.")
>> (cons 'grand-parent
>> (lambda (_n parent &rest _)
>> (treesit-node-start (treesit-node-parent parent))))
>> + (cons 'great-grand-parent
>> + (lambda (_n parent &rest _)
>> + (treesit-node-start
>> + (treesit-node-parent
>> + (treesit-node-parent parent)))))
>> (cons 'parent-bol (lambda (_n parent &rest _)
>> (save-excursion
>> (goto-char (treesit-node-start parent))
>
>This commit contains some Tree-sitter changes that seem unrelated. Are
>they intended?
>
If unintended at least they are needed now. Maybe some left over code from one of my patches snuck into your commit? I tried looking for that code and was surprised when I couldn't find it locally :)
Theo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines'
2023-02-20 22:08 ` Theodor Thornhill
@ 2023-02-21 3:29 ` Eli Zaretskii
2023-02-21 6:20 ` Theodor Thornhill
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2023-02-21 3:29 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: emacs-devel, mardani29
> Date: Mon, 20 Feb 2023 23:08:11 +0100
> From: Theodor Thornhill <theo@thornhill.no>
> CC: Eli Zaretskii <eliz@gnu.org>
>
>
>
> On 20 February 2023 22:19:31 CET, "Daniel Martín" <mardani29@yahoo.es> wrote:
> >Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> branch: emacs-29
> >> commit cd05fca5f78048cb867be2d5f0857f6997f12ccc
> >> Author: Eli Zaretskii <eliz@gnu.org>
> >> Commit: Eli Zaretskii <eliz@gnu.org>
> >>
> >> ; Improve documentation of 'native-comp-enable-subr-trampolines'
> >>
> >> * doc/lispref/compile.texi (Native-Compilation Variables):
> >> Document the interpretation of non-absolute directory names that
> >> are the value of 'native-comp-enable-subr-trampolines'.
> >
> >[...]
> >
> >> diff --git a/lisp/treesit.el b/lisp/treesit.el
> >> index b71b5b486d5..297812f23f7 100644
> >> --- a/lisp/treesit.el
> >> +++ b/lisp/treesit.el
> >> @@ -1204,6 +1204,11 @@ See `treesit-simple-indent-presets'.")
> >> (cons 'grand-parent
> >> (lambda (_n parent &rest _)
> >> (treesit-node-start (treesit-node-parent parent))))
> >> + (cons 'great-grand-parent
> >> + (lambda (_n parent &rest _)
> >> + (treesit-node-start
> >> + (treesit-node-parent
> >> + (treesit-node-parent parent)))))
> >> (cons 'parent-bol (lambda (_n parent &rest _)
> >> (save-excursion
> >> (goto-char (treesit-node-start parent))
> >
> >This commit contains some Tree-sitter changes that seem unrelated. Are
> >they intended?
> >
>
> If unintended at least they are needed now. Maybe some left over
> code from one of my patches snuck into your commit?
Yes, sorry.
> I tried looking for that code and was surprised when I couldn't find it locally :)
If it isn't needed now, feel free to revert, and thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines'
2023-02-21 3:29 ` Eli Zaretskii
@ 2023-02-21 6:20 ` Theodor Thornhill
0 siblings, 0 replies; 4+ messages in thread
From: Theodor Thornhill @ 2023-02-21 6:20 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, mardani29
On 21 February 2023 04:29:48 CET, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 20 Feb 2023 23:08:11 +0100
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: Eli Zaretskii <eliz@gnu.org>
>>
>>
>>
>> On 20 February 2023 22:19:31 CET, "Daniel Martín" <mardani29@yahoo.es> wrote:
>> >Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> >> branch: emacs-29
>> >> commit cd05fca5f78048cb867be2d5f0857f6997f12ccc
>> >> Author: Eli Zaretskii <eliz@gnu.org>
>> >> Commit: Eli Zaretskii <eliz@gnu.org>
>> >>
>> >> ; Improve documentation of 'native-comp-enable-subr-trampolines'
>> >>
>> >> * doc/lispref/compile.texi (Native-Compilation Variables):
>> >> Document the interpretation of non-absolute directory names that
>> >> are the value of 'native-comp-enable-subr-trampolines'.
>> >
>> >[...]
>> >
>> >> diff --git a/lisp/treesit.el b/lisp/treesit.el
>> >> index b71b5b486d5..297812f23f7 100644
>> >> --- a/lisp/treesit.el
>> >> +++ b/lisp/treesit.el
>> >> @@ -1204,6 +1204,11 @@ See `treesit-simple-indent-presets'.")
>> >> (cons 'grand-parent
>> >> (lambda (_n parent &rest _)
>> >> (treesit-node-start (treesit-node-parent parent))))
>> >> + (cons 'great-grand-parent
>> >> + (lambda (_n parent &rest _)
>> >> + (treesit-node-start
>> >> + (treesit-node-parent
>> >> + (treesit-node-parent parent)))))
>> >> (cons 'parent-bol (lambda (_n parent &rest _)
>> >> (save-excursion
>> >> (goto-char (treesit-node-start parent))
>> >
>> >This commit contains some Tree-sitter changes that seem unrelated. Are
>> >they intended?
>> >
>>
>> If unintended at least they are needed now. Maybe some left over
>> code from one of my patches snuck into your commit?
>
>Yes, sorry.
No worries :)
>
>> I tried looking for that code and was surprised when I couldn't find it locally :)
>
>If it isn't needed now, feel free to revert, and thanks.
Nono I need it :) preproc directives cannot work without it :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-21 6:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <167679753183.27800.15417292857625386809@vcs2.savannah.gnu.org>
[not found] ` <20230219090532.BB896C1391D@vcs2.savannah.gnu.org>
2023-02-20 21:19 ` emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines' Daniel Martín
2023-02-20 22:08 ` Theodor Thornhill
2023-02-21 3:29 ` Eli Zaretskii
2023-02-21 6:20 ` Theodor Thornhill
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).