From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Jesse Medeiros Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Fri, 7 Feb 2020 14:06:59 -0300 Message-ID: References: <83tv4mrn9i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="5e3d9933_25f6a15c_589" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="20718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?=EC=A1=B0=EC=84=B1=EB=B9=88?= , "=?utf-8?Q?emacs-devel=40gnu.org?=" To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 07 19:28:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j08MM-0005FV-NE for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Feb 2020 19:28:10 +0100 Original-Received: from localhost ([::1]:33956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j08ML-000450-P4 for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Feb 2020 13:28:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j075w-0005Vi-S6 for emacs-devel@gnu.org; Fri, 07 Feb 2020 12:07:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j075v-0005pm-Ff for emacs-devel@gnu.org; Fri, 07 Feb 2020 12:07:08 -0500 Original-Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:41947) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j075v-0005ok-BB for emacs-devel@gnu.org; Fri, 07 Feb 2020 12:07:07 -0500 Original-Received: by mail-qk1-x72f.google.com with SMTP id d11so2890493qko.8 for ; Fri, 07 Feb 2020 09:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=Hjzn+F/f4UteUybS18jXQZdkbDPEk7mAANq989OsBHU=; b=mkc+Fb54n6vuzhYF21/JGE+8GRMAiifRPaqFIsZNVVXGQGw4tmrVDpAz5vDC+MhnfT V1wJjey6h6EXLV3LyOCMpVtLwwYfx9watQb1LPD+eH1OWxsCmF8nK5N0KZTj4PrPcH8g wYMYYgqh8EMqE3iblVf9lpI8j5cnOPOVdiWp1D2mDCeKVqfVimNGHPTbhkcuOM9MwwVH 0tA8DwUdlLqG4q0AhcKNaHF8MHBlHw72SYJtL0UGnSt7HQ/mO5b6t7msmiZ8Fey7P8XT ZKP1Cx9/i89hnte7S1lhIyaiY2FmYJvuNadu5UFfVmxbMyy6pZFYIRWrtk99NkHa/ylj Gy1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=Hjzn+F/f4UteUybS18jXQZdkbDPEk7mAANq989OsBHU=; b=nMclwlFMibrbgQNdmNOAUD+VgZe7jLSrslwZzDwZt2WxUMYXDTD4Ql70XjHvPJv0HB mPyEdygazAhbGc3ZdkgLGL7ygXN5Z9MsPBV3bRZe8lyHq2Z6XTnAuOts2m9LAxTaaeiZ Sdt/Mmsgc8oNoVEG9BE6hm/aRckoZZdWqSxi2gS0pi6+S3u2mNL4UyRkJw8G0F6/liEA leLUzTTgARjo3uSOJwOrxaTJ+/i9BSRLC+05SwQXuA+kSwsR41jztr8JXG4xlslElh0B FcW5jDxMRapJZ73LS1uqRBPt+URrAPugK1kLcPnbh3CruMvnGyWz50pgzmUEdk03iXVe Y2Cg== X-Gm-Message-State: APjAAAUjccMahX1fR+nJC4IyHsW/JUtRiOCymaTmXW3yV4+3i+BcRKVX S7CNitasgFyrhrwHpnnCiSPvSSMCH3w= X-Google-Smtp-Source: APXvYqw56YhNmA8epAmrIo7k4/lSmKV0l5RjFfe/pbOUtsOVii1P60g6Csb602fdsKiF5/TM0f6J7A== X-Received: by 2002:a37:680b:: with SMTP id d11mr8382843qkc.471.1581095226642; Fri, 07 Feb 2020 09:07:06 -0800 (PST) Original-Received: from archnote ([2804:431:a045:ca00:b087:8456:3a3b:faf0]) by smtp.gmail.com with ESMTPSA id h7sm1616374qke.30.2020.02.07.09.07.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2020 09:07:06 -0800 (PST) In-Reply-To: <83tv4mrn9i.fsf@gnu.org> X-Mailer: Mailspring X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72f X-Mailman-Approved-At: Fri, 07 Feb 2020 13:27:34 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244898 Archived-At: --5e3d9933_25f6a15c_589 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline How can offer a copyright assignment=3F I give permission to do whatever = you want with this patch. I don't claim any copyright over it. On Jan 23 2020, at 5:22 pm, Eli Zaretskii wrote: > > =46rom: =EC=A1=B0=EC=84=B1=EB=B9=88 > > Date: =46ri, 24 Jan 2020 01:32:21 +0900 > > Cc: jessenzr=40gmail.com > > > > =46rom 1302c040a23837b80a53416421914f3fe8ba1926 Mon Sep 17 00:00:00 2= 001 > > =46rom: Sungbin Jo > > Date: =46ri, 24 Jan 2020 00:56:38 +0900 > > Subject: =5BPATCH=5D Add new variable for centering lines vertically.= > > > > Co-authored-by: Jesse Nazario > Most of the patch was written by Jesse, and we don't have a copyright > assignment for Jesse on file. We need that to accept this > contribution. > > > + if (NILP (BVAR (XBU=46=46ER (it->w->contents), > > + line=5Fspacing=5Fvertical=5Fcenter))) > > > No need to use BVAR here, since the buffer whose window is being > displayed is always the current buffer when the display code runs. > > Thanks. --5e3d9933_25f6a15c_589 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
How can offer a copyright assignment=3F I give permission to do what= ever you want with this patch. I don't claim any copyright over it.
=
On Jan 23 2020, at 5:2= 2 pm, Eli Zaretskii <eliz=40gnu.org> wrote:
<= blockquote>
=46rom: =EC=A1=B0=EC=84=B1=EB=B9=88 <pcr910303=40iclou= d.com>
Date: =46ri, 24 Jan 2020 01:32:21 +0900
Cc:= jessenzr=40gmail.com

=46rom 1302c040a23837b80a53416421914f= 3fe8ba1926 Mon Sep 17 00:00:00 2001
=46rom: Sungbin Jo <pcr9= 10303=40icloud.com>
Date: =46ri, 24 Jan 2020 00:56:38 +0900<= /div>
Subject: =5BPATCH=5D Add new variable for centering lines verti= cally.

Co-authored-by: Jesse Nazario <jessenzr=40gmail.c= om>

Most of the patch was written by Jesse,= and we don't have a copyright
assignment for Jesse on file. We= need that to accept this
contribution.

+ if (NILP (BVAR (XBU=46=46ER (it->w->contents),
+ lin= e=5Fspacing=5Fvertical=5Fcenter)))

No need to = use BVAR here, since the buffer whose window is being
displayed= is always the current buffer when the display code runs.

T= hanks.
3D=22= --5e3d9933_25f6a15c_589--