From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: lisp/term/ns-win.el modification
Date: Thu, 4 May 2017 09:10:18 +0900 [thread overview]
Message-ID: <F3733906-245B-49B1-B6CC-4714EE28FC44@gmail.com> (raw)
In-Reply-To: <CABr8ebY6EZLwGDC=Dohmk3vTpTZH_DDSycBHGMzaHRrR0z+eEw@mail.gmail.com>
Anders,
> I just tested your latest patch. The code looks much cleaner now when you use `split-string'. (I didn't know it could all those tricks -- it's always good to learn something new!)
Well, I did not know I would be able to even do that in the first place before reading everybody's comments...
> Some minor details:
Details are never minor. They're what makes it look like somebody actually cared for the code :)
> * You no longer need the `(if (not (equal "" filestring"))' test -- when the OMIT-NULLS argument is non-nil, `split-string' ensures that the list doesn't contain empty strings.
You're totally right (and I thought I had read that function dozens of times already).
> * You misspelled "trimmed" as "timmed" in the comment in `ns-open-file-service'.
Oversight.
I'll send something again later. Sorry for the hassle.
Jean-Christophe
next prev parent reply other threads:[~2017-05-04 0:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 4:50 lisp/term/ns-win.el modification Jean-Christophe Helary
2017-04-27 9:02 ` Anders Lindgren
2017-04-27 10:13 ` Jean-Christophe Helary
2017-04-27 11:30 ` Anders Lindgren
2017-04-27 14:53 ` Jean-Christophe Helary
2017-04-27 15:09 ` Davis Herring
2017-04-27 15:31 ` Jean-Christophe Helary
2017-04-27 23:32 ` Jean-Christophe Helary
[not found] ` <15112485-03CC-4FFF-8A9D-BA28D2490A91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-28 1:49 ` Jean-Christophe Helary
2017-04-29 12:24 ` Anders Lindgren
[not found] ` <CABr8ebaB1Fp0BgVy7LWwtOnSs1UOXr3CJumMfOWR4JOooQMT4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-29 12:49 ` Jean-Christophe Helary
2017-04-30 5:36 ` Anders Lindgren
2017-04-30 12:14 ` Noam Postavsky
2017-04-30 6:41 ` Jean-Christophe Helary
2017-04-30 14:12 ` Eli Zaretskii
2017-04-30 15:06 ` Clément Pit-Claudel
2017-04-30 15:24 ` Eli Zaretskii
2017-04-30 22:28 ` Jean-Christophe Helary
2017-05-01 6:33 ` Eli Zaretskii
2017-05-01 8:23 ` Jean-Christophe Helary
2017-05-01 8:59 ` Eli Zaretskii
2017-05-01 10:53 ` Jean-Christophe Helary
2017-05-01 11:27 ` Eli Zaretskii
2017-05-02 4:00 ` Jean-Christophe Helary
2017-05-02 6:44 ` Eli Zaretskii
2017-05-02 6:47 ` Jean-Christophe Helary
2017-05-01 15:12 ` Jean-Christophe Helary
2017-05-01 15:27 ` Eli Zaretskii
2017-05-01 15:58 ` Jean-Christophe Helary
2017-05-01 16:25 ` Eli Zaretskii
2017-05-02 12:57 ` Jean-Christophe Helary
2017-05-03 20:40 ` Anders Lindgren
2017-05-04 0:10 ` Jean-Christophe Helary [this message]
2017-05-04 8:50 ` Jean-Christophe Helary
2017-05-04 18:37 ` Anders Lindgren
2017-05-05 8:36 ` Jean-Christophe Helary
2017-04-30 22:23 ` Jean-Christophe Helary
2017-05-01 6:30 ` Eli Zaretskii
2017-04-27 12:24 ` Noam Postavsky
2017-04-27 14:53 ` Jean-Christophe Helary
2017-04-27 12:51 ` mituharu
2017-04-27 14:55 ` Jean-Christophe Helary
2017-04-27 15:35 ` Jean-Christophe Helary
2017-04-27 18:28 ` mituharu
2017-04-27 23:29 ` Jean-Christophe Helary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3733906-245B-49B1-B6CC-4714EE28FC44@gmail.com \
--to=jean.christophe.helary@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).