From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Understanding end-of-defun Date: Thu, 10 Nov 2022 15:10:07 -0800 Message-ID: References: <46FF2036-9AB4-4C57-82B5-51260D287FC5@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 11 00:11:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otGhI-00051Q-Dq for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Nov 2022 00:11:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otGgb-0001bH-KS; Thu, 10 Nov 2022 18:10:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGga-0001av-2u for emacs-devel@gnu.org; Thu, 10 Nov 2022 18:10:16 -0500 Original-Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otGgW-0000vp-HC for emacs-devel@gnu.org; Thu, 10 Nov 2022 18:10:15 -0500 Original-Received: by mail-pl1-x634.google.com with SMTP id d20so2803270plr.10 for ; Thu, 10 Nov 2022 15:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oKquZXscRe7lWPygOLVuNW7CaZqX3ExJrGdTyAhEXYs=; b=KL0OxZVv1FAn0SBCO8CpCvYD18/B11TKMGUP8AXD/v/9sKlA8H8HNvcq0tVIYqCJ4P X9REXxTS7r+gtWcg7tADXen+xGVGsIRw27EPCPF4i5t3nK3Q7sgTyiZiOAEJBuiL6WpN UCVZLC4l7hoUHlBHclW1OP+h5+AZXsF15gHe21IH9mJfhZEyBJf+kkcDwtDIaRN49nI/ Nuyqplwfk95ewXcjGaSs6w7Wfnv0+DQYuKAWjn0KyUty8+UE9HvJtfkNX+ozO+K1OoBT RXyDoywfEpsdGYNAKSYLE1vHjhMLiJPFdQEtMCIIa28aPZu5L2XicDjNf8CTTFSwRSoF B/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oKquZXscRe7lWPygOLVuNW7CaZqX3ExJrGdTyAhEXYs=; b=IhmhsZeO9vZTS9WmpBcei1P15d/s/MUJwrlQApy6K7uWohBrnQa8+x9NxqrApDEjM4 Jd8OT8u0vZIV0B7X/9UJ7gTXxf4WQzthkAZrvoCm53ZraCGc1/Glhx2c28xp0n1JVKPA raDzzDT3HJHi3Aak1rZbZwskrYQWHIiOtRTcfB+Kky+cUdUhTRkNEfjtYRPd0FS2cWHA HXDIoN27kmksPCOLilmoqerqBfr6eQCMqRXCe43IpOozBYcJavGTNTp2RKoxWDQcOnPY imEAuJ3lV7gQN174Kc91qFUFJkoXGw910zSna4dx18g5dU9eup/SnI6ao18SAZRewqge J3Cw== X-Gm-Message-State: ACrzQf0iJSm/O5QzKaFY0517lvrxJ8Wc0sC+578N3CkpvJhxbjHwHWYZ DZLejBJY6RVBPo3H5LBamdo= X-Google-Smtp-Source: AMsMyM6rt81arGkuvkBRnwK5SKlkddEkAnGb9HVPWnhdl2eKfYnGeYKwMVoGMg/betzY8tCVGwgk0g== X-Received: by 2002:a17:90b:268a:b0:214:1648:6879 with SMTP id pl10-20020a17090b268a00b0021416486879mr2448280pjb.168.1668121810912; Thu, 10 Nov 2022 15:10:10 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id g5-20020aa79dc5000000b005613220346asm171285pfq.205.2022.11.10.15.10.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2022 15:10:10 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=casouri@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299529 Archived-At: > On Nov 10, 2022, at 2:49 PM, Stefan Monnier = wrote: >=20 >>> I haven't had a chance to try it out, but it looks good to me, tho >>> `beginning-of-defun-raw` doesn't mention anything about its return = value >>> in the its docstring, so we may want to tweak that docstring (and >>> review its code to make sure that it indeed returns the value we = need >>> in all cases, tho I suspect you've done so already). >>=20 >> (Sorry for the delay) Yes, it returns nil in all cases. Pretty sure = that=E2=80=99s >> the intent from the very beginning (looking at git logs). How about >> this patch? >=20 > LGTM, thank you! I pushed this to feature/tree-sitter. I looked at tests for = end-of-defun, the only one I found runs fine. I could add a test for = this change but I don=E2=80=99t know what we=E2=80=99ll test for. > PS: I'm very happy to work with you: I just babble about and you > go and do the grunt work. Half kidding, obviously, but really, > I appreciate it, thank you. >=20 Oh thank you! That made my day :-) Yuan=