unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
Subject: RE: Revamping sit-for
Date: Sat, 8 Jul 2006 08:41:57 -0700	[thread overview]
Message-ID: <EIENLHALHGIMHGDOLMIMKEHLCJAA.drew.adams@oracle.com> (raw)
In-Reply-To: <87u05spaq4.fsf@stupidchicken.com>

    > The doc string says, to me, that an existing call of (sit-for
    > 3 200), which previously simply waited 3.2 sec, with no
    > inhibition of display, will now be interpreted as a wait of
    > 3.0 sec, with inhibition of display. That's a
    > serious change in behavior.

      if (NILP (nodisp) && !NUMBERP (milliseconds))
        { /* New style.  */ nodisp = milliseconds;
          milliseconds = Qnil;}

    However, since the old form has been obsolete for a long time, and can
    cause confusion (as demonstrated), it might be good to simply drop it.

My argument, from the beginning, has been based on what "the doc string
says". You've already stated previously that the code does what you indicate
above. Your doc string, however, says something entirely different - it
suggests that existing code will not work, for the reasons I indicated.

There appear to be three possible issues at stake here:
1. Whether your change is a good one.
2. Whether it should be made now.
3. Whether the doc string accurately describes the change.

Others have spoken mainly to #2 (no). My point was that either the doc
string is inaccurate (#3) or the change is a bad one (#1). Your argument
supports #3: your doc string is inaccurate.

  parent reply	other threads:[~2006-07-08 15:41 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-01 23:55 [simon.marshall@misys.com: Lingering input pending with motif menu bar] Richard Stallman
2006-07-04  1:13 ` Chong Yidong
2006-07-04  9:08   ` Kim F. Storm
2006-07-04 13:45     ` Chong Yidong
2006-07-04 20:53       ` Richard Stallman
2006-07-04 21:21         ` [simon.marshall@misys.com: Lingering input pending with motifmenu bar] Drew Adams
2006-07-05 17:01           ` Richard Stallman
2006-07-05 20:48             ` [simon.marshall@misys.com: Lingering input pending withmotifmenu bar] Drew Adams
2006-07-07  4:14               ` Richard Stallman
2006-07-05 17:01           ` [simon.marshall@misys.com: Lingering input pending with motifmenu bar] Richard Stallman
2006-07-05  0:06         ` [simon.marshall@misys.com: Lingering input pending with motif menu bar] Chong Yidong
2006-07-05  9:04           ` Kim F. Storm
2006-07-04 17:03     ` [simon.marshall@misys.com: Lingering input pending with motifmenu bar] Drew Adams
2006-07-07 21:55 ` Revamping sit-for [Was: Lingering input pending with motif menu bar] Chong Yidong
2006-07-07 22:02   ` Revamping sit-for David Kastrup
2006-07-07 22:58   ` Revamping sit-for [Was: Lingering input pending with motif menu bar] Drew Adams
2006-07-08  1:39     ` Revamping sit-for Chong Yidong
2006-07-08  3:53       ` Drew Adams
2006-07-08 12:00         ` Chong Yidong
2006-07-08 12:36           ` David Kastrup
2006-07-08 12:56             ` Romain Francoise
2006-07-08 12:40           ` Stefan Monnier
2006-07-08 15:41           ` Drew Adams [this message]
2006-07-08 20:57           ` Richard Stallman
2006-07-08 15:31   ` Revamping sit-for [Was: Lingering input pending with motif menu bar] Richard Stallman
2006-07-08 22:49     ` Kim F. Storm
2006-07-09 19:03       ` Richard Stallman
2006-07-10 12:10         ` Kim F. Storm
2006-07-11  5:50           ` Richard Stallman
2006-07-08 23:02     ` Kim F. Storm
2006-07-10 19:47     ` Revamping sit-for Chong Yidong
2006-07-11  0:24       ` Chong Yidong
2006-07-11 18:16         ` Richard Stallman
2006-07-11 18:39           ` Kim F. Storm
2006-07-12 19:22             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EIENLHALHGIMHGDOLMIMKEHLCJAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).