From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: Possible bugs in (get last-command...) and (get this-command...) Date: Wed, 6 Sep 2006 12:13:19 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1157570062 18580 80.91.229.2 (6 Sep 2006 19:14:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 6 Sep 2006 19:14:22 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 06 21:14:20 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GL2q8-0000yV-7s for ged-emacs-devel@m.gmane.org; Wed, 06 Sep 2006 21:13:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GL2q7-0005q6-NF for ged-emacs-devel@m.gmane.org; Wed, 06 Sep 2006 15:13:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GL2pw-0005oi-M2 for emacs-devel@gnu.org; Wed, 06 Sep 2006 15:13:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GL2pv-0005o8-67 for emacs-devel@gnu.org; Wed, 06 Sep 2006 15:13:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GL2pv-0005o5-3r for emacs-devel@gnu.org; Wed, 06 Sep 2006 15:13:23 -0400 Original-Received: from [141.146.126.228] (helo=agminet01.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1GL2q8-0005Id-0T for emacs-devel@gnu.org; Wed, 06 Sep 2006 15:13:36 -0400 Original-Received: from rgmsgw02.us.oracle.com (rgmsgw02.us.oracle.com [138.1.186.52]) by agminet01.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k86JDLvX011730 for ; Wed, 6 Sep 2006 14:13:21 -0500 Original-Received: from dradamslap (dradams-lap.us.oracle.com [130.35.177.126]) by rgmsgw02.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with SMTP id k86JDKlg014786 for ; Wed, 6 Sep 2006 13:13:21 -0600 Original-To: X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1807 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59471 Archived-At: But some of the code does not. Perhaps someone knowledgeable might want to take a look. I noticed, for instance that novice.el and ido.el both have some unprotected occurrences of (get last-command...) or (get this-command...). It is safe in novice.el, because that will only get called when the command is a symbol and has the property. I will add a comment about that. Drew, would you like to find and check all the places which look at properties of last-command or this-command, and give us a list of the places that might be bugs? Sorry, I just don't have the time right now. If I get some time, I can try to do that next weekend. If I get to it before then, I'll let you know.