From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Treesit says grammar is unavailable when it Date: Sat, 16 Dec 2023 22:31:02 -0800 Message-ID: References: <1b24fc47-f792-415c-ac59-fcf3a2f5eeb9@gmail.com> <83r0jqs46e.fsf@gnu.org> <83r0jpqjd9.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gernotk@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 17 07:32:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEkh2-0009kn-9t for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Dec 2023 07:32:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEkgK-0006jA-HH; Sun, 17 Dec 2023 01:31:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEkgI-0006iw-Dy for emacs-devel@gnu.org; Sun, 17 Dec 2023 01:31:19 -0500 Original-Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEkgG-0003d8-RX; Sun, 17 Dec 2023 01:31:18 -0500 Original-Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3b86f3cdca0so1723780b6e.3; Sat, 16 Dec 2023 22:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702794675; x=1703399475; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PHlbAmMFpFbcgzxWLLwMrnQjw0Impyb+MqtqeYbzDME=; b=WnwljFN5FMitshXZTBoGNb78I/YZcHTfoM7j++M6dieqoEygbPd3DZwD76PVot2O21 C/rQ0i073jcPOMO4g9kAYa7Ah6KUxQrxnGr8UJvfqlXoEQJSgIsJMd8b7tMwaurTzC+m b+cD6zZ84iW9wcVSA9+uRQ8Fax9PBDrWD1hEh1tT0DMhR51ZROl0vvxZkVUMizntPyA/ c2bJbNqjEjtvsK6gSfdkixX83gpDywd4pzOpBwfTuSAImCIA7F1yxTFtxr3rjhT7aucr ZIMSQAjxj75jbgJMO1hJ0sHVeIzArYr7KG42IgJUVHWATNfjQ88BQ3ZP2J1A1vsDSieW 8K5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702794675; x=1703399475; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PHlbAmMFpFbcgzxWLLwMrnQjw0Impyb+MqtqeYbzDME=; b=lFdRXzXHh75CUyNcyppdTAbbhg0Ix4+VFw9fUvEfTN1/Gg3WwSxxKZJhZK9qWu3Ew6 3GmyxmAxttYXGH9IxaltAWjYWl0htnB6McDvugwJTCvAdmsOcIgQ7f0kCl2tdoxMHmiD 7svjwMEsKuvcP+4qzO915k/+62bMSfBgKa3a1+ZH6oO4mftics0wQhIyI5OKLtEzZcXl lUFj3oOs+XQfJ6jVUn35UljteVe0vNqDsH88CHbHRw93ryyVCOCHln/vpihAzw7UQC4v KO0h/TG/FOznbyq6DzEK8MCnYZqaAuSjRWyDdCUvZdW1BpFpIfIxkGRsR7aBZn9jp77y JLYA== X-Gm-Message-State: AOJu0Yxr1TND0yItUlDsLVhdyT9Zu21NlpQWEJX+eCMos9SFevNceOyo qurM7Ky7gEFTkF5WP/6nCjlCpW9Eufgnhg== X-Google-Smtp-Source: AGHT+IHza/cNrFYSvejL2WSCxK1yWxroY3dt38zV1Tbg3+qSHOKXCdbrYAHkIsCHgE02ly2zUsGV2Q== X-Received: by 2002:a05:6808:159d:b0:3b8:5c24:80da with SMTP id t29-20020a056808159d00b003b85c2480damr18266843oiw.58.1702794675020; Sat, 16 Dec 2023 22:31:15 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id t44-20020aa78fac000000b006d3497d0089sm1932181pfs.105.2023.12.16.22.31.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Dec 2023 22:31:14 -0800 (PST) In-Reply-To: <83r0jpqjd9.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=casouri@gmail.com; helo=mail-oi1-x22c.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313900 Archived-At: > On Dec 14, 2023, at 12:27 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 14 Dec 2023 00:14:01 -0800 >> Cc: gernotk@gmail.com, >> emacs-devel@gnu.org >>=20 >>>> Thanks for sharing this! Eli, this sort of thing might be good = reasons=20 >>>> to also print the error message from ldopen, rather than simply = saying=20 >>>> not found? >>>=20 >>> I don't mind, but IME relying too much on these error messages is = not >>> always a good idea, since sometimes they are too generic and say >>> nothing except "this failed". But if it will help in some cases, >>> let's do it. >>>=20 >>> However, I would like to see the patch, since we seem to be = signaling >>> an error already, and the error includes the error message from >>> dynlib_open? So what am I missing? >>=20 >> We were showing error messages from dlopen, and then removed them for = brevity, see e8df6c311fcf59bf23d31b9db2bb8fec9d78fbe7 >=20 > If these messages are useful, we can revert that commit. I forgot to ask, should this be on emacs-29 or master? >=20 >> Maybe we can fold the extra error messages by default? >=20 > I'm not sure I understand the details, but the idea is certainly okay. I=E2=80=99m thinking about applying text property to the extra messages = so they appear as =E2=80=9C=E2=80=A6=E2=80=9D, and is expanded when = clicked (or hit enter), like what we have for printing large objects in = the scratch buffer. Yuan=