From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: emacs-29 ec4d29c4494: Improve performance of treesit_cursor_helper_1 Date: Thu, 31 Aug 2023 19:07:07 -0700 Message-ID: References: <169345586442.5629.18133276907856406640@vcs2.savannah.gnu.org> <20230831042424.B51E5C038B5@vcs2.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, emacs-diffs@gnu.org To: Corwin Brust Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Fri Sep 01 04:07:48 2023 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbtZc-0009hp-2C for gnu-emacs-diffs@m.gmane-mx.org; Fri, 01 Sep 2023 04:07:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbtZG-0003FI-4s; Thu, 31 Aug 2023 22:07:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbtZD-0003EU-VD; Thu, 31 Aug 2023 22:07:23 -0400 Original-Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbtZB-0006v9-Nl; Thu, 31 Aug 2023 22:07:23 -0400 Original-Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-26fc9e49859so1118032a91.0; Thu, 31 Aug 2023 19:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693534040; x=1694138840; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rgssHSx6DL7ZB8TYYYoccSimzdNru5ZZ9Mv1r5+pKqI=; b=CO0DN9cvyhSaz2Epfabz1cqCNKvBh0WfMEleCvaKD3dSgQel8FJFgKH2YrVTIkwdyF TatBkeVSgDSk+MbFJOkvG9ZQaGzIT1S0UsPrEn5ANM9+4FgeA33p/0T8J6Fmj9imF3qd zvi9tDHYrr21msiemm4B0iSXdjMJV9EPPZ2AWSqJ0vHUKShWDgCD6CPPGNrPdWMZhv5f 5MvqIn2updhaGVuNBLIyfit9gCfVgaAI3e/4AYg1NZugBhGWAlDEZpKzUSC850tSxz9d oDQeCo315/Ie6sTWi4OhEMGHLZUKCLsSDcHBKCMcwvaJSDYqES2MxOD3/hn4rZI0Nmw0 XE/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693534040; x=1694138840; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rgssHSx6DL7ZB8TYYYoccSimzdNru5ZZ9Mv1r5+pKqI=; b=F1JpLgbD9El+js6g5Z7HNrdvcBaFYGFP/I+8sBdHIVh9pkBZukXGTbMNvOVYIJauLn XmCdneuOhxZ1oq/5nPVV7d21cEUiG7hs7bQQaeM7F7SIYGU1BaXzERKfP9JePa2gqKuL 0VScpaRTkYj8Hot4bovrE24OIESfLeYl/bfiQJnYEqgIBNxxwRVQ5zMG8dfw/UsjJOc8 /abW3liRTLJGMPAId7/NatOyBG6d6o3IMo5uHtbViNzIS6wqEzZxRIjCMw4zFmV81RmG Px1fyX6x1US3cn+kJVl7WqnOvMa/xQJXgQUU6QejQRA1XU/MnTRtZwjhzNNu2Yabc6pR ZqKQ== X-Gm-Message-State: AOJu0YxvmQF+aOPGDfaM6FR23Cp2LYMtH2G3LV6f9VUlvK2lO4qzvFIa 9ehLjCz9reyKIfqhMk7GxnM= X-Google-Smtp-Source: AGHT+IEHmuKmaUHxP77ILKWHeMq92Qstlq9YJwimgct6ECWWSRC8WmlIvd2Q3B5i+M/Tmrx2xY9W+A== X-Received: by 2002:a17:90b:1e04:b0:26b:56fa:87d3 with SMTP id pg4-20020a17090b1e0400b0026b56fa87d3mr1048329pjb.31.1693534039557; Thu, 31 Aug 2023 19:07:19 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y11-20020a1709027c8b00b00198d7b52eefsm1829311pll.257.2023.08.31.19.07.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Aug 2023 19:07:19 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=casouri@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Original-Sender: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.diffs:186912 gmane.emacs.devel:309714 Archived-At: > On Aug 31, 2023, at 2:23 PM, Corwin Brust wrote: >=20 > On Wed, Aug 30, 2023 at 11:24=E2=80=AFPM Yuan Fu = wrote: >>=20 >> branch: emacs-29 >> commit ec4d29c4494f32acf0ff7c5632a1d951d957f084 >> Author: Yuan Fu >> Commit: Yuan Fu >>=20 >> Improve performance of treesit_cursor_helper_1 >>=20 >> * src/treesit.c: (treesit_cursor_helper_1): Use >=20 >> - if (!ts_tree_cursor_goto_first_child (cursor)) >> + if (ts_tree_cursor_goto_first_child_for_byte (cursor, start_pos) = =3D=3D -1) >=20 > Hi Yuan, >=20 > I think this commit may have broken things for the Windows port. >=20 > Running configure I now get: >=20 > = C:/msys2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_= 64-w64-mingw32/bin/ld.exe: > treesit.o:treesit.c:(.text+0xce2): undefined reference to > `ts_tree_cursor_goto_first_child_for_byte' >=20 > Interestingly, it does seem to exist in > mingw32/mingw-w64-i686-tree-sitter 0.20.6-1 (current, according to > pacman -Ss tree-sitter): >=20 > Function Name Address Relative Address Ordinal Filename Full Path Type > ts_tree_cursor_goto_first_child_for_byte 0x00000002c62ef550 0x0001f550 > 179 (0xb3) libtree-sitter.dll C:\msys2\mingw64\bin\libtree-sitter.dll > Exported Function >=20 > I've attached the complete log, here's my configure command. which > followed a git clean -xf && ./autogen.sh: >=20 > ./configure --enable-checking=3D'yes,glyphs' > --enable-check-lisp-object-type --with-modules --without-dbus > --with-native-compilation=3Daot --without-compress-install > --with-tree-sitter CFLAGS=3D'-O0 -g3' | tee /g/quick.log > I forgot to add window boilerplate for tree-sitter functions again. I = pushed a fix to emacs-29. I=E2=80=99m very sorry :-( Yuan=