From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481) Date: Wed, 18 May 2022 16:40:39 +0200 Message-ID: References: <165286472597.14890.11407291537527786185@vcs2.savannah.gnu.org> <20220518090526.4AA10C009A8@vcs2.savannah.gnu.org> <87y1yzkvvu.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 16:41:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrKs0-0008eO-OI for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 16:41:48 +0200 Original-Received: from localhost ([::1]:52208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrKrz-0001Wx-MW for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 10:41:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrKr2-0000h0-So for emacs-devel@gnu.org; Wed, 18 May 2022 10:40:48 -0400 Original-Received: from mail1461c50.megamailservers.eu ([91.136.14.61]:47620 helo=mail267c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrKr0-0006Ph-D8 for emacs-devel@gnu.org; Wed, 18 May 2022 10:40:48 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1652884842; bh=dgMvPkO9xwy26CjMvsu3zwtaGWGOpHc/S7kGPDjz/aA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=kwTyqWzmiMPCnSG4Y1dlEzOx58vx2fxUptB700XvnFZA5QAA26LEx8r7jw6Wm3Ss4 Szwyf/G5Q1T//PbgEtiZpygbMAAtfHAR+DX/ufWha4zVUolver6NbACi6YFwz1V0MO mtH/RN/0vL0kR7BGWBRcz5xm0TuXjTUPGD1H9KmI= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24IEeeOE017745; Wed, 18 May 2022 14:40:41 +0000 In-Reply-To: <87y1yzkvvu.fsf@yahoo.com> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F2A.6285056A.0026, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.61; envelope-from=mattiase@acm.org; helo=mail267c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289922 Archived-At: 18 maj 2022 kl. 11.55 skrev Po Lu : > I think our coding style is to put the opening brace of > structs, enums and unions on column 1 I wasn't sure and there appeared to be considerable variation in the = existing source (almost 300 cases of bracket on the same line, against = 500-something with the bracket on a separate line), so I went with the = former since it is more economic in vertical space without worsening = readability. Naturally I'll change if that is important, but then there's a lot of = code to change, and apparently there is no clear consensus among = previous authors.