From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 64e25cd: More robust NS hex colour string parsing Date: Sat, 13 Jun 2020 17:39:29 +0200 Message-ID: References: <20200608120746.30163.87810@vcs0.savannah.gnu.org> <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org> <83r1uk429y.fsf@gnu.org> <3C92A091-F389-4179-B2F0-B3AA5ABD6CCE@acm.org> <83pna43xrl.fsf@gnu.org> <9259B4A6-F3CC-4243-9F08-2882993C9B2C@acm.org> <83a71741mr.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 17:40:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jk8Gj-000NXX-IE for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 17:40:29 +0200 Original-Received: from localhost ([::1]:51006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk8Gi-0007w7-Hs for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 11:40:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk8Fx-0007J8-VH for emacs-devel@gnu.org; Sat, 13 Jun 2020 11:39:42 -0400 Original-Received: from mail1445c50.megamailservers.eu ([91.136.14.45]:56432 helo=mail265c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk8Fv-0006ES-M5; Sat, 13 Jun 2020 11:39:41 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1592062772; bh=cVoAAXQyvCHR6s6o29JM6gnPzTRfCbyBNpT3nIihQoE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=s+f1IZvJY5yTJ1f2mwKinfgj77i7xnxtFPxnLovWXjczo+/LTKp1g8cODh/YeUkzQ ab6qUEds9tGo75hgEYO6mDUGdfouFE7itTEAaTGmZUlcnutHySv2E3cZY05FSjDO8o 3QJTvmsazaOCtFPgncWewDSctWepFJlNp2FW6dzc= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05DFdUwX026576; Sat, 13 Jun 2020 15:39:31 +0000 In-Reply-To: <83a71741mr.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F1C.5EE4F2DB.007D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=D5w51cZj c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=gX5H0zdzC1EMi6BCpB4A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 Received-SPF: softfail client-ip=91.136.14.45; envelope-from=mattiase@acm.org; helo=mail265c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/13 11:39:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252179 Archived-At: 13 juni 2020 kl. 13.59 skrev Eli Zaretskii : >> except the low bits in some cases on Windows (try "#123") >=20 > I don't think I understand what I should try; please elaborate. Try (color-values "#123"). The correct result is (#x1111 #x2222 #x3333). If you get something else on Windows, then that is a bug fixed by the = patch. If the patch doesn't help, then it may be a bug in the patch. Note that the Windows backend will still discard the low 8 bits in any = case; (color-values "#123456789abc") will probably return (#x1212 #x5656 = #x9a9a). The patch doesn't change that. >> Malformed arguments are now consistently rejected. >=20 > How exactly are they rejected? In the same way that detected errors were rejected before: as if given = an undefined colour such as "fuchsia green". > I see the return value of > parse_color_spec, but what happens in its callers, and what happens on > the Lisp levels when those callers are called? None of that has changed. >> Not sure what you mean here. Mind giving a concrete example? >=20 > The first two branches of the 'cond' would always return a list before > your changes, but after your changes they could return nil if > color-values-from-numeric-string (not the best name, btw) returns nil > and the input is of one of the two forms parsed by those two branches. This is still a tad vague and speculative. Can you give a concrete = example of an argument that, in your opinion, isn't handled correctly? As far as I can tell, well-formed arguments yield correct values and = others are rejected in the same way as before, although error-checking = now is less spotty. I don't particularly like that function name either. What about one of = these: parse-color parse-color-spec parse-color-string color-values-from-spec color-from-string-spec color-spec-to-values Xlib uses the term 'numerical colour specification', but = color-values-from-numerical-color-specification is a mouthful even in = Lisp.