From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Renaming eglot -- or at least add an alias? Date: Wed, 12 Oct 2022 15:58:25 -0700 Message-ID: References: <83pmfdduix.fsf@gnu.org> <86wn9ji3ma.fsf@gmail.com> <86tu4lsnqk.fsf@gmail.com> <8335c0p2fn.fsf@gnu.org> <83leproov6.fsf@gnu.org> <83fsfzonwn.fsf@gnu.org> <5a1e604c-4500-a476-da3d-259d9057a7f0@yandex.ru> <838rlromxu.fsf@gnu.org> <83h70dk3wf.fsf@gnu.org> <83fsfxk30x.fsf@gnu.org> <83r0zdd1cy.fsf@gnu.org> <5746b7e8-75ab-a12f-54b4-308c3ffc5b59@yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Richard Stallman , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 13 01:01:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oikii-0006w2-2Q for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 01:01:00 +0200 Original-Received: from localhost ([::1]:38830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oikig-0004U3-Gy for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 19:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oikgX-00033y-FY for emacs-devel@gnu.org; Wed, 12 Oct 2022 18:58:45 -0400 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:46903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oikgI-0000YP-If; Wed, 12 Oct 2022 18:58:35 -0400 Original-Received: by mail-pg1-x52f.google.com with SMTP id 78so28089pgb.13; Wed, 12 Oct 2022 15:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qs+jC1sZ8vN7aWb9dK/UH0N0WSTyOAV4g+JXJp07Gqo=; b=G06jnoOdx+zBOgpbRXGmE2lpJpk3fxafHetR+lxo2UOI1YnZnjMtdKTankWyq1lyHp u8Uv9/ydEK/qQHaLyA5Hir2J5TlHWpdN0PkKG5Dwsg86AkUdmDsuehWgQjXFjNrKm/es 2FT4blCKA5auHZ1tvIv6eIOdy9YvvievIVB3kgh6ekY+Jnl6GCJXy2OT02fo4hIq7QPJ Eu9NqUu5GNl6iuZ23WXBUlfBzIce83D0hGIahp/I0b2KA2VTGcCfquFvDoaXae4nxLM8 K4A1D11E1nx8VVdS4fxlTVwebJ2RFt3KItvgbmjuRuuV5jSme9cWDz/SnIPjA7pboY7n nnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qs+jC1sZ8vN7aWb9dK/UH0N0WSTyOAV4g+JXJp07Gqo=; b=q3jmJ2xFp7BPpBisZLofdAs09yFocauszloJAmlE5o31UgyYE1OsB61x6osKj9inhM rvoh26E6thyS99TUD3zzN+4DOB+UEoCUrOgKc4ZkvEia9Hcnefqf73qxY7OXRrrEQq37 0Q+7b6QMMiAjJ4bm9ut+cLsEV50qYAh+43HvmFxaUOVc0nThIXJmj3JfF29p/MJMQsMk 0h7+vInG4aBDSlwwoY3piMXC9SJ+9C/S71DXp8juxsKA9Fv+drZZY3fKmUPD2prUYQ+Z 7m8/BEOmKcDOt7xbBDK7DIO1qPpVOsXxN+Rl4xoQuvwgcgEKLu1ena/zUYyo7o6np9zn YVsQ== X-Gm-Message-State: ACrzQf3qBc3HKOTloeEjIFC3Cn6Ae1nKAXljbGrlgdE8f08KRNoT5FIY rRQcPbzceL1eXDCTpbi9N2U= X-Google-Smtp-Source: AMsMyM65DHEMA9juF+E1GphxXsQtBJ/jPEeIay3abqBNV/BQ7I7vtj4e9w8bc6Hfyft0F6YTv+dANw== X-Received: by 2002:a05:6a00:1a94:b0:548:8ce8:db93 with SMTP id e20-20020a056a001a9400b005488ce8db93mr33146873pfv.13.1665615508275; Wed, 12 Oct 2022 15:58:28 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id r3-20020aa79623000000b0055b674dd134sm416523pfg.29.2022.10.12.15.58.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2022 15:58:27 -0700 (PDT) In-Reply-To: <5746b7e8-75ab-a12f-54b4-308c3ffc5b59@yandex.ru> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=casouri@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297639 Archived-At: > On Oct 12, 2022, at 3:50 AM, Dmitry Gutov wrote: >=20 > On 12.10.2022 09:37, Yuan Fu wrote: >> If the user enables eglot, eglot sets menu-create-index-function to = eglot-imenu, overriding major mode=E2=80=99s function. >=20 > I suppose it does override that, but are you sure it's always a good = idea? >=20 > Are Imenu indexes produced by Eglot really better than what we can do = with TreeSitter? I have to way to tell, but surely not worse, since a LSP server knows = everything tree-sitter knows and more. >=20 > IME it doesn't usually need project-wide information, since the menu = is local to the current file. Some language servers could be smarter in = the way that they recognize some framework-based patterns, which aren't = inherent in the language. But the major modes can do that too. Yeah, I think either one should be fine. Eglot saves work for major mode = developers, and tree-sitter gives major mode developer and users more = option and flexibility, since they need to implement the imenu function. Yuan=