From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: last_marked array is now ifdef'ed away Date: Sun, 15 Sep 2024 15:58:03 +0200 Message-ID: References: <86zfokyp64.fsf@gnu.org> <86ed5pkz53.fsf@gnu.org> <851C7C12-44A1-4661-9EA7-16B0B7209D11@gmail.com> <86a5gbk295.fsf@gnu.org> <8634m2f8ii.fsf@gnu.org> <86o74pea7k.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 15 15:58:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sppm5-00059I-4t for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Sep 2024 15:58:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spplT-0006ss-4g; Sun, 15 Sep 2024 09:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spplR-0006sR-E3 for emacs-devel@gnu.org; Sun, 15 Sep 2024 09:58:09 -0400 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spplP-0003eL-Vy; Sun, 15 Sep 2024 09:58:09 -0400 Original-Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2f74e468baeso27286711fa.2; Sun, 15 Sep 2024 06:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726408685; x=1727013485; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=w43Jdwq/gaiwQ9gBcyRrIpJT6N4u6emwRNyqzo8yh/k=; b=H//vT3L+4vcJOa5HYAApUbkvsNqsgdiLxwen1eRHgyYGwb4IuLC4fFLqa0Rj25PkIJ MfRdeHogfKlAgPGFPawwVdDhVyVpuN2ioMIlJUZ6QM5HvGcu51WQd8Lvl99mFibNN2TB fJp6T8644wcIA5RMU6wmdnCLYzRUPFnoMVswhipfR5K0CWnG/A5XeT5tgE7ze/Xiw1aO 6zBCa38GV8/zOrRK+KP6nCf2is31mbJ9Rw2GJmhaqIv3PWyGOujgcJrqhDtcg8aYH6FK /AQYT3je+FU0FQY/ntwB821fnn3PGkgesbKJko+6fGiIQwBdWDt2QIwEJaWA93sSFVQq FD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726408685; x=1727013485; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=w43Jdwq/gaiwQ9gBcyRrIpJT6N4u6emwRNyqzo8yh/k=; b=wr2mqKWhQGgHySORwQC1es97Xay7AcDnpRDMeupT0nhJnHoBYNtHEp4HOzqln4u7l0 D9Rjs06gyQNKZgrRRgINkkL1EnfHA2b6U9KOmI78+7CesbYDx1fFO3fDs2Bi1GSrFhxR IOm1drRlhui21p9UFFSNGfD3smPaE/cYXVHqhDeDcO068Zvt161cXv8tNoPMwYh2eySk LkTsAaJr2PP5u2cQjgczBYRIOqH+tqjgqoKRCimJBO37Po0bKGu0VyUu1ov6FheZAfti 3LQtOH4L1djWrv8LhmP0awX8uX3Nyrkq69d7rYETewPbthjNVv9pbYJ7zgS5BfjAlf55 V+lA== X-Gm-Message-State: AOJu0YwwV4lnZMyu7kReiatNJVqORh+4NSwyqWF+MGunQUTuNksYjfXQ rod9+nSesFwZUV0zy56INZIGG0m7n79qaDWgfIOFFF5vHw38bLK5kJnsNw== X-Google-Smtp-Source: AGHT+IF09As3EYpj84Z3/WNfpB2apRsVJxarobRrhNYGeLVVOlbzqxNXQFS3k1dDvsmv1x31lgtuIA== X-Received: by 2002:a05:6512:2803:b0:533:d3e:16fe with SMTP id 2adb3069b0e04-5367ff24b72mr4614737e87.38.1726408684818; Sun, 15 Sep 2024 06:58:04 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53687047009sm566352e87.39.2024.09.15.06.58.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Sep 2024 06:58:04 -0700 (PDT) In-Reply-To: <86o74pea7k.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323635 Archived-At: 15 sep. 2024 kl. 07.51 skrev Eli Zaretskii : > I'd need to see actual evidence for a shorter array, based on actual > GC run of some data structure. And I'd need to see actual evidence for a longer array, based on actual = debugging cases. But perhaps there is a way for both of us to be just slightly = disappointed: what about gating the check with a flag? That way, the = trace buffer is always compiled-in. It needs to be enabled by the user = but that is straightforward and can be done on the command line, in = Lisp, or in a debugger. As expected the runtime cost is not quite as bad as keeping it on all = the time =E2=80=93 the branch is always correctly predicted =E2=80=93 = although still slower than I'd like, but it's the best I can do for now. There is then no need to skimp on the trace buffer size since it only = matters when actually enabled. (We could even make it dynamic, so you'd = set it to a megabyte if the situation calls for that.) And I have a patch ready.