From: Will Farrington <wcfarrington@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: comment-dwim has no behavior to comment out the current line without a region
Date: Tue, 9 Dec 2008 15:03:16 -0500 [thread overview]
Message-ID: <E3365B8E-876F-48B7-AC14-8CB523A83FF7@gmail.com> (raw)
In-Reply-To: <jwvzlj5w2t5.fsf-monnier+emacs@gnu.org>
On Dec 9, 2008, at 2:48 PM, Stefan Monnier wrote:
>> Generally speaking, what makes BOL a "common starting point" to
>> perform
>> comment-indent more-so than any other part of the line?
>
> I'm not sure it's much more so, but it's at least as common as
> current-indentation, end of line, etc...
Any given place in the line, or end of line, does not have the same
semantic
ambiguity around what behavior should be when dealing with comment-dwim.
BOL and possibly current-indentation are the only logical places where
one
could expect comment-dwim (which should do what you mean) to comment
out the current line.
>> Additionally, is not BOL semantically the clearest place to run
>> comment-dwim
>> and expect it to comment out a given line rather than having it run
>> comment-indent?
>
> Could be. I'm not saying your idea isn't good. I'm just saying
> that it
> is not compatible with the current behavior and that the current
> behavior makes sense as well. You may find some other way to combine
> comment-indent, comment-kill, and comment-region onto a single key.
> E.g. M-; M-; is currently unused.
It's an incompatible change, yes.
But it's also an attempt to remove some ambiguity from comment-dwim
(which isn't doing what I mean). If the command is meant to "do what I
mean", then for it not to have any method of commenting out the current
line in a single keystroke is, I think, a flaw. It doesn't necessarily
have to
be my implementation, but given that commenting out a whole line is a
very
common task, comment-dwim should support some manner of doing this
in a single keystroke, in my opinion.
next prev parent reply other threads:[~2008-12-09 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 6:06 comment-dwim has no behavior to comment out the current line without a region Will Farrington
2008-12-09 8:28 ` Will Farrington
2008-12-09 9:22 ` Will Farrington
2008-12-09 12:40 ` Eli Zaretskii
2008-12-09 18:27 ` Stefan Monnier
2008-12-09 22:54 ` Eli Zaretskii
2008-12-09 18:40 ` Stefan Monnier
2008-12-09 18:50 ` Will Farrington
2008-12-09 19:48 ` Stefan Monnier
2008-12-09 20:03 ` Will Farrington [this message]
2008-12-10 12:22 ` Will Farrington
2008-12-11 15:27 ` Stefan Monnier
2008-12-11 18:26 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3365B8E-876F-48B7-AC14-8CB523A83FF7@gmail.com \
--to=wcfarrington@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).