From: "Mattias Engdegård" <mattiase@acm.org>
To: Alan Third <alan@idiocy.org>
Cc: Po Lu <luangruo@yahoo.com>, Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: Emacs macOS build warnings
Date: Sun, 6 Feb 2022 17:14:07 +0100 [thread overview]
Message-ID: <E32BF938-3273-416B-8D81-E4CF4B2C8284@acm.org> (raw)
In-Reply-To: <Yf/wmq6M1C344iW4@idiocy.org>
6 feb. 2022 kl. 17.00 skrev Alan Third <alan@idiocy.org>:
> On the latest macOS I believe vfork now does the same thing as fork,
> so it might be easiest to detect the OS version and unset HAVE_VFORK,
> although since we don't seem to actually check for that directly in
> configure.ac I guess it's perhaps a standard test in autoconfig which
> may make it hard to over-ride?
In the version I am using (11.6.3), which is also the most recently supported for my machine, vfork is measurably faster than fork so it isn't an alias yet. In other words, unsetting HAVE_VFORK would lead to a performance regression.
> The alternative approach is to look at whether we should be using
> posix_spawn here. I was under the impression that we had already
> switched to using posix_spawn, at least on macOS, so I guess these
> calls to vfork were missed.
The idea is to use posix_spawn when possible; according to comments in the code, that function cannot be used in some circumstances such as when we need to use PTYs instead of pipes. I haven't verified whether this is actually true.
I'm sure you are happy to hear that dropping fork/exec is high on my list of things to discuss with Ken and Dennis when I finally get my time machine working.
>> I treated CTGetCoreTextVersion warning by following the direction in
>> the deprecation message and used NSProcesInfo instead, and it seems
>> to work although it's a bit clumsy. Is there a better way?
>
> I think your fix for this is good and probably the right thing to do.
Thank you, I shall commit it as a separate change then.
next prev parent reply other threads:[~2022-02-06 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <968F1C8D-123F-4692-B035-C999767CC45C@acm.org>
2022-02-06 16:00 ` Emacs macOS build warnings Alan Third
2022-02-06 16:14 ` Mattias Engdegård [this message]
2022-02-10 21:33 ` Alan Third
2022-02-10 22:16 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E32BF938-3273-416B-8D81-E4CF4B2C8284@acm.org \
--to=mattiase@acm.org \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).