Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Andrea Corallo]

Pip Cet via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: scratch/igc
> commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
> Author: Pip Cet <pipcet@protonmail.com>
> Commit: Pip Cet <pipcet@protonmail.com>
>
>     Fix GTK-related MPS crashes
>
>     * src/gtkutil.c (free_glib_user_data): New function.
>     (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>     (qttip_cb, xg_create_frame_widgets)
>     (xg_create_frame_outer_widgets, create_dialog)
>     (make_cl_data, unref_cl_data, xg_mark_data)
>     (menuitem_highlight_callback, xg_create_one_menuitem)
>     (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>     (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>     (xg_im_context_commit, xg_widget_style_updated)
>     (tb_size_cb): Adjust to use `get_glib_user_data' and
>     `g_signal_connect_data'.
>     (xg_initialize): Remove linked list if HAVE_MPS.
>     * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>     functions.
>     * src/xmenu.c (menubar_selection_callback)
>     (popup_selection_callback): Adjust to use `get_glib_user_data'.

Hello,

as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
following on my system:

  CC       gtkutil.o
gtkutil.c: In function ‘qttip_cb’:
gtkutil.c:902:30: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
  902 |                              G_CONNECT_DEFAULT);
      |                              ^~~~~~~~~~~~~~~~~
gtkutil.c:902:30: note: each undeclared identifier is reported only once for each function it appears in
gtkutil.c: In function ‘xg_create_frame_widgets’:
gtkutil.c:1579:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 1579 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘create_dialog’:
gtkutil.c:2406:36: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 2406 |                                    G_CONNECT_DEFAULT);
      |                                    ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_create_one_menuitem’:
gtkutil.c:3336:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 3336 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘create_menus’:
gtkutil.c:3455:30: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 3455 |                              G_CONNECT_DEFAULT);
      |                              ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_update_menu_item’:
gtkutil.c:3931:40: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 3931 |                                        G_CONNECT_DEFAULT);
      |                                        ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_update_frame_menubar’:
gtkutil.c:4211:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 4211 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_print_frames_dialog’:
gtkutil.c:5317:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 5317 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~
gtkutil.c: In function ‘xg_create_tool_bar’:
gtkutil.c:5595:26: error: ‘G_CONNECT_DEFAULT’ undeclared (first use in this function)
 5595 |                          G_CONNECT_DEFAULT);
      |                          ^~~~~~~~~~~~~~~~~

Thanks

  Andrea

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Pip Cet]

On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo <acorallo@gnu.org> wrote:
> Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
> 
> > branch: scratch/igc
> > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
> > Author: Pip Cet pipcet@protonmail.com
> > Commit: Pip Cet pipcet@protonmail.com
> > 
> > Fix GTK-related MPS crashes
> > 
> > * src/gtkutil.c (free_glib_user_data): New function.
> > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
> > (qttip_cb, xg_create_frame_widgets)
> > (xg_create_frame_outer_widgets, create_dialog)
> > (make_cl_data, unref_cl_data, xg_mark_data)
> > (menuitem_highlight_callback, xg_create_one_menuitem)
> > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
> > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
> > (xg_im_context_commit, xg_widget_style_updated)
> > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
> > (xg_initialize): Remove linked list if HAVE_MPS.
> > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
> > functions.
> > * src/xmenu.c (menubar_selection_callback)
> > (popup_selection_callback): Adjust to use `get_glib_user_data'.
> 
> Hello,
> 
> as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
> G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
> following on my system:

Thank you! Can you let me know which gtk/glib version that is? I'd like to check the source code to make sure we can pass the right flag instead.

I think we're okay just passing 0 instead.

Pip

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Andrea Corallo]

Pip Cet <pipcet@protonmail.com> writes:

> On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo <acorallo@gnu.org> wrote:
>> Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
>>
>> > branch: scratch/igc
>> > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
>> > Author: Pip Cet pipcet@protonmail.com
>> > Commit: Pip Cet pipcet@protonmail.com
>> >
>> > Fix GTK-related MPS crashes
>> >
>> > * src/gtkutil.c (free_glib_user_data): New function.
>> > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>> > (qttip_cb, xg_create_frame_widgets)
>> > (xg_create_frame_outer_widgets, create_dialog)
>> > (make_cl_data, unref_cl_data, xg_mark_data)
>> > (menuitem_highlight_callback, xg_create_one_menuitem)
>> > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>> > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>> > (xg_im_context_commit, xg_widget_style_updated)
>> > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
>> > (xg_initialize): Remove linked list if HAVE_MPS.
>> > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>> > functions.
>> > * src/xmenu.c (menubar_selection_callback)
>> > (popup_selection_callback): Adjust to use `get_glib_user_data'.
>>
>> Hello,
>>
>> as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
>> G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
>> following on my system:
>
> Thank you! Can you let me know which gtk/glib version that is? I'd like to check the source code to make sure we can pass the right flag instead.
>
> I think we're okay just passing 0 instead.
>
> Pip

Should be GTK 3.24.33 and glib 2.0.

Thanks

  Andrea

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Po Lu]

Andrea Corallo <acorallo@gnu.org> writes:

> Pip Cet <pipcet@protonmail.com> writes:
>
>> On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo <acorallo@gnu.org> wrote:
>>> Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
>>>
>>> > branch: scratch/igc
>>> > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
>>> > Author: Pip Cet pipcet@protonmail.com
>>> > Commit: Pip Cet pipcet@protonmail.com
>>> >
>>> > Fix GTK-related MPS crashes
>>> >
>>> > * src/gtkutil.c (free_glib_user_data): New function.
>>> > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>>> > (qttip_cb, xg_create_frame_widgets)
>>> > (xg_create_frame_outer_widgets, create_dialog)
>>> > (make_cl_data, unref_cl_data, xg_mark_data)
>>> > (menuitem_highlight_callback, xg_create_one_menuitem)
>>> > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>>> > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>>> > (xg_im_context_commit, xg_widget_style_updated)
>>> > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
>>> > (xg_initialize): Remove linked list if HAVE_MPS.
>>> > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>>> > functions.
>>> > * src/xmenu.c (menubar_selection_callback)
>>> > (popup_selection_callback): Adjust to use `get_glib_user_data'.
>>>
>>> Hello,
>>>
>>> as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
>>> G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
>>> following on my system:
>>
>> Thank you! Can you let me know which gtk/glib version that is? I'd
>> like to check the source code to make sure we can pass the right
>> flag instead.
>>
>> I think we're okay just passing 0 instead.
>>
>> Pip
>
> Should be GTK 3.24.33 and glib 2.0.

Passing 0 is correct.

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Pip Cet]

On Tuesday, July 9th, 2024 at 14:16, Po Lu <luangruo@yahoo.com> wrote:
> Andrea Corallo acorallo@gnu.org writes:
> > Pip Cet pipcet@protonmail.com writes:
> > 
> > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org wrote:
> > > 
> > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
> > > > 
> > > > > branch: scratch/igc
> > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
> > > > > Author: Pip Cet pipcet@protonmail.com
> > > > > Commit: Pip Cet pipcet@protonmail.com
> > > > > 
> > > > > Fix GTK-related MPS crashes
> > > > > 
> > > > > * src/gtkutil.c (free_glib_user_data): New function.
> > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
> > > > > (qttip_cb, xg_create_frame_widgets)
> > > > > (xg_create_frame_outer_widgets, create_dialog)
> > > > > (make_cl_data, unref_cl_data, xg_mark_data)
> > > > > (menuitem_highlight_callback, xg_create_one_menuitem)
> > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
> > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
> > > > > (xg_im_context_commit, xg_widget_style_updated)
> > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
> > > > > (xg_initialize): Remove linked list if HAVE_MPS.
> > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
> > > > > functions.
> > > > > * src/xmenu.c (menubar_selection_callback)
> > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'.
> > > > 
> > > > Hello,
> > > > 
> > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
> > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
> > > > following on my system:
> > > 
> > > Thank you! Can you let me know which gtk/glib version that is? I'd
> > > like to check the source code to make sure we can pass the right
> > > flag instead.
> > > 
> > > I think we're okay just passing 0 instead.
> > > 
> > > Pip
> > 
> > Should be GTK 3.24.33 and glib 2.0.
> 
> 
> Passing 0 is correct.

Thank you both, just pushed a fix. Please let me know if it isn't working.

Pip

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Andrea Corallo]

Pip Cet <pipcet@protonmail.com> writes:

> On Tuesday, July 9th, 2024 at 14:16, Po Lu <luangruo@yahoo.com> wrote:
>> Andrea Corallo acorallo@gnu.org writes:
>> > Pip Cet pipcet@protonmail.com writes:
>> > 
>> > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org wrote:
>> > > 
>> > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
>> > > > 
>> > > > > branch: scratch/igc
>> > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
>> > > > > Author: Pip Cet pipcet@protonmail.com
>> > > > > Commit: Pip Cet pipcet@protonmail.com
>> > > > > 
>> > > > > Fix GTK-related MPS crashes
>> > > > > 
>> > > > > * src/gtkutil.c (free_glib_user_data): New function.
>> > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>> > > > > (qttip_cb, xg_create_frame_widgets)
>> > > > > (xg_create_frame_outer_widgets, create_dialog)
>> > > > > (make_cl_data, unref_cl_data, xg_mark_data)
>> > > > > (menuitem_highlight_callback, xg_create_one_menuitem)
>> > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>> > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>> > > > > (xg_im_context_commit, xg_widget_style_updated)
>> > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
>> > > > > (xg_initialize): Remove linked list if HAVE_MPS.
>> > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>> > > > > functions.
>> > > > > * src/xmenu.c (menubar_selection_callback)
>> > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'.
>> > > > 
>> > > > Hello,
>> > > > 
>> > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
>> > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
>> > > > following on my system:
>> > > 
>> > > Thank you! Can you let me know which gtk/glib version that is? I'd
>> > > like to check the source code to make sure we can pass the right
>> > > flag instead.
>> > > 
>> > > I think we're okay just passing 0 instead.
>> > > 
>> > > Pip
>> > 
>> > Should be GTK 3.24.33 and glib 2.0.
>> 
>> 
>> Passing 0 is correct.
>
> Thank you both, just pushed a fix. Please let me know if it isn't working.

Builds again here thanks

  Andrea

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

scratch/igc doesn't seem to be a very clear name for ode to work with the MPS
garbage collectr.  While it is still not installed, is this a good time
to rename it to the "MPS gc branch"?
-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Pip Cet]

On Thursday, July 11th, 2024 at 02:32, Richard Stallman <rms@gnu.org> wrote:
> scratch/igc doesn't seem to be a very clear name for ode to work with the MPS
> garbage collectr. While it is still not installed, is this a good time
> to rename it to the "MPS gc branch"?

I don't have a strong preference, but I think I'd prefer it if extensions to the GC interface that might be useful for other GC implementations (and that's most of the changes outside of "igc.c") used plain gc_ prefixes. So my proposal would be to rename the branch to scratch/mps-gc (or feature/mps-gc), and try to reduce usage of the igc identifier (I believe all "mps" identifiers already are isolated to igc.c; perhaps that file should be renamed, too).

Gerd, what do you think?

Pip

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Gerd Möllmann]

I don’t think I have a strong opinion on that

Sent from my iPhone

> On 13. Jul 2024, at 22:35, Pip Cet <pipcet@protonmail.com> wrote:
> 
> On Thursday, July 11th, 2024 at 02:32, Richard Stallman <rms@gnu.org> wrote:
>> scratch/igc doesn't seem to be a very clear name for ode to work with the MPS
>> garbage collectr. While it is still not installed, is this a good time
>> to rename it to the "MPS gc branch"?
> 
> I don't have a strong preference, but I think I'd prefer it if extensions to the GC interface that might be useful for other GC implementations (and that's most of the changes outside of "igc.c") used plain gc_ prefixes. So my proposal would be to rename the branch to scratch/mps-gc (or feature/mps-gc), and try to reduce usage of the igc identifier (I believe all "mps" identifiers already are isolated to igc.c; perhaps that file should be renamed, too).
> 
> Gerd, what do you think?
> 
> Pip

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Andrea Corallo]

Pip Cet <pipcet@protonmail.com> writes:

> On Thursday, July 11th, 2024 at 02:32, Richard Stallman <rms@gnu.org> wrote:
>> scratch/igc doesn't seem to be a very clear name for ode to work with the MPS
>> garbage collectr. While it is still not installed, is this a good time
>> to rename it to the "MPS gc branch"?
>
> I don't have a strong preference, but I think I'd prefer it if
> extensions to the GC interface that might be useful for other GC
> implementations (and that's most of the changes outside of "igc.c")
> used plain gc_ prefixes. So my proposal would be to rename the branch
> to scratch/mps-gc (or feature/mps-gc), and try to reduce usage of the
> igc identifier (I believe all "mps" identifiers already are isolated
> to igc.c; perhaps that file should be renamed, too).
>
> Gerd, what do you think?
>
> Pip

I agree and suggest as well feature/mps-gc (or feature/mps_gc).  I think
would be more identifiable and as feature branch should get more
visibility and hopefully users testing it.

Bests

  Andrea

Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes

[Stefan Kangas]

Andrea Corallo <acorallo@gnu.org> writes:

> I agree and suggest as well feature/mps-gc (or feature/mps_gc).  I think
> would be more identifiable and as feature branch should get more
> visibility and hopefully users testing it.

I don't think renaming should be much work, so how about going ahead
with either of those names?