From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct Date: Fri, 15 Mar 2024 21:45:39 -0400 Message-ID: References: <170700201601.3724.18410252880023545872@vcs2.savannah.gnu.org> <20240203231336.5A511C0EFF8@vcs2.savannah.gnu.org> Reply-To: rms@gnu.org Content-Type: text/plain; charset=Utf-8 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27506"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 16 02:46:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlJ7c-0006ww-CJ for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Mar 2024 02:46:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlJ7H-0008I5-AH; Fri, 15 Mar 2024 21:45:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlJ7E-0008HK-Jz for emacs-devel@gnu.org; Fri, 15 Mar 2024 21:45:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlJ7E-0006vY-Aw; Fri, 15 Mar 2024 21:45:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=EsiFX48LZ2/C9O59w0c+fmcxVlH25pTrk89939JwsfA=; b=WAAU6ZN56amJ udrLzY6BA/dSxAWUfJDFF+gsizSUVMbjBxash//ZomWMffpQvIRKFuJNztKJAVitjeFUHnLRoBFfE oOOubXqCfQFgLu1wxa7SlBKhAxg9MmpMMkUCijLygWqiYxVhfcy7pNBwyA9dZ+R/svLxbeBm8IbvV 7+O1EMc/4ySRaA8Rz15qGiZLjrmWYm+9FFlmcolPp0PLGonE2FR7pqmrS2XhlRNu32JgAMoWHLmHS 0lczvhwh7i3RsQk3NZ4jGEUMphnX2AqUO0TazhVok2DOXdPNgUaqSUk8lWJbNXQNgu+pJ/ojDUxIS DEF75yyPy5P3Z5z4hojJOQ==; Original-Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rlJ7D-0000em-KN; Fri, 15 Mar 2024 21:45:39 -0400 In-Reply-To: (emacs-devel@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317094 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > BTW, the compiler already emitted a warning for it, but saying only > that there was a call to an unknown function `,`, and without specifying > where that call was found. Right. It was very difficult to find where that warning was coming from. It turns out that searching for a comma finds lots of matches that do not represent anything wrong. > So now we get a duplicate warning: > In my-foo: > foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote > In end of data: > foo.el: Warning: the function ‘,’ is not known to be defined. The mew warning (shown first above) is better), so I'd suggest disabling the old (second) warning for this function. > Maybe the better fix is to improve the "function ‘,’ is not known to > be defined" warning so it points to the right location? It would be useful to improve the "function XYZ is not known to be defined" warning in that way -- but, in the special case of comma, the newer more specific warning is better. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)