From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded. Date: Wed, 06 Dec 2023 21:49:43 -0500 Message-ID: References: <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org> <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org> Reply-To: rms@gnu.org Content-Type: text/plain; charset=Utf-8 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, luangruo@yahoo.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 07 03:50:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB4Sq-0004z6-N4 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Dec 2023 03:50:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB4SQ-00020a-0w; Wed, 06 Dec 2023 21:49:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB4SO-0001xi-H3 for emacs-devel@gnu.org; Wed, 06 Dec 2023 21:49:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB4SN-0007Ee-T7; Wed, 06 Dec 2023 21:49:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=DkS7T+z91ZuclqdeTwIwMX0dqnUVx/Qckb8vvGr28F0=; b=ohEIOgINBybO kPUvvlx94wWJ2ppIVh/TzQ/Dt+oujpzKOsxNDQyOcQKZvHXLFnOuJqpmOlV+Bmc197Ex9zxDlYpEm EG6U5IueN7u6B3HT15Eedj6IG5rkQrZ4hlfWvXclHC3tn9mrZaRsK4z8NzwR11hCM1DnmYQakWbk9 QReOKIGHkBSJ70GTAW9naw4d13LPnF087LKv/QYpInHaJhrcknn/OGHBu2P4gaEjVh5x4f16B9y4h gM6tVanw4ymNbJ1md6Ult/TMbcGcoqebn83ylys8Dvper+Lyff/Uoz4px2YTBOQA8IMvDGa3BkJOd 6uncV77+IbAVPcjrXFXOaQ==; Original-Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rB4SN-000699-Lz; Wed, 06 Dec 2023 21:49:43 -0500 In-Reply-To: (message from Stefan Monnier on Tue, 05 Dec 2023 18:20:19 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313577 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > IOW, merge `insert-directory` and `ls-lisp--insert-directory` > by allowing `insert-directory-program` to be nil > (as a replacement for the `ls-lisp-use-insert-directory-program` > boolean) in which case we use the ls-lisp code? That is a good change to make. For parts of Emacs to put advice on functions in Emacs is asking for confusion in future debugging, because there is no clue in the advised functions that advice might be on them. With this change, the use of the variable `insert-directory-program' will show people that they should check that variable's value to see what is really going on! -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)