unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Make ispell localwords safe local variable
Date: Wed, 16 Aug 2023 22:00:44 -0400	[thread overview]
Message-ID: <E1qWSJY-0006R6-CH@fencepost.gnu.org> (raw)
In-Reply-To: <87h6ozdalc.fsf@breatheoutbreathe.in> (message from Joseph Turner on Tue, 15 Aug 2023 18:41:18 -0700)

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > >> In this PR <https://github.com/alphapapa/makem.sh/pull/39>, we made it
  > >> possible for checkdoc/ispell to ignore localwords stored in a
  > >> .dir-locals.el when run in batch mode.

  > > I'm not sure this is indeed safe enough.  We send these words to the
  > > spell-checker; are we sure this couldn't be abused by malicious people
  > > to perform some destructive actions?

  > I am not sure. Unless someone can be certain that ispell can safely
  > handle arbitrary strings, I think it's prudent to discard this patch.

Suppose it doesn't handle arbitrary strings -- what's the worst that
could happen?  Ispell would crash perhaps?

I think it would be ok to give users a chance to try using this and see

Another idea: scan the localwords for "reasonableness", perhaps if in
each word all the characters fit into certain classes of reasonable
characters for wrds.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





      parent reply	other threads:[~2023-08-17  2:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15  5:40 [PATCH] Make ispell localwords safe local variable Joseph Turner
2023-08-15 11:56 ` Eli Zaretskii
2023-08-16  1:41   ` Joseph Turner
2023-08-16 12:20     ` Eli Zaretskii
2023-08-16 17:12       ` Jim Porter
2023-08-16 23:04         ` Joseph Turner
2023-08-26  8:10           ` Eli Zaretskii
2023-12-01  6:56             ` Joseph Turner
2023-12-01  8:03               ` Eli Zaretskii
2023-12-01  8:24                 ` Joseph Turner
2023-12-01 11:28                   ` Eli Zaretskii
2023-08-17  2:00     ` Richard Stallman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1qWSJY-0006R6-CH@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joseph@breatheoutbreathe.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).