unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: eliz@gnu.org, emacs-devel@gnu.org, manuel@ledu-giraud.fr
Subject: Re: emacs-29 dc78779c0c: Fix SVG scaling (bug#59802)
Date: Sat, 17 Dec 2022 22:23:30 -0500	[thread overview]
Message-ID: <E1p6kGw-0007An-Tn@fencepost.gnu.org> (raw)
In-Reply-To: <87len6fjdb.fsf@yahoo.com> (message from Po Lu on Sat, 17 Dec 2022 17:51:44 +0800)

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > v = rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
  >     + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000;

  >   but Emacs would alter it.  Adding a set of parentheses produces
  >   something that looks equally nice, and which Emacs will preserve:

  > v = (rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
  >      + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000);

You're right, these parentheses should be added.  There is no downside
to them, and they will keep the code looking good if it happens to be
reindented.

If I were doing anything with that code, I would add them.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





      parent reply	other threads:[~2022-12-18  3:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167120580083.8436.12355011753442988358@vcs2.savannah.gnu.org>
     [not found] ` <20221216155001.8BDCAC0060F@vcs2.savannah.gnu.org>
2022-12-17  1:26   ` emacs-29 dc78779c0c: Fix SVG scaling (bug#59802) Po Lu
2022-12-17  8:25     ` Eli Zaretskii
2022-12-17  9:51       ` Po Lu
2022-12-17 10:38         ` Eli Zaretskii
2022-12-17 17:18           ` Manuel Giraud
2022-12-17 17:53             ` Eli Zaretskii
2022-12-18  3:23         ` Richard Stallman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1p6kGw-0007An-Tn@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).