From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 02:51:45 -0400 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <83sfldu147.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, dgutov@yandex.ru, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 08:53:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTHbA-0006h7-89 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 08:53:16 +0200 Original-Received: from localhost ([::1]:56116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTHb8-0003On-Jq for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 02:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTHZl-0002Yd-Td for emacs-devel@gnu.org; Wed, 31 Aug 2022 02:51:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTHZi-0008TE-6u; Wed, 31 Aug 2022 02:51:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=wHbGQrZaMMyR4nU7IyXgZiJdpzcf/VDAUxaEnB12w/o=; b=kGeZWc9jmOx5 4sp6IYDcy8OX/zpmdlAN5aGPdqAoTAsvDVoWM9g6GuzMBcvGPLeYWtszfC/d1izWjIEYDpr6wVraQ KjwEMtZ1dCclAMMnjlIzWQ2amP78jVIBSptb65pZstz3aBOkYyg2wPX4YEfynBEz+4nmvmiDAKKSb anxwZrya5rHlPlh2CYZg7Snsr9pe6YZIrqKO3amfIXw64nG9XMaBikQFA+aXFPKTtD3wsr3/cjV9d DkHkL6+8jsVH69lMQ+qVaDuC/G+eeVEy0mhtJMJKQxrshF+ILpB1NtI7hZw0V2mBuJ8BC6aFggJS1 obJUSXtDtA7DzgmNYg8j+w==; Original-Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1oTHZh-0006D9-Kh; Wed, 31 Aug 2022 02:51:45 -0400 In-Reply-To: <83sfldu147.fsf@gnu.org> (message from Eli Zaretskii on Tue, 30 Aug 2022 19:50:32 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294403 Archived-At: > From: Stefan Monnier > Cc: "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, > juri@jurta.org, emacs-devel@gnu.org > Date: Tue, 30 Aug 2022 11:16:17 -0400 > > > I can look into adapting this approach for other VCS if nobody beats me to > > it. As long as we fundamentally agree on the behavior. > > Fine by me. I'll just mention that I think we should be careful to make > sure no info is lost if Emacs crashes in the middle of the operation. Emacs never crashes. :-) But why is it important that no info is lost during a crash? *vc-diff* buffers, and in general any non-file associated buffer is always lost in the case of a crash.