From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 10:20:08 -0400 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40640"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 16:21:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT27E-000AQM-Ne for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 16:21:20 +0200 Original-Received: from localhost ([::1]:41628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT27D-00043Y-D4 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 10:21:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT26V-0003KF-Ap for emacs-devel@gnu.org; Tue, 30 Aug 2022 10:20:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT26U-0004YC-Ej; Tue, 30 Aug 2022 10:20:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=JcgFopFng4QoKzPbhay9ghnjC5nxdNH0Og44pvXBxy0=; b=R/65vLkUDzH3 BCa1JLBUx4ROK5arYg+t5Kf4repo7znykBxywY/zZuIg9VJIUYd1pRcC7BdnlhzWtZcJupRwhPtCt s7ZgH9taVY4u/PZk/KVpIEFqMu48lpbiUfgwRqePObn2s6O/dW6p3M05Bxdg6uWGsQ8kxmOJLyp3I vXnuOyxVgOGFgpFlZeq3R5Yk3pUY2AXvTiwPWqw1O3PzpIqX4pMIgJqgOgCAHGMg9KB4BzWOk1gzW EDnkny/sf/IBzk1sUXebkBKRYdP4tHrTUqoUSK5B2fzV4YLLscbPYiWmtp/oQTitdTnrN6I11FZ50 jieTHEiVi75qk7AdEL04DQ==; Original-Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1oT264-0003Gz-Ph; Tue, 30 Aug 2022 10:20:33 -0400 In-Reply-To: <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> (message from Dmitry Gutov on Tue, 30 Aug 2022 17:08:09 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294346 Archived-At: On 30.08.2022 16:25, Alfred M. Szmidt wrote: > This is a pitty indeed. Specially seeing that it is easy enough to > get this working for all VCSs. Here is a hack I wrote ages ago, and > this works for just about everything, it doesn't do exactly what is > needed (e.g, this works on a single file basis) but it isn't too hard > to get that working. This indeed could work as an approach (I suggested /tmp, you are using a single buffer to back up contents, but the effect should be the same). Yup, a temp file would make it work for multiple files. Do you like the current behavior with Git, though? Or do you perhaps have the same misgivings as Eli? I've not tried Juri's change, but from the point of maintaining vc-fossil it would mean that I need to figure out how to implement this vc-checkin-patch function (and likewise for anyone else), specially when there is no need to make this git specific for the most common case.