From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Thu, 19 May 2022 02:11:14 -0400 Message-ID: References: <83pmkbf5a9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="876"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 08:13:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrZPM-000AZu-2q for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 08:13:12 +0200 Original-Received: from localhost ([::1]:58436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrZPL-0001Rk-3h for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 02:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrZNT-0008NB-7r for emacs-devel@gnu.org; Thu, 19 May 2022 02:11:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrZNS-0004Ty-TC; Thu, 19 May 2022 02:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=GwyRFxdgNOL7PLvwfBBbuWr1nOUe1xpmUL+Hm3JznoY=; b=aaSA2kYgVYPy 24TRbjvjW0/NhCXScyDF1hqtynXYB3sNS42wvSMMBPsiGJt0eSyWpHkpNnDKm/HuYN7Nw/Q7zUPr8 sEQlct7rGdhxLB5f4ek9+lQL296rcoxMzPn6+HeiOZi+5GVIRhftF6EmkL5MM8csHlzjb4WAvwVp3 eyan3Qzl7snv0ithUqpuoLC265r7dR/qg/NesdI8+lSjTsFClB1ywy7ktajuIf/cQDo5G0NTDev52 wBTocxP2QXc3NSD70LAfsk9yK5voDcJ5PzkTyjmBpAYS6XtyC4QJxV/VI9OV/TddvSy/LZv+LJj3x 4kZ9hbkQ3Dxrd4zOzzL5bw==; Original-Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1nrZNS-0001w8-LJ; Thu, 19 May 2022 02:11:14 -0400 In-Reply-To: <83pmkbf5a9.fsf@gnu.org> (message from Eli Zaretskii on Wed, 18 May 2022 14:29:02 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289954 Archived-At: > What about something like this, I've tested it briefly with a > vc-fossil-get-log-entry, and with RCS and it seems to behave as it > does previously -- though slightly confused by what it does for RCS > (it inserts the header, but not the commit?). Maybe it's me, but it looks a bit inelegant: log-view calls the VC backend, which then turns around and calls back into log-view? a VC method that isn't implemented in any backend, but instead does TRT for each backend "by hand"? Can't we come up with something cleaner, even if that requires to add a new function? It is a bit of a kludge, yes. If someone can come up with an idea how this could look like, I can try implementing that. But I won't be able to test this for SCSS, CVS, SVN or Hg which seem to support this -- the current patch should still keep those working as previously though which is probobly the only thing it has going for it... I think the modify-change-comment functionality hasn't seen much use, and still quite confused how it is intended to work. E.g., in RCS, I have this as the latest commit (and in log view mode): ---------------------------- revision 1.3 date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 Summary: this is a test message ---------------------------- At the beginning of the buffer, log-view-modify-change-comment, then you get a new buffer with the following: revision 1.3 date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 Note the lack of the actual log message. And when you C-c C-c that you get basically something that isn't very useful... ---------------------------- revision 1.3 date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 revision 1.3 date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 ----------------------------