From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Thu, 19 May 2022 02:11:11 -0400 Message-ID: References: <9f1b5ce9-270a-2cb4-d958-f7545fd7d373@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 08:13:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrZPL-000AYN-CR for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 08:13:11 +0200 Original-Received: from localhost ([::1]:58360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrZPK-0001Oo-4G for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 02:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrZNS-0008MY-GH for emacs-devel@gnu.org; Thu, 19 May 2022 02:11:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrZNQ-0004Th-Bh; Thu, 19 May 2022 02:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=ah7AYc7ceTdcVUbDfpAXqXUx6lKIRV5ROVEbKUjNDkQ=; b=VR5hmI9uuizX bNXzkjyTY4OE9RjCUdiZ/l+MKbLGyfFsFGgEpsZh8rKGvkkrHj7BZq8pYjRebAv9uIKZoCmWoqnn+ y/qu83N8XriAHLMLzQAbHQYtvrIipUni3QwESu0MWMY/qFN52EuXTUrvuR7Wjy1ychTTd/j8Daz59 MBRQ6piJV/JKYNrrEWdcvvb0fFLqtYA9KpzVNrnYXgMVuZQJs5iEdJTMBtb1qUjz0cDhj4iHa0KH+ jqAx1l5KhuAMuDCadx4PBLHu2pz5QtWTZFi/qri0amKBtF0NWwUOcJCs0a+IG/9Uail/2HY0TGXS4 aDJOC7mUFkcJpsujH+Ge/w==; Original-Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1nrZNP-0001vp-OC; Thu, 19 May 2022 02:11:12 -0400 In-Reply-To: <9f1b5ce9-270a-2cb4-d958-f7545fd7d373@yandex.ru> (message from Dmitry Gutov on Thu, 19 May 2022 03:05:30 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289953 Archived-At: On 18.05.2022 09:34, Alfred M. Szmidt wrote: > + "Extract the commit message for the current file." > + (vc-call-backend log-view-vc-backend > + 'get-log-entry > + (log-view-current-file) > + (log-view-current-tag))) Why not customize the extraction function only for backends that need it? This does that, no? If you don't have get-log-entry, then things work as previously. The backend command could be called 'extract-comment'. Which is somewhat different from "log entry" because the latter seems to include the headers, in VC parlance. And you haven't explained thus far your plan for implementing 'modify-change-comment' for e.g. Git. I have no plans on implementing such functionality for git.