From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Date: Wed, 24 Mar 2021 01:36:17 -0400 Message-ID: References: Reply-To: Eli Zaretskii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37723"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@catern.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 06:37:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOwCo-0009hC-T4 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 06:37:22 +0100 Original-Received: from localhost ([::1]:33392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOwCn-0002Va-PB for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 01:37:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOwBo-000238-Br for emacs-devel@gnu.org; Wed, 24 Mar 2021 01:36:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48420) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOwBn-0004Hu-Ai; Wed, 24 Mar 2021 01:36:19 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lOwBl-0000ZJ-Eo; Wed, 24 Mar 2021 01:36:17 -0400 In-Reply-To: (message from Spencer Baugh on Tue, 23 Mar 2021 23:11:50 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266919 Archived-At: > From: Spencer Baugh > Date: Tue, 23 Mar 2021 23:11:50 -0400 > Cc: Spencer Baugh , Eli Zaretskii , > Stefan Monnier > > Hi emacs-devel, Actually, it is best to send this (and patches in general) to bug-gnu-emacs@gnu.org, so that the whole discussion is recorded by our issue tracker. > These are some cleanups and tests for DEFVAR_PER_BUFFER variables. > I think they are all uncontroversial. > > These are extracted from the patch series I sent some months ago > (Subject: Speeding up DEFVAR_PER_BUFFER). Specifically, these are the > patches that were approved as fine independent of the rest of the > series. And they have changelog entries in the commit messages now :) > > These are pre-requisites for my DEFVAR_PER_BUFFER improvements (which > I'll be resending soon), so it would be nice to apply them ahead of > that. I'd prefer to pick up where we left off back then. The main issue left unresolved in the past discussion was the potential slowdown of simple accesses to buffer-local vars due to your proposal. Can we please have benchmarks for that, so we could decide whether the tradeoff is worth it? It's quite possible that the performance aspects could affect the code changes, so even uncontroversial cleanups should perhaps wait until we have figured out the more important aspects of these changesets. Thanks.