From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Delete variables obsolete since Emacs 23 Date: Wed, 26 Aug 2020 22:51:21 -0400 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> <20083fc0-59ca-444b-b18d-69e2f79d8c57@default> <87sgcknqz0.fsf@gnus.org> <8dacbc9d-def9-4d38-8f73-11de3884d927@default> Reply-To: rms@gnu.org Content-Type: text/plain; charset=Utf-8 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, larsi@gnus.org, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 27 04:52:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kB81D-0000tw-Ih for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Aug 2020 04:52:03 +0200 Original-Received: from localhost ([::1]:37524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB81C-0002yG-Kz for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Aug 2020 22:52:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB80a-00026y-HR for emacs-devel@gnu.org; Wed, 26 Aug 2020 22:51:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43759) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB80Z-0002YK-TH; Wed, 26 Aug 2020 22:51:23 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kB80X-0007LQ-6x; Wed, 26 Aug 2020 22:51:21 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 26 Aug 2020 06:22:28 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254267 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > My commit bc5da2c3fb does basically the following: > - (help-setup-xref (list 'describe-symbols pattern) (interactive-p)) > + (help-setup-xref (list 'describe-symbols pattern) > + (called-interactively-p 'interactive)) That is not the recommend way to fix these calls. called-interactively-p does not give the correct results in all situations. The right way is to make the optional argument. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)