From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: ams@gnu.org (Alfred M. Szmidt) Newsgroups: gmane.emacs.devel Subject: Re: eww and bookmarks Date: Mon, 25 May 2020 11:03:23 -0400 Message-ID: References: <87k1163jz5.fsf@gmail.com> <87zha21i17.fsf@gmail.com> <87pnau45wp.fsf@web.de> <87pnatlo1h.fsf@gmail.com> <87zh9wljig.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="114645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, orontee@gmail.com, npostavs@gmail.com, drew.adams@oracle.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 25 17:03:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdEdw-000Tit-Ox for ged-emacs-devel@m.gmane-mx.org; Mon, 25 May 2020 17:03:56 +0200 Original-Received: from localhost ([::1]:51426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdEdv-00031I-PR for ged-emacs-devel@m.gmane-mx.org; Mon, 25 May 2020 11:03:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdEdQ-0002XA-PP for emacs-devel@gnu.org; Mon, 25 May 2020 11:03:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50592) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdEdQ-0005WG-5v; Mon, 25 May 2020 11:03:24 -0400 Original-Received: from ams by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1jdEdP-0003ar-Q2; Mon, 25 May 2020 11:03:23 -0400 In-reply-to: (message from Stefan Monnier on Mon, 25 May 2020 08:51:23 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251367 Archived-At: >> Those that like EWW would already be doing: >> (setq browse-url-browser-function 'eww-browse-url) > Ok, so you would make the handler call `browse-url-browser-function', > and not eww unconditionally. I think I would prefer that behavior, too. FWIW, I would like to use bookmarks for EWW, and I'd like those bookmarks to *always* use EWW, and my `browse-url-browser-function` is definitely not EWW but Firefox. Wouldn't defadvice with browse-url-browser-function bound to eww-browse-url over browse-url-bookmark-jump be sufficient? Emacs bookmarks don't just refer to a particular "page" but also remember the place within that page (by remembering surrounding text) and I think this part can only work if we go back with EWW. Since the page was originally viewed in EWW the corresponding bookmark *by default* should use EWW as well. We can add a configuration option to make it obey `browse-url-browser-function` if you want, but it should not be the default behavior: a bookmark is supposed to bring you back to where it was created, so if it was created in EWW it shouldn't send you to Firefox. That sounds like confusing behaviour, you would never know what your bookmark jump would jump too -- somtimes it is EWW, somtimes it is Firefox, sometimes it might be a third thing?