From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: C warning in MSYS2 build Date: Fri, 06 Oct 2017 11:16:26 -0400 Message-ID: References: <83inftwhlb.fsf@gnu.org> <281d43c7-b3a9-be40-a8e7-c8021c286f59@cs.ucla.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: blaine.gmane.org Content-Type: text/plain; charset=Utf-8 X-Trace: blaine.gmane.org 1507303002 12716 195.159.176.226 (6 Oct 2017 15:16:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 15:16:42 +0000 (UTC) Cc: rcopley@gmail.com, eliz@gnu.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 17:16:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0UMd-0002Qg-FU for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 17:16:35 +0200 Original-Received: from localhost ([::1]:45464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0UMh-0003kV-PS for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 11:16:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0UMX-0003jM-Mn for emacs-devel@gnu.org; Fri, 06 Oct 2017 11:16:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0UMW-0001ur-UC for emacs-devel@gnu.org; Fri, 06 Oct 2017 11:16:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0UMV-0001sY-8d; Fri, 06 Oct 2017 11:16:27 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1e0UMU-0001vP-J6; Fri, 06 Oct 2017 11:16:26 -0400 In-reply-to: <281d43c7-b3a9-be40-a8e7-c8021c286f59@cs.ucla.edu> (message from Paul Eggert on Thu, 5 Oct 2017 12:32:26 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219188 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > The GCC bug is not fixed yet. etags.c confused GCC by using an > assignment inside an 'if' expression, which is contrary to the usual GNU > style, and last year I worked around the GCC bug by changing etags.c to > use a cleaner style. I notice that indent.c also has an assignment > inside an 'if' expression that is relevant to these warnings. Richard, > does it help to recode indent.c to use the usual GNU style, as in the > attached patch? I don't understand the question. An assignment inside an if condition is somewhat ugly, and moving the assignment out of the code is in general a good thing for clarity. So by all means do it. If that works around a GCC bug, that is good -- but the bug still needs to be fixed. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html.