org-agenda-phases-of-moon tries to call wrong function

org-agenda-phases-of-moon tries to call wrong function

[Teemu Likonen]

[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]

(Cc'ing to hopefully right people.)

Org-agenda-mode has an "M" key for org-agenda-phases-of-moon command
which tries to call function calendar-phases-of-moon. That function
doesn't exist anymore and should be calendar-lunar-phases instead. The
bug is in the master and emacs-25 branches. The attached trivial patch
fixes the problem (and I can push it myself if someone gives an OK).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-org-agenda-s-command-for-calendar-lunar-phases.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]

From b8b3d36eb6f5a8134955170657621828c9ebbf32 Mon Sep 17 00:00:00 2001
From: Teemu Likonen <tlikonen@iki.fi>
Date: Sun, 16 Apr 2017 16:14:22 +0300
Subject: [PATCH] Fix org-agenda's command for calendar-lunar-phases

Function org-agenda-phases-of-moon tries to call a non-existing
function calendar-phases-of-moon. The correct function is
calendar-lunar-phases.
---
 lisp/org/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el
index c870ddd..153e377 100644
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -9533,7 +9533,7 @@ org-agenda-execute-calendar-command
 (defun org-agenda-phases-of-moon ()
   "Display the phases of the moon for the 3 months around the cursor date."
   (interactive)
-  (org-agenda-execute-calendar-command 'calendar-phases-of-moon))
+  (org-agenda-execute-calendar-command 'calendar-lunar-phases))
 
 (defun org-agenda-holidays ()
   "Display the holidays for the 3 months around the cursor date."
-- 
2.1.4


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: org-agenda-phases-of-moon tries to call wrong function

[Paul Eggert]

Teemu Likonen wrote:
> The attached trivial patch
> fixes the problem (and I can push it myself if someone gives an OK).

Thanks, please push to master.

Re: org-agenda-phases-of-moon tries to call wrong function

[Glenn Morris]

Fixed years ago in standalone Org.
Will the Org in Emacs ever be synced again, I wonder.

Re: org-agenda-phases-of-moon tries to call wrong function

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Will the Org in Emacs ever be synced again, I wonder.

When was it last merged?

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Re: org-agenda-phases-of-moon tries to call wrong function

[Glenn Morris]

Richard Stallman wrote:

>   > Will the Org in Emacs ever be synced again, I wonder.
>
> When was it last merged?

commit e175fab
Author: Bastien Guerry
Date:   Mon Oct 13 00:25:24 2014 +0200

    Sync Org 8.2.10

Re: org-agenda-phases-of-moon tries to call wrong function

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

It is unfortunate to go over 2 years without incorporating the Org
mode changes into Emacs.

We previously discussed my view that certain parts of Org mode
perhaps should be separate from it.  I still think it is a problem
that so many different features are treated as a single subunit
within Emacs.  But that doesn't mean they shouldn't be maintained.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Re: org-agenda-phases-of-moon tries to call wrong function

[Bastien]

Richard Stallman <rms@gnu.org> writes:

> It is unfortunate to go over 2 years without incorporating the Org
> mode changes into Emacs.

Indeed.  We will do our best to sync more regularily now.

-- 
 Bastien