From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] RFC: eldoc-documentation-functions hook Date: Mon, 13 Jun 2016 16:36:05 -0400 Message-ID: References: <20160612061229.GA6463@holos.localdomain> <20160612185237.GA12617@holos.localdomain> <20160612194452.GA12853@holos.localdomain> Reply-To: rms@gnu.org NNTP-Posting-Host: plane.gmane.org Content-Type: text/plain; charset=Utf-8 X-Trace: ger.gmane.org 1465850195 17639 80.91.229.3 (13 Jun 2016 20:36:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2016 20:36:35 +0000 (UTC) Cc: npostavs@users.sourceforge.net, emacs-devel@gnu.org, dgutov@yandex.ru To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 13 22:36:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCYaw-0007Ln-9X for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 22:36:26 +0200 Original-Received: from localhost ([::1]:59123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCYav-0000Gg-Ij for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 16:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCYan-0000F7-Bc for emacs-devel@gnu.org; Mon, 13 Jun 2016 16:36:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCYam-0001ZL-EZ for emacs-devel@gnu.org; Mon, 13 Jun 2016 16:36:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCYae-0001Y7-1s; Mon, 13 Jun 2016 16:36:08 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bCYab-0002tF-Ud; Mon, 13 Jun 2016 16:36:06 -0400 In-reply-to: <20160612194452.GA12853@holos.localdomain> (message from Mark Oteiza on Sun, 12 Jun 2016 15:44:52 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204344 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] It is asking for trouble to have anything in the Emacs sources put advice onto any function, because it interferes with debugging. If you see a call to function foo, which has advice on it, you will be perplexed why its behavior does not match its source. (If you wrote the advice, you won't have this problem if you remember that you put the advice on.) A hook is cleaner, because the call to run-hooks in the source code of foo informs you that you should check what hook functions there are. Thus, I ask people to take care not to install anything in the Emacs sources which creates advice -- and to replace any existing advice with hooks. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html.