Patch to rmail.el and sendmail.el needs to go in 24.1.

Patch to rmail.el and sendmail.el needs to go in 24.1.

[Richard Stallman]

I just installed in the trunk a patch in rmail.el and sendmail.el
that I believe is the right fix for the problems I reported.
This bug fix avoids selection of ` *message-viewer RMAIL*'
and similar buffers.

Since it avoids a dangerous bug, it ought to go in 24.1.
Can someone please put it there?

--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use Ekiga or an ordinary phone call

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Andreas Schwab]

Richard Stallman <rms@gnu.org> writes:

> Since it avoids a dangerous bug, it ought to go in 24.1.
> Can someone please put it there?

You should have put it there in the first place.  Now we get a useless
duplication of the commit.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Richard Stallman]

    > Since it avoids a dangerous bug, it ought to go in 24.1.
    > Can someone please put it there?

    You should have put it there in the first place.

Please forgive me.  With my rudimentary knowledge of using Bzr -- I
only know how to work with the trunk -- I had no idea it would make a
difference which place the patch gets installed first.  I don't know
why it makes a difference, but please don't explain; I will take your
word for that.

--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use Ekiga or an ordinary phone call

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Andreas Schwab]

Richard Stallman <rms@gnu.org> writes:

> With my rudimentary knowledge of using Bzr -- I only know how to work
> with the trunk

There is really no difference between the branches.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Paul Eggert]

On 04/18/2012 11:25 AM, Richard Stallman wrote:
>     > Since it avoids a dangerous bug, it ought to go in 24.1.
>     > Can someone please put it there?

I tried to do that, but the patch collides with a recent
patch that was recently applied to the 24.1 branch
(please see below for a copy of the colliding patch).
Since I don't understand the code I left it alone;
perhaps you or Chong can comment when you have the time.


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-04-15 08:49:24 +0000
+++ lisp/ChangeLog	2012-04-16 10:11:45 +0000
@@ -1,3 +1,8 @@
+2012-04-16  Chong Yidong  <cyd@gnu.org>
+
+	* mail/sendmail.el (mail-bury): Call return action with the right
+	Rmail buffer (Bug#11242).
+
 2012-04-15  Chong Yidong  <cyd@gnu.org>
 
 	* server.el (server-process-filter): Handle corner case where both

=== modified file 'lisp/mail/sendmail.el'
--- lisp/mail/sendmail.el	2012-04-03 10:21:47 +0000
+++ lisp/mail/sendmail.el	2012-04-16 10:11:45 +0000
@@ -864,7 +864,7 @@
     (unless return-action
       (dolist (buffer (buffer-list))
 	(if (eq (buffer-local-value 'major-mode buffer) 'rmail-mode)
-	    (setq return-action `(rmail-mail-return ,newbuf)))))
+	    (setq return-action `(rmail-mail-return ,buffer)))))
     (if (and (null arg) return-action)
 	(apply (car return-action) (cdr return-action))
       (switch-to-buffer newbuf))))

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Richard Stallman]

My patch includes Yidong's patch.  Please install my patch.

--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use Ekiga or an ordinary phone call

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Paul Eggert]

On 04/19/2012 05:46 AM, Richard Stallman wrote:
> My patch includes Yidong's patch.  Please install my patch.

OK, I've done that in the emacs-24 branch as bzr 107875.

By the way, this change causes the following new warning
to be generated when compiling mail/rmail.el:

In rmail-yank-current-message:
rmail.el:3570:18:Warning: `insert-buffer' used from Lisp code
That command is designed for interactive use only

The same new warning is also in the trunk, so I assume it's
intentional, but I thought I'd mention it to double-check.

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Glenn Morris]

Paul Eggert wrote:

> OK, I've done that in the emacs-24 branch as bzr 107875.

Pet peeve, from admin/notes/bzr:

    * Backporting a bug-fix from the trunk to a branch (e.g. "emacs-23").
    Indicate in the commit log that there is no need to merge the commit
    to the trunk.  Anything that matches `bzrmerge-skip-regexp' will do;
    eg start the commit message with "Backport:".  This is helpful for the
    person merging the release branch to the trunk.

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Paul Eggert]

On 04/20/2012 01:19 PM, Glenn Morris wrote:

>     * Backporting a bug-fix from the trunk to a branch (e.g. "emacs-23").
>     Indicate in the commit log that there is no need to merge the commit
>     to the trunk.  Anything that matches `bzrmerge-skip-regexp' will do;
>     eg start the commit message with "Backport:".

Thanks, sorry, I didn't know that; this was my first backport.
I'll try to do better next time.

Re: Patch to rmail.el and sendmail.el needs to go in 24.1.

[Richard Stallman]

    In rmail-yank-current-message:
    rmail.el:3570:18:Warning: `insert-buffer' used from Lisp code
    That command is designed for interactive use only

`insert-buffer' is correct here, but there should be something
to suppress the warning.

However, this shows me another bug.

--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use Ekiga or an ordinary phone call